From patchwork Sat Mar 19 14:02:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: li.haolin@qq.com X-Patchwork-Id: 1607365 X-Patchwork-Delegate: rfried.dev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=qq.com header.i=@qq.com header.a=rsa-sha256 header.s=s201512 header.b=GGqV+6hk; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KLMzW1f0lz9s5P for ; Sun, 20 Mar 2022 01:03:17 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 56714838E1; Sat, 19 Mar 2022 15:03:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=qq.com header.i=@qq.com header.b="GGqV+6hk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3C537838B9; Sat, 19 Mar 2022 15:03:07 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, HELO_DYNAMIC_IPADDR,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RDNS_DYNAMIC, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 Received: from out203-205-221-210.mail.qq.com (out203-205-221-210.mail.qq.com [203.205.221.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 04E7483689 for ; Sat, 19 Mar 2022 15:03:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=li.haolin@qq.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1647698570; bh=lv1Zu/LA79RtzW3hwpBW52yPHstMD+M+V9BBbBVwwRI=; h=From:To:Cc:Subject:Date; b=GGqV+6hkonCSDIgwvm89UXn5M9uJdjZXbCUhHLfM46c018S5YlZ7tIiPAhMSvzsTY fOkKBAfG03cjz8ndF+mz1hqsHKxumAyRyKU6lxYh9CgoRLaq4XwcGS8j2kXxAN3Y/r xUupB5ZRizm1hVkBMicnms6n4KVL6DScCuQmpvXM= Received: from ubuntu.localdomain ([112.4.46.172]) by newxmesmtplogicsvrszc6.qq.com (NewEsmtp) with SMTP id B0B2412; Sat, 19 Mar 2022 22:02:48 +0800 X-QQ-mid: xmsmtpt1647698568twsd3v971 Message-ID: X-QQ-XMAILINFO: OQhZ3T0tjf0atFvOlrVsC5nhzU7EXR/sGPyyLdTf9aFp5Mj5c6aACLpmaq4+Kf b5oWq5xdokHTwwez4aUzrzRiCsmJeZjPLcCx9P3bGHmvNoSk0IExgIZ7dM0TPCEhOHvOagjq07UT ys9HuJQ0sJFOBvKuh7N5Xx+yuqdKkf8aXWZVyLWWBz86ApMlLJN8Am7MLTSxx4UM/3i38j1VwkRz UlSnhEwTgbXlVhWLHSUpHJph75GmoHjSnVodwkzcyCaJxkSvEWIacgHDIAjDAKKd/dEnbuwA9ECV U4ckAeCYOcRDJPmpVDX/bVXOAcdECaBZALIv3pW/JtUx4eU/967vkJ2fcT6UaZEtCEIKFxdQYXS4 KnI4jRp/uGtmgB2EoFrhBeT4+pz9bjx1VeFihQ0XShW0b11iEzhaCKDdJVq3EPvgaW6Bmkt0Cn2e KXD5ebdcFyhNPrzddXDA1p2s4I+uUg1/bhJym+ZZ6Cakrqn/YvLutfkcAJU0uOGO1uLh7w4TC6Vb bZYgCZ7xPkS0LSb+qZyw0bjUZfiGz19WsZIoW51nIjv+cALeyxcPZ6XcwaW0Tb6NBtpx2R4rf9BG IWpgFZanpAAF/+ptMZbGc/SESOWDIWvMfdjgsTiqE0mKXrbGIHhDNp+hLQe5qAsMEXyk1DXdohNn zbDgX4nJYajfaLcZcs8/Zp4RpoCqMEPv/+Cm8QaEuJdJMwEfP0zvIGTLYQZ4lUzXpdWvVcY3dsX1 HWVF/Qf2VnZjum++eLqRXNzU0Ky/OQ2OhVAMemd6RHpr++NOaZsK0EhZcH1A4SGf6hA52vvOYHb8 C5EkKJhPFhWvVnCkHMs+mE5QMSPMn1b/AQoOYNOVaR4mRwd/xXVmnI9IA6jns7UNUTGeKK0snQEk 3PZ3QzP6V2w80vCL8FCbTq6mkFuU36q8XefKt0joPi From: li.haolin@qq.com To: joe.hershberger@ni.com, rfried.dev@gmail.com Cc: u-boot@lists.denx.de, Haolin Li Subject: [PATCH] net: phy: dp83867: Fix a never true comparison Date: Sat, 19 Mar 2022 07:02:42 -0700 X-OQ-MSGID: <20220319140242.86859-1-li.haolin@qq.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean From: Haolin Li The type of the return value of phy_read() and phy_read_mmd() is int. Change the variable to not be unsigned so that we not get into an unsigned compared against 0. Signed-off-by: Haolin Li Reviewed-by: Ramon Fried --- drivers/net/phy/dp83867.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index eada4541c9..c5d44f4629 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -266,7 +266,7 @@ static int dp83867_of_init(struct phy_device *phydev) static int dp83867_config(struct phy_device *phydev) { struct dp83867_private *dp83867; - unsigned int val, delay, cfg2; + int val, delay, cfg2; int ret, bs; dp83867 = (struct dp83867_private *)phydev->priv; @@ -291,8 +291,11 @@ static int dp83867_config(struct phy_device *phydev) if (phy_interface_is_rgmii(phydev)) { val = phy_read(phydev, MDIO_DEVAD_NONE, MII_DP83867_PHYCTRL); - if (val < 0) + if (val < 0) { + ret = val; goto err_out; + } + val &= ~DP83867_PHYCR_FIFO_DEPTH_MASK; val |= (dp83867->fifo_depth << DP83867_PHYCR_FIFO_DEPTH_SHIFT);