diff mbox series

[8/9] cmd: Kconfig: Fix dependencies for CMD_USB_MASS_STORAGE

Message ID ec25f47c765785ef05d66a12773dec76b7223d5b.1597826658.git.michal.simek@xilinx.com
State New
Delegated to: Tom Rini
Headers show
Series Incorrect Kconfig dependencies | expand

Commit Message

Michal Simek Aug. 19, 2020, 8:44 a.m. UTC
There are missing dependencies for selecting USB_FUNCTION_MASS_STORAGE.
Change select to depends on instead of selecting all required options.
Kconfig reports this issue as:
WARNING: unmet direct dependencies detected for USB_FUNCTION_MASS_STORAGE
  Depends on [n]: USB [=n] && USB_GADGET [=n] && USB_GADGET_DOWNLOAD [=n]
  Selected by [y]:
  - CMD_USB_MASS_STORAGE [=y]

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 cmd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Aug. 19, 2020, 12:38 p.m. UTC | #1
On Wed, Aug 19, 2020 at 10:44:22AM +0200, Michal Simek wrote:

> There are missing dependencies for selecting USB_FUNCTION_MASS_STORAGE.
> Change select to depends on instead of selecting all required options.
> Kconfig reports this issue as:
> WARNING: unmet direct dependencies detected for USB_FUNCTION_MASS_STORAGE
>   Depends on [n]: USB [=n] && USB_GADGET [=n] && USB_GADGET_DOWNLOAD [=n]
>   Selected by [y]:
>   - CMD_USB_MASS_STORAGE [=y]
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  cmd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index f291c8cbf423..eebaaa420bf1 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1367,7 +1367,7 @@ config CMD_ROCKUSB
>  
>  config CMD_USB_MASS_STORAGE
>  	bool "UMS usb mass storage"
> -	select USB_FUNCTION_MASS_STORAGE
> +	depends on USB_FUNCTION_MASS_STORAGE
>  	help
>  	  USB mass storage support

Similar to the SDP issue, perhaps we have USB symbols that in turn need
to be select'ing other library functions they use?
diff mbox series

Patch

diff --git a/cmd/Kconfig b/cmd/Kconfig
index f291c8cbf423..eebaaa420bf1 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1367,7 +1367,7 @@  config CMD_ROCKUSB
 
 config CMD_USB_MASS_STORAGE
 	bool "UMS usb mass storage"
-	select USB_FUNCTION_MASS_STORAGE
+	depends on USB_FUNCTION_MASS_STORAGE
 	help
 	  USB mass storage support