From patchwork Wed Aug 8 11:37:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 954913 X-Patchwork-Delegate: monstr@monstr.eu Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="con10T0B"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 41lqFF2pGXz9ryt for ; Wed, 8 Aug 2018 21:40:17 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 145A8C21FE5; Wed, 8 Aug 2018 11:38:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 5E428C22009; Wed, 8 Aug 2018 11:38:02 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id BA0F1C2200A; Wed, 8 Aug 2018 11:37:58 +0000 (UTC) Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by lists.denx.de (Postfix) with ESMTPS id CD761C2200C for ; Wed, 8 Aug 2018 11:37:53 +0000 (UTC) Received: by mail-wm0-f45.google.com with SMTP id l2-v6so394207wme.1 for ; Wed, 08 Aug 2018 04:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=Wv0uPBqrcaoYP9c7Kvxj1nhCsWkLs+Jms/IdEypkPFQ=; b=con10T0BkIFw3Un85d4lbv4LBqvV45Cx98C6CiW+d5ionbKltSpm/JTrIRWczgshqj TA2lQE6qHEYdbMI8WdSJTxXOGKlXZk3iJTHmoFeFChHMD9FwlS47YGsUL4GtGgZbZ4Oe F7e3ela9BpCxuakRiv6ACH3kwYeIHZc23WVki2/lcERZSMhQyxzxixA0eo1wsXeEbRvi j8vE+xB5tW/0yo261j7b1YQrGJOdie5hPJWmNqPwSDEVtSFYNEJHFIF6lLd8sNPLGfsN wyGx1DEo6wxzBqmKkd2pMkSgo5iBtHntWzY3Fx3ZmAKmgijrEuCMCbHCyzUQNwBt9jHD S0sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=Wv0uPBqrcaoYP9c7Kvxj1nhCsWkLs+Jms/IdEypkPFQ=; b=Pj/xRoTpMnVirpRPjeUELocL6s8Q942OjmIWditHgTPsBg1IEMBRX1sXwB+CuE2BoI I5wI1BPSFtA0AANQyxj3bvc+kYqrFCye5hAYKjuNaq212CTxa+2pi0O2u6owIDi+MekN vVQHc1ls/blVcqX2OXsfw0zh7aeylzchxSZGlvZyHJeuKzdNEWw9CyeA3Hg6rTl0KiWU ZAlbqnxHeNhoqsMvK48ltD+VEXhEI8ueKtKUW6OMNscThdqcCc9AafX9XccFI600Udz/ 05pPbYGyZPoRCMvNSqVOs8ydeqV/8tXHwdZdidorLCgYdCWiQbbli4EUD6PHngAx8hl5 J8vg== X-Gm-Message-State: AOUpUlGe7pl+ZCJx/vfD1PAWSn1lC49sEh1qbnK/JtINX0QyaDy7fzSV cm9rjYoc7/Y6HDBpzpscMrPrQCCD3eGYSg== X-Google-Smtp-Source: AA+uWPypl3rzaHeNEA6C8YheDF4p9Ddsxt1WXF8pl7DKtHunKGoKGpBPDztsLHgTOenzEx31virT1A== X-Received: by 2002:a1c:c95:: with SMTP id 143-v6mr1749448wmm.50.1533728273285; Wed, 08 Aug 2018 04:37:53 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id p12-v6sm3058483wrw.3.2018.08.08.04.37.52 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 08 Aug 2018 04:37:52 -0700 (PDT) From: Michal Simek To: u-boot@lists.denx.de, Wolfgang Denk , Stefano Babic , Marek Vasut , Simon Glass , Tom Rini Date: Wed, 8 Aug 2018 13:37:29 +0200 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Subject: [U-Boot] [PATCH v2 03/17] cmd: fpga: Move error handling to do_fpga() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Clean fpga_get_op() error handling by moving checking/print to do_fpga. Signed-off-by: Michal Simek Reviewed-by: Simon Glass --- Changes in v2: None Changes in v1: None cmd/fpga.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/fpga.c b/cmd/fpga.c index 791fe5cb7718..abe683720285 100644 --- a/cmd/fpga.c +++ b/cmd/fpga.c @@ -74,6 +74,9 @@ int do_fpga(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) op = (int)fpga_get_op(argv[1]); switch (op) { + case FPGA_NONE: + printf("Unknown fpga operation \"%s\"\n", argv[1]); + return CMD_RET_USAGE; #if defined(CONFIG_CMD_FPGA_LOADFS) case FPGA_LOADFS: if (argc < 9) @@ -360,9 +363,6 @@ static int fpga_get_op(char *opstr) op = FPGA_LOADS; #endif - if (op == FPGA_NONE) - printf("Unknown fpga operation \"%s\"\n", opstr); - return op; }