Message ID | e4859968-f386-adc5-9371-98ed76d41bd9@denx.de |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show |
Series | [U-Boot,PULL] Please pull u-boot-imx | expand |
On Sun, Dec 17, 2017 at 11:39:33AM +0100, Stefano Babic wrote: > Hi Tom, > > please pull from u-boot-imx, thanks ! > > The following changes since commit fcc8250c2f7c982f3593a8eecf737f8e2c95f222: > > Merge git://git.denx.de/u-boot-mips (2017-11-28 16:54:30 -0500) > > are available in the git repository at: > > git://www.denx.de/git/u-boot-imx.git master NAK. [snip] > Peng Fan (2): > power: pmic.h: include dm/ofnode.h > power: pmic/regulator allow dm be omitted by SPL The second patch here breaks rockchip (phycore-rk3288 at least) and does not introduce a 'config SPL_DM_PMIC' symbol that would allow for platforms to enable that still so that it's not dropped when required. If you cannot defer that patch for now (I know there are some critical patches in your PR), please re-work it so we do have SPL_DM_PMIC/etc so that we have no size differences on rockchip (buildman --step 0 -SBCdevelk foo && buildman -SsBdevelk --step 0 foo is how I do that). Thanks!
Hi Tom, On 17/12/2017 20:26, Tom Rini wrote: > On Sun, Dec 17, 2017 at 11:39:33AM +0100, Stefano Babic wrote: >> Hi Tom, >> >> please pull from u-boot-imx, thanks ! >> >> The following changes since commit fcc8250c2f7c982f3593a8eecf737f8e2c95f222: >> >> Merge git://git.denx.de/u-boot-mips (2017-11-28 16:54:30 -0500) >> >> are available in the git repository at: >> >> git://www.denx.de/git/u-boot-imx.git master > > NAK. > > [snip] >> Peng Fan (2): >> power: pmic.h: include dm/ofnode.h >> power: pmic/regulator allow dm be omitted by SPL > > The second patch here breaks rockchip (phycore-rk3288 at least) and does > not introduce a 'config SPL_DM_PMIC' symbol that would allow for > platforms to enable that still so that it's not dropped when required. > If you cannot defer that patch for now This was just a preparation for MX8, discussed with Peng. I have not seen that it breaks rockchip, sorry. It can be dropped for the moment, waiting until Peng will resend a new version fixing the issues. > (I know there are some critical > patches in your PR), please re-work it so we do have SPL_DM_PMIC/etc so > that we have no size differences on rockchip (buildman --step 0 > -SBCdevelk foo && buildman -SsBdevelk --step 0 foo is how I do that). > Thanks! Best regards, Stefano
Adding Peng On Sun, Dec 17, 2017 at 5:26 PM, Tom Rini <trini@konsulko.com> wrote: > On Sun, Dec 17, 2017 at 11:39:33AM +0100, Stefano Babic wrote: >> Hi Tom, >> >> please pull from u-boot-imx, thanks ! >> >> The following changes since commit fcc8250c2f7c982f3593a8eecf737f8e2c95f222: >> >> Merge git://git.denx.de/u-boot-mips (2017-11-28 16:54:30 -0500) >> >> are available in the git repository at: >> >> git://www.denx.de/git/u-boot-imx.git master > > NAK. > > [snip] >> Peng Fan (2): >> power: pmic.h: include dm/ofnode.h >> power: pmic/regulator allow dm be omitted by SPL > > The second patch here breaks rockchip (phycore-rk3288 at least) and does > not introduce a 'config SPL_DM_PMIC' symbol that would allow for > platforms to enable that still so that it's not dropped when required. > If you cannot defer that patch for now (I know there are some critical > patches in your PR), please re-work it so we do have SPL_DM_PMIC/etc so > that we have no size differences on rockchip (buildman --step 0 > -SBCdevelk foo && buildman -SsBdevelk --step 0 foo is how I do that). > Thanks! Peng, please fix this build issue for your v3 series. Thanks
> -----Original Message----- > From: Fabio Estevam [mailto:festevam@gmail.com] > Sent: Monday, December 18, 2017 8:04 AM > To: Tom Rini <trini@konsulko.com>; Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de>; U-Boot Mailing List <u- > boot@lists.denx.de> > Subject: Re: [U-Boot] [PULL] Please pull u-boot-imx > > Adding Peng > > On Sun, Dec 17, 2017 at 5:26 PM, Tom Rini <trini@konsulko.com> wrote: > > On Sun, Dec 17, 2017 at 11:39:33AM +0100, Stefano Babic wrote: > >> Hi Tom, > >> > >> please pull from u-boot-imx, thanks ! > >> > >> The following changes since commit > fcc8250c2f7c982f3593a8eecf737f8e2c95f222: > >> > >> Merge git://git.denx.de/u-boot-mips (2017-11-28 16:54:30 -0500) > >> > >> are available in the git repository at: > >> > >> git://www.denx.de/git/u-boot-imx.git master > > > > NAK. > > > > [snip] > >> Peng Fan (2): > >> power: pmic.h: include dm/ofnode.h > >> power: pmic/regulator allow dm be omitted by SPL > > > > The second patch here breaks rockchip (phycore-rk3288 at least) and > > does not introduce a 'config SPL_DM_PMIC' symbol that would allow for > > platforms to enable that still so that it's not dropped when required. > > If you cannot defer that patch for now (I know there are some critical > > patches in your PR), please re-work it so we do have SPL_DM_PMIC/etc > > so that we have no size differences on rockchip (buildman --step 0 > > -SBCdevelk foo && buildman -SsBdevelk --step 0 foo is how I do that). > > Thanks! Share on me. Please drop the second patch. > > Peng, please fix this build issue for your v3 series. I'll fix it in my second patch. Thanks, Peng. > > Thanks