| Message ID | dcdb20e7252ea7465e9f984d815e9624c30e9558.1645624969.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | 4173a42685e1e3c6793517b03ddabacc3774f7da |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | dm: pinctrl: Use explicit values for enums | expand |
On Wed, 23 Feb 2022 at 07:02, Michal Simek <michal.simek@xilinx.com> wrote: > > From: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com> > > Based on discussion at > https://lore.kernel.org/r/20200318125003.GA2727094@kroah.com we got > recommendation to use explicit values for all enums. > > So, add explicit values to all pinctrl related enums for readability. > > Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > include/dm/pinctrl.h | 48 ++++++++++++++++++++++---------------------- > 1 file changed, 24 insertions(+), 24 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
st 23. 2. 2022 v 15:02 odesÃlatel Michal Simek <michal.simek@xilinx.com> napsal: > > From: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com> > > Based on discussion at > https://lore.kernel.org/r/20200318125003.GA2727094@kroah.com we got > recommendation to use explicit values for all enums. > > So, add explicit values to all pinctrl related enums for readability. > > Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > include/dm/pinctrl.h | 48 ++++++++++++++++++++++---------------------- > 1 file changed, 24 insertions(+), 24 deletions(-) > > diff --git a/include/dm/pinctrl.h b/include/dm/pinctrl.h > index 8b869c4fbfb7..0c461e56bb48 100644 > --- a/include/dm/pinctrl.h > +++ b/include/dm/pinctrl.h > @@ -453,30 +453,30 @@ struct pinctrl_ops { > * presented using the packed format. > */ > enum pin_config_param { > - PIN_CONFIG_BIAS_BUS_HOLD, > - PIN_CONFIG_BIAS_DISABLE, > - PIN_CONFIG_BIAS_HIGH_IMPEDANCE, > - PIN_CONFIG_BIAS_PULL_DOWN, > - PIN_CONFIG_BIAS_PULL_PIN_DEFAULT, > - PIN_CONFIG_BIAS_PULL_UP, > - PIN_CONFIG_DRIVE_OPEN_DRAIN, > - PIN_CONFIG_DRIVE_OPEN_SOURCE, > - PIN_CONFIG_DRIVE_PUSH_PULL, > - PIN_CONFIG_DRIVE_STRENGTH, > - PIN_CONFIG_DRIVE_STRENGTH_UA, > - PIN_CONFIG_INPUT_DEBOUNCE, > - PIN_CONFIG_INPUT_ENABLE, > - PIN_CONFIG_INPUT_SCHMITT, > - PIN_CONFIG_INPUT_SCHMITT_ENABLE, > - PIN_CONFIG_LOW_POWER_MODE, > - PIN_CONFIG_OUTPUT_ENABLE, > - PIN_CONFIG_OUTPUT, > - PIN_CONFIG_POWER_SOURCE, > - PIN_CONFIG_SLEEP_HARDWARE_STATE, > - PIN_CONFIG_SLEW_RATE, > - PIN_CONFIG_SKEW_DELAY, > - PIN_CONFIG_END = 0x7F, > - PIN_CONFIG_MAX = 0xFF, > + PIN_CONFIG_BIAS_BUS_HOLD = 0, > + PIN_CONFIG_BIAS_DISABLE = 1, > + PIN_CONFIG_BIAS_HIGH_IMPEDANCE = 2, > + PIN_CONFIG_BIAS_PULL_DOWN = 3, > + PIN_CONFIG_BIAS_PULL_PIN_DEFAULT = 4, > + PIN_CONFIG_BIAS_PULL_UP = 5, > + PIN_CONFIG_DRIVE_OPEN_DRAIN = 6, > + PIN_CONFIG_DRIVE_OPEN_SOURCE = 7, > + PIN_CONFIG_DRIVE_PUSH_PULL = 8, > + PIN_CONFIG_DRIVE_STRENGTH = 9, > + PIN_CONFIG_DRIVE_STRENGTH_UA = 10, > + PIN_CONFIG_INPUT_DEBOUNCE = 11, > + PIN_CONFIG_INPUT_ENABLE = 12, > + PIN_CONFIG_INPUT_SCHMITT = 13, > + PIN_CONFIG_INPUT_SCHMITT_ENABLE = 14, > + PIN_CONFIG_LOW_POWER_MODE = 15, > + PIN_CONFIG_OUTPUT_ENABLE = 16, > + PIN_CONFIG_OUTPUT = 17, > + PIN_CONFIG_POWER_SOURCE = 18, > + PIN_CONFIG_SLEEP_HARDWARE_STATE = 19, > + PIN_CONFIG_SLEW_RATE = 20, > + PIN_CONFIG_SKEW_DELAY = 21, > + PIN_CONFIG_END = 127, /* 0x7F */ > + PIN_CONFIG_MAX = 255, /* 0xFF */ > }; > > #if CONFIG_IS_ENABLED(PINCTRL_GENERIC) > -- > 2.35.1 > Applied. M
diff --git a/include/dm/pinctrl.h b/include/dm/pinctrl.h index 8b869c4fbfb7..0c461e56bb48 100644 --- a/include/dm/pinctrl.h +++ b/include/dm/pinctrl.h @@ -453,30 +453,30 @@ struct pinctrl_ops { * presented using the packed format. */ enum pin_config_param { - PIN_CONFIG_BIAS_BUS_HOLD, - PIN_CONFIG_BIAS_DISABLE, - PIN_CONFIG_BIAS_HIGH_IMPEDANCE, - PIN_CONFIG_BIAS_PULL_DOWN, - PIN_CONFIG_BIAS_PULL_PIN_DEFAULT, - PIN_CONFIG_BIAS_PULL_UP, - PIN_CONFIG_DRIVE_OPEN_DRAIN, - PIN_CONFIG_DRIVE_OPEN_SOURCE, - PIN_CONFIG_DRIVE_PUSH_PULL, - PIN_CONFIG_DRIVE_STRENGTH, - PIN_CONFIG_DRIVE_STRENGTH_UA, - PIN_CONFIG_INPUT_DEBOUNCE, - PIN_CONFIG_INPUT_ENABLE, - PIN_CONFIG_INPUT_SCHMITT, - PIN_CONFIG_INPUT_SCHMITT_ENABLE, - PIN_CONFIG_LOW_POWER_MODE, - PIN_CONFIG_OUTPUT_ENABLE, - PIN_CONFIG_OUTPUT, - PIN_CONFIG_POWER_SOURCE, - PIN_CONFIG_SLEEP_HARDWARE_STATE, - PIN_CONFIG_SLEW_RATE, - PIN_CONFIG_SKEW_DELAY, - PIN_CONFIG_END = 0x7F, - PIN_CONFIG_MAX = 0xFF, + PIN_CONFIG_BIAS_BUS_HOLD = 0, + PIN_CONFIG_BIAS_DISABLE = 1, + PIN_CONFIG_BIAS_HIGH_IMPEDANCE = 2, + PIN_CONFIG_BIAS_PULL_DOWN = 3, + PIN_CONFIG_BIAS_PULL_PIN_DEFAULT = 4, + PIN_CONFIG_BIAS_PULL_UP = 5, + PIN_CONFIG_DRIVE_OPEN_DRAIN = 6, + PIN_CONFIG_DRIVE_OPEN_SOURCE = 7, + PIN_CONFIG_DRIVE_PUSH_PULL = 8, + PIN_CONFIG_DRIVE_STRENGTH = 9, + PIN_CONFIG_DRIVE_STRENGTH_UA = 10, + PIN_CONFIG_INPUT_DEBOUNCE = 11, + PIN_CONFIG_INPUT_ENABLE = 12, + PIN_CONFIG_INPUT_SCHMITT = 13, + PIN_CONFIG_INPUT_SCHMITT_ENABLE = 14, + PIN_CONFIG_LOW_POWER_MODE = 15, + PIN_CONFIG_OUTPUT_ENABLE = 16, + PIN_CONFIG_OUTPUT = 17, + PIN_CONFIG_POWER_SOURCE = 18, + PIN_CONFIG_SLEEP_HARDWARE_STATE = 19, + PIN_CONFIG_SLEW_RATE = 20, + PIN_CONFIG_SKEW_DELAY = 21, + PIN_CONFIG_END = 127, /* 0x7F */ + PIN_CONFIG_MAX = 255, /* 0xFF */ }; #if CONFIG_IS_ENABLED(PINCTRL_GENERIC)