diff mbox series

[2/3] iot2050: Use binman in signing script

Message ID c1164081c7bbbed55cc93c647b9f01f8da4066af.1685975993.git.jan.kiszka@siemens.com
State Changes Requested
Delegated to: Simon Glass
Headers show
Series iot2050: Re-unify its configs and build processes | expand

Commit Message

Jan Kiszka June 5, 2023, 2:39 p.m. UTC 
From: Jan Kiszka <jan.kiszka@siemens.com>

The underlying issue was fixed in the meantime. Switching to fully
binman-based signing (script-free) remains a todo, though.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
CC: Simon Glass <sjg@chromium.org>
---
 tools/iot2050-sign-fw.sh | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

Simon Glass June 12, 2023, 9:17 p.m. UTC | #1 
On Mon, 5 Jun 2023 at 15:39, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The underlying issue was fixed in the meantime. Switching to fully
> binman-based signing (script-free) remains a todo, though.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> CC: Simon Glass <sjg@chromium.org>
> ---
>  tools/iot2050-sign-fw.sh | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/tools/iot2050-sign-fw.sh b/tools/iot2050-sign-fw.sh
index 4d1d79498c2..da425c94a5d 100755
--- a/tools/iot2050-sign-fw.sh
+++ b/tools/iot2050-sign-fw.sh
@@ -39,13 +39,9 @@  CERT_X509=$(mktemp XXXXXXXX.crt)
 
 openssl req -new -x509 -key $1 -nodes -outform DER -out $CERT_X509 -config $TEMP_X509 -sha512
 cat $CERT_X509 tispl.bin > tispl.bin_signed
-# currently broken in upstream
-#source/tools/binman/binman replace -i flash.bin -f tispl.bin_signed blob@0x180000
-dd if=tispl.bin_signed of=flash.bin bs=$((0x1000)) seek=$((0x180000/0x1000)) conv=notrunc
+source/tools/binman/binman replace -i flash.bin -f tispl.bin_signed blob@0x180000
 
 rm $TEMP_X509 $CERT_X509
 
 tools/mkimage -G $1 -r -o sha256,rsa4096 -F fit@0x380000.fit
-# currently broken in upstream
-#source/tools/binman/binman replace -i flash.bin -f fit@0x380000.fit fit@0x380000
-dd if=fit@0x380000.fit of=flash.bin bs=$((0x1000)) seek=$((0x380000/0x1000)) conv=notrunc
+source/tools/binman/binman replace -i flash.bin -f fit@0x380000.fit fit@0x380000