diff mbox series

cpu: 83xx: Add missing dependency on CPU_MPC83XX

Message ID bcd45e66adde11152339fc905eb7ba23b300d930.1650634339.git.michal.simek@xilinx.com
State Accepted
Commit 182d45ddff8944e291c805d94a01d7dd29d0d3b6
Delegated to: Priyanka Jain
Headers show
Series cpu: 83xx: Add missing dependency on CPU_MPC83XX | expand

Commit Message

Michal Simek April 22, 2022, 1:32 p.m. UTC
It looks quite weird that for non PPC platforms cpu driver for MPC83xx can
be selected. That's why define proper dependency.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/cpu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini April 22, 2022, 4:51 p.m. UTC | #1
On Fri, Apr 22, 2022 at 03:32:21PM +0200, Michal Simek wrote:

> It looks quite weird that for non PPC platforms cpu driver for MPC83xx can
> be selected. That's why define proper dependency.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Long term, we need the "or compile testing only" option like Linux has,
for doing static analysis checks via sandbox.  But given what we have /
do today, this makes the most sense.

Reviewed-by: Tom Rini <trini@konsulko.com>
diff mbox series

Patch

diff --git a/drivers/cpu/Kconfig b/drivers/cpu/Kconfig
index 3d5729f6dca8..789728167ceb 100644
--- a/drivers/cpu/Kconfig
+++ b/drivers/cpu/Kconfig
@@ -9,7 +9,7 @@  config CPU
 
 config CPU_MPC83XX
 	bool "Enable MPC83xx CPU driver"
-	depends on CPU
+	depends on CPU && MPC83xx
 	select CLK_MPC83XX
 	help
 	  Support CPU cores for SoCs of the MPC83xx series.