From patchwork Mon Sep 9 16:27:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Robert P. J. Day" X-Patchwork-Id: 273616 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 44F4F2C009E for ; Tue, 10 Sep 2013 02:28:02 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D73344A07A; Mon, 9 Sep 2013 18:27:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RpQlJraQhahS; Mon, 9 Sep 2013 18:27:58 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 535E14A063; Mon, 9 Sep 2013 18:27:54 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A364C4A063 for ; Mon, 9 Sep 2013 18:27:48 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bzGS+8lrR-yD for ; Mon, 9 Sep 2013 18:27:41 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from astoria.ccjclearline.com (astoria.ccjclearline.com [64.235.106.9]) by theia.denx.de (Postfix) with ESMTPS id 637674A060 for ; Mon, 9 Sep 2013 18:27:34 +0200 (CEST) Received: from [69.196.158.250] (port=51620 helo=crashcourse.ca) by astoria.ccjclearline.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.80) (envelope-from ) id 1VJ4JE-0006jS-S4; Mon, 09 Sep 2013 12:27:29 -0400 Date: Mon, 9 Sep 2013 12:27:25 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@oneiric To: U-Boot list Message-ID: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - astoria.ccjclearline.com X-AntiAbuse: Original Domain - lists.denx.de X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - crashcourse.ca X-Source: X-Source-Args: X-Source-Dir: Cc: trini@ti.com Subject: [U-Boot] [PATCH] am335x_evm.h: If mmcdev and bootpart switch to mmcdev 1, so should mmcroot. X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de If, in CONFIG_BOOTCOMMAND, the environment switches both the mmcdev and bootpart variables to refer to MMC device 1, it would make sense that the mmcroot env variable should switch to that device as well. Signed-off-by: Robert P. J. Day --- i asked about this a while back and didn't hear any objections, so i'll submit it as a patch. as you can see, if the first attempt to run mmcboot fails, the environment is switched to refer to MMC device 1 (eMMC), and it would seem natural that mmcroot should follow along for consistency. but i'm willing to be convinced otherwise. diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h index 3de30fc..56a60da 100644 --- a/include/configs/am335x_evm.h +++ b/include/configs/am335x_evm.h @@ -170,6 +170,7 @@ "run mmcboot;" \ "setenv mmcdev 1; " \ "setenv bootpart 1:2; " \ + "setenv mmcroot /dev/mmcblk1p2 ro; " \ "run mmcboot;" \ "run nandboot;"