diff mbox series

[v1,1/2] rockchip: timer: rockchip_timer: fix compatible and driver name

Message ID a6e563a2-6bf0-c330-ac75-c976d6b85c83@gmail.com
State Accepted
Commit 791c7ac79274e2c3aa316da90fb3cc2411d5c5e8
Delegated to: Kever Yang
Headers show
Series [v1,1/2] rockchip: timer: rockchip_timer: fix compatible and driver name | expand

Commit Message

Johan Jonker March 7, 2023, 3:30 p.m. UTC
In the binding for the Rockchip timer the compatible string
consists of a SoC orientated string and a fall back string
"rockchip,rk3288-timer", so remove all unneeded ones and
fix driver name.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 drivers/timer/rockchip_timer.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

--
2.20.1

Comments

Kever Yang March 8, 2023, 12:22 a.m. UTC | #1
On 2023/3/7 23:30, Johan Jonker wrote:
> In the binding for the Rockchip timer the compatible string
> consists of a SoC orientated string and a fall back string
> "rockchip,rk3288-timer", so remove all unneeded ones and
> fix driver name.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>


Thanks,
- Kever
> ---
>   drivers/timer/rockchip_timer.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/timer/rockchip_timer.c b/drivers/timer/rockchip_timer.c
> index 62eacb98..e66c49aa 100644
> --- a/drivers/timer/rockchip_timer.c
> +++ b/drivers/timer/rockchip_timer.c
> @@ -20,7 +20,7 @@ DECLARE_GLOBAL_DATA_PTR;
>
>   #if CONFIG_IS_ENABLED(OF_PLATDATA)
>   struct rockchip_timer_plat {
> -	struct dtd_rockchip_rk3368_timer dtd;
> +	struct dtd_rockchip_rk3288_timer dtd;
>   };
>   #endif
>
> @@ -152,14 +152,12 @@ static const struct timer_ops rockchip_timer_ops = {
>   };
>
>   static const struct udevice_id rockchip_timer_ids[] = {
> -	{ .compatible = "rockchip,rk3188-timer" },
>   	{ .compatible = "rockchip,rk3288-timer" },
> -	{ .compatible = "rockchip,rk3368-timer" },
>   	{}
>   };
>
> -U_BOOT_DRIVER(rockchip_rk3368_timer) = {
> -	.name	= "rockchip_rk3368_timer",
> +U_BOOT_DRIVER(rockchip_rk3288_timer) = {
> +	.name	= "rockchip_rk3288_timer",
>   	.id	= UCLASS_TIMER,
>   	.of_match = rockchip_timer_ids,
>   	.probe = rockchip_timer_probe,
> --
> 2.20.1
>
diff mbox series

Patch

diff --git a/drivers/timer/rockchip_timer.c b/drivers/timer/rockchip_timer.c
index 62eacb98..e66c49aa 100644
--- a/drivers/timer/rockchip_timer.c
+++ b/drivers/timer/rockchip_timer.c
@@ -20,7 +20,7 @@  DECLARE_GLOBAL_DATA_PTR;

 #if CONFIG_IS_ENABLED(OF_PLATDATA)
 struct rockchip_timer_plat {
-	struct dtd_rockchip_rk3368_timer dtd;
+	struct dtd_rockchip_rk3288_timer dtd;
 };
 #endif

@@ -152,14 +152,12 @@  static const struct timer_ops rockchip_timer_ops = {
 };

 static const struct udevice_id rockchip_timer_ids[] = {
-	{ .compatible = "rockchip,rk3188-timer" },
 	{ .compatible = "rockchip,rk3288-timer" },
-	{ .compatible = "rockchip,rk3368-timer" },
 	{}
 };

-U_BOOT_DRIVER(rockchip_rk3368_timer) = {
-	.name	= "rockchip_rk3368_timer",
+U_BOOT_DRIVER(rockchip_rk3288_timer) = {
+	.name	= "rockchip_rk3288_timer",
 	.id	= UCLASS_TIMER,
 	.of_match = rockchip_timer_ids,
 	.probe = rockchip_timer_probe,