| Message ID | a2c2aad0-ce9e-8eed-719f-3be82a0a24db@denx.de |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,PULL] Please pull u-boot-imx | expand |
On Mon, Jan 15, 2018 at 06:52:01PM +0100, Stefano Babic wrote: > Hi Tom, > > please pull from u-boot-imx, thanks ! > > The following changes since commit 373b9003410b44a1133060c2e63483b278fb476b: > > Merge git://git.denx.de/u-boot-sunxi (2018-01-11 14:14:19 -0500) > > are available in the git repository at: > > git://www.denx.de/git/u-boot-imx.git master > > for you to fetch changes up to 9587b0d61133c025d48ebf480aa021fc2fdd53a7: > > arm: imx: hab: Add hab_failsafe console command (2018-01-14 17:26:30 > +0100) > Applied to u-boot/master, thanks! But please note that checkpatch has a lot to say, some of which should probably be addressed: WARNING: please write a paragraph that describes the config symbol fully #51: FILE: arch/arm/mach-imx/mx6/Kconfig:380: +config TARGET_SKSIMX6 WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #67: new file mode 100644 WARNING: line over 80 characters #171: FILE: board/sks-kinkel/sksimx6/sksimx6.c:62: + IOMUX_PADS(PAD_NANDF_D0__GPIO2_IO00 | MUX_PAD_CTRL(NO_PAD_CTRL)),/* CD */ CHECK: Blank lines aren't necessary after an open brace '{' #215: FILE: board/sks-kinkel/sksimx6/sksimx6.c:106: +{ + CHECK: Blank lines aren't necessary before a close brace '}' #245: FILE: board/sks-kinkel/sksimx6/sksimx6.c:136: + +} CHECK: Prefer kernel type 'u32' over 'uint32_t' #249: FILE: board/sks-kinkel/sksimx6/sksimx6.c:140: + uint32_t base = IMX_FEC_BASE; CHECK: Alignment should match open parenthesis #261: FILE: board/sks-kinkel/sksimx6/sksimx6.c:152: + phydev = phy_find_by_mask(bus, (0xf << CONFIG_FEC_MXC_PHYADDR), + PHY_INTERFACE_MODE_RGMII); WARNING: unnecessary whitespace before a quoted newline #333: FILE: board/sks-kinkel/sksimx6/sksimx6.c:224: + printf("Warning: failed to initialize mmc dev \n"); CHECK: Please don't use multiple blank lines #350: FILE: board/sks-kinkel/sksimx6/sksimx6.c:241: + + WARNING: line over 80 characters #471: FILE: board/sks-kinkel/sksimx6/sksimx6.c:362: + mx6_dram_cfg(&mem_qdl, &mx6dl_1g_mmdc_calib, &mt41k128m16jt_125); CHECK: Please don't use multiple blank lines #601: FILE: include/configs/sksimx6.h:7: + + WARNING: please, no space before tabs #670: FILE: include/configs/sksimx6.h:76: +^I"addmisc=setenv bootargs ${bootargs} ${miscargs}\0" ^I^I\$ WARNING: please, no space before tabs #675: FILE: include/configs/sksimx6.h:81: +^I"fdt_addr_r=0x18000000\0" ^I^I^I^I^I\$ WARNING: please, no space before tabs #677: FILE: include/configs/sksimx6.h:83: +^I"fdt_high=0xffffffff\0" ^I^I^I^I^I\$ WARNING: please, no space before tabs #678: FILE: include/configs/sksimx6.h:84: +^I"kernel_addr_r=" __stringify(CONFIG_LOADADDR) "\0" ^I^I\$ WARNING: please, no space before tabs #681: FILE: include/configs/sksimx6.h:87: +^I"mmcboot=if run mmcload;then " ^I^I^I^I^I\$ WARNING: please, no space before tabs #683: FILE: include/configs/sksimx6.h:89: +^I^I^I"bootm;fi\0" ^I^I^I^I^I\$ total: 0 errors, 11 warnings, 6 checks, 611 lines checked WARNING: line over 80 characters #38: FILE: drivers/misc/mxc_ocotp.c:356: + printf("mxc_ocotp: The word has been programmed, no more write\n"); total: 0 errors, 1 warnings, 0 checks, 23 lines checked WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 WARNING: line over 80 characters #549: FILE: arch/arm/dts/imx6sx-sdb.dtsi:367: + MX6SX_PAD_ENET2_RX_CLK__ENET2_REF_CLK_25M 0x91 WARNING: line over 80 characters #555: FILE: arch/arm/dts/imx6sx-sdb.dtsi:373: + MX6SX_PAD_ENET2_COL__GPIO2_IO_6 0x80000000 WARNING: line over 80 characters #585: FILE: arch/arm/dts/imx6sx-sdb.dtsi:403: + MX6SX_PAD_GPIO1_IO01__I2C1_SDA 0x4001b8b1 WARNING: line over 80 characters #586: FILE: arch/arm/dts/imx6sx-sdb.dtsi:404: + MX6SX_PAD_GPIO1_IO00__I2C1_SCL 0x4001b8b1 WARNING: line over 80 characters #592: FILE: arch/arm/dts/imx6sx-sdb.dtsi:410: + MX6SX_PAD_KEY_ROW4__I2C3_SDA 0x4001b8b1 WARNING: line over 80 characters #593: FILE: arch/arm/dts/imx6sx-sdb.dtsi:411: + MX6SX_PAD_KEY_COL4__I2C3_SCL 0x4001b8b1 WARNING: line over 80 characters #599: FILE: arch/arm/dts/imx6sx-sdb.dtsi:417: + MX6SX_PAD_CSI_DATA07__I2C4_SDA 0x4001b8b1 WARNING: line over 80 characters #600: FILE: arch/arm/dts/imx6sx-sdb.dtsi:418: + MX6SX_PAD_CSI_DATA06__I2C4_SCL 0x4001b8b1 WARNING: line over 80 characters #640: FILE: arch/arm/dts/imx6sx-sdb.dtsi:458: + MX6SX_PAD_QSPI1A_DATA0__GPIO4_IO_16 0x80000000 WARNING: line over 80 characters #740: FILE: arch/arm/dts/imx6sx-sdb.dtsi:558: + MX6SX_PAD_KEY_COL0__GPIO2_IO_10 0x17059 /* CD */ WARNING: line over 80 characters #741: FILE: arch/arm/dts/imx6sx-sdb.dtsi:559: + MX6SX_PAD_KEY_ROW0__GPIO2_IO_15 0x17059 /* WP */ WARNING: line over 80 characters #783: FILE: arch/arm/dts/imx6sx-sdb.dtsi:601: + MX6SX_PAD_SD4_DATA7__GPIO6_IO_21 0x17059 /* CD */ WARNING: line over 80 characters #784: FILE: arch/arm/dts/imx6sx-sdb.dtsi:602: + MX6SX_PAD_SD4_DATA6__GPIO6_IO_20 0x17059 /* WP */ total: 0 errors, 14 warnings, 0 checks, 757 lines checked WARNING: 'framwork' may be misspelled - perhaps 'framework'? #7: framwork now and wdog reset will be triggered once set WDOG_B mux WARNING: 'framwork' may be misspelled - perhaps 'framework'? #49: FILE: board/freescale/mx6sxsabresd/mx6sxsabresd.c:306: + * framwork now and wdog reset will be triggered once set WDOG_B mux total: 0 errors, 2 warnings, 0 checks, 33 lines checked WARNING: line over 80 characters #95: FILE: arch/arm/mach-imx/mx5/clock.c:918: +static int do_mx5_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) total: 0 errors, 1 warnings, 0 checks, 85 lines checked CHECK: Alignment should match open parenthesis #60: FILE: board/toradex/apalis_imx6/pf0100.c:214: +static int do_pf0100_prog(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) CHECK: Alignment should match open parenthesis #109: FILE: board/toradex/colibri_imx6/pf0100.c:196: +static int do_pf0100_prog(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) total: 0 errors, 0 warnings, 2 checks, 79 lines checked WARNING: line over 80 characters #56: FILE: include/configs/cm_fx6.h:158: + "if test $board_name = Utilite && test $board_rev = MX6Q ; then " \ total: 0 errors, 1 warnings, 0 checks, 26 lines checked CHECK: Prefer kernel type 'u32' over 'uint32_t' #45: FILE: arch/arm/include/asm/mach-imx/hab.h:148: +int authenticate_image(uint32_t ddr_start, uint32_t image_size); CHECK: Prefer kernel type 'u32' over 'uint32_t' #57: FILE: arch/arm/mach-imx/hab.c:413: +int authenticate_image(uint32_t ddr_start, uint32_t image_size) total: 0 errors, 0 warnings, 2 checks, 15 lines checked WARNING: Prefer using '"%s...", __func__' to using 'authenticate_image', this function's name, in a string #95: FILE: arch/arm/mach-imx/hab.c:465: + puts("\nCalling authenticate_image in ROM\n"); total: 0 errors, 1 warnings, 0 checks, 160 lines checked WARNING: Prefer using '"%s...", __func__' to using 'authenticate_image', this function's name, in a string #85: FILE: arch/arm/mach-imx/hab.c:469: + puts("\nCalling authenticate_image in ROM\n"); total: 0 errors, 1 warnings, 0 checks, 135 lines checked CHECK: Prefer kernel type 'u32' over 'uint32_t' #67: FILE: arch/arm/include/asm/mach-imx/hab.h:151: +int authenticate_image(uint32_t ddr_start, uint32_t image_size, CHECK: Prefer kernel type 'u32' over 'uint32_t' #159: FILE: arch/arm/mach-imx/hab.c:386: +int authenticate_image(uint32_t ddr_start, uint32_t image_size, CHECK: Prefer kernel type 'u32' over 'uint32_t' #165: FILE: arch/arm/mach-imx/hab.c:391: + uint32_t ivt_addr = 0; CHECK: Prefer kernel type 'u32' over 'uint32_t' #252: FILE: arch/arm/mach-imx/spl.c:192: + uint32_t offset; total: 0 errors, 0 warnings, 4 checks, 188 lines checked CHECK: Prefer kernel type 'u8' over 'uint8_t' #49: FILE: arch/arm/include/asm/mach-imx/hab.h:25: + uint8_t magic; CHECK: Prefer kernel type 'u16' over 'uint16_t' #50: FILE: arch/arm/include/asm/mach-imx/hab.h:26: + uint16_t length; CHECK: Prefer kernel type 'u8' over 'uint8_t' #51: FILE: arch/arm/include/asm/mach-imx/hab.h:27: + uint8_t version; WARNING: __packed is preferred over __attribute__((packed)) #52: FILE: arch/arm/include/asm/mach-imx/hab.h:28: +} __attribute__((packed)); WARNING: Adding new packed members is to be done with care #52: FILE: arch/arm/include/asm/mach-imx/hab.h:28: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #56: FILE: arch/arm/include/asm/mach-imx/hab.h:32: + uint32_t entry; /* Absolute address of first instruction */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #57: FILE: arch/arm/include/asm/mach-imx/hab.h:33: + uint32_t reserved1; /* Reserved should be zero */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #58: FILE: arch/arm/include/asm/mach-imx/hab.h:34: + uint32_t dcd; /* Absolute address of the image DCD */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #59: FILE: arch/arm/include/asm/mach-imx/hab.h:35: + uint32_t boot; /* Absolute address of the boot data */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #60: FILE: arch/arm/include/asm/mach-imx/hab.h:36: + uint32_t self; /* Absolute address of the IVT */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #61: FILE: arch/arm/include/asm/mach-imx/hab.h:37: + uint32_t csf; /* Absolute address of the CSF */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #62: FILE: arch/arm/include/asm/mach-imx/hab.h:38: + uint32_t reserved2; /* Reserved should be zero */ total: 0 errors, 2 warnings, 10 checks, 34 lines checked CHECK: Prefer kernel type 'u8' over 'uint8_t' #172: FILE: arch/arm/mach-imx/hab.c:212: +static uint8_t hab_statuses[5] = { CHECK: Prefer kernel type 'u8' over 'uint8_t' #181: FILE: arch/arm/mach-imx/hab.c:220: +static uint8_t hab_reasons[26] = { CHECK: Prefer kernel type 'u8' over 'uint8_t' #190: FILE: arch/arm/mach-imx/hab.c:249: +static uint8_t hab_contexts[12] = { CHECK: Prefer kernel type 'u8' over 'uint8_t' #199: FILE: arch/arm/mach-imx/hab.c:264: +static uint8_t hab_engines[16] = { CHECK: Prefer kernel type 'u8' over 'uint8_t' #208: FILE: arch/arm/mach-imx/hab.c:295: +static void process_event_record(uint8_t *event_data, size_t bytes) CHECK: Prefer kernel type 'u8' over 'uint8_t' #217: FILE: arch/arm/mach-imx/hab.c:305: +static void display_event(uint8_t *event_data, size_t bytes) total: 0 errors, 0 warnings, 6 checks, 213 lines checked CHECK: Prefer kernel type 'u32' over 'uint32_t' #38: FILE: arch/arm/include/asm/mach-imx/hab.h:188: +int imx_hab_authenticate_image(uint32_t ddr_start, uint32_t image_size, CHECK: Prefer kernel type 'u32' over 'uint32_t' #61: FILE: arch/arm/mach-imx/hab.c:438: +int imx_hab_authenticate_image(uint32_t ddr_start, uint32_t image_size, total: 0 errors, 0 warnings, 2 checks, 38 lines checked
Hi Tom, On 16/01/2018 01:00, Tom Rini wrote: > On Mon, Jan 15, 2018 at 06:52:01PM +0100, Stefano Babic wrote: > >> Hi Tom, >> >> please pull from u-boot-imx, thanks ! >> >> The following changes since commit 373b9003410b44a1133060c2e63483b278fb476b: >> >> Merge git://git.denx.de/u-boot-sunxi (2018-01-11 14:14:19 -0500) >> >> are available in the git repository at: >> >> git://www.denx.de/git/u-boot-imx.git master >> >> for you to fetch changes up to 9587b0d61133c025d48ebf480aa021fc2fdd53a7: >> >> arm: imx: hab: Add hab_failsafe console command (2018-01-14 17:26:30 >> +0100) >> > > Applied to u-boot/master, thanks! > > But please note that checkpatch has a lot to say, some of which should > probably be addressed: > Ouch..... I will check it :-) Regards, Stefano > WARNING: please write a paragraph that describes the config symbol fully > #51: FILE: arch/arm/mach-imx/mx6/Kconfig:380: > +config TARGET_SKSIMX6 > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #67: > new file mode 100644 > > WARNING: line over 80 characters > #171: FILE: board/sks-kinkel/sksimx6/sksimx6.c:62: > + IOMUX_PADS(PAD_NANDF_D0__GPIO2_IO00 | MUX_PAD_CTRL(NO_PAD_CTRL)),/* CD */ > > CHECK: Blank lines aren't necessary after an open brace '{' > #215: FILE: board/sks-kinkel/sksimx6/sksimx6.c:106: > +{ > + > > CHECK: Blank lines aren't necessary before a close brace '}' > #245: FILE: board/sks-kinkel/sksimx6/sksimx6.c:136: > + > +} > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #249: FILE: board/sks-kinkel/sksimx6/sksimx6.c:140: > + uint32_t base = IMX_FEC_BASE; > > CHECK: Alignment should match open parenthesis > #261: FILE: board/sks-kinkel/sksimx6/sksimx6.c:152: > + phydev = phy_find_by_mask(bus, (0xf << CONFIG_FEC_MXC_PHYADDR), > + PHY_INTERFACE_MODE_RGMII); > > WARNING: unnecessary whitespace before a quoted newline > #333: FILE: board/sks-kinkel/sksimx6/sksimx6.c:224: > + printf("Warning: failed to initialize mmc dev \n"); > > CHECK: Please don't use multiple blank lines > #350: FILE: board/sks-kinkel/sksimx6/sksimx6.c:241: > + > + > > WARNING: line over 80 characters > #471: FILE: board/sks-kinkel/sksimx6/sksimx6.c:362: > + mx6_dram_cfg(&mem_qdl, &mx6dl_1g_mmdc_calib, &mt41k128m16jt_125); > > CHECK: Please don't use multiple blank lines > #601: FILE: include/configs/sksimx6.h:7: > + > + > > WARNING: please, no space before tabs > #670: FILE: include/configs/sksimx6.h:76: > +^I"addmisc=setenv bootargs ${bootargs} ${miscargs}\0" ^I^I\$ > > WARNING: please, no space before tabs > #675: FILE: include/configs/sksimx6.h:81: > +^I"fdt_addr_r=0x18000000\0" ^I^I^I^I^I\$ > > WARNING: please, no space before tabs > #677: FILE: include/configs/sksimx6.h:83: > +^I"fdt_high=0xffffffff\0" ^I^I^I^I^I\$ > > WARNING: please, no space before tabs > #678: FILE: include/configs/sksimx6.h:84: > +^I"kernel_addr_r=" __stringify(CONFIG_LOADADDR) "\0" ^I^I\$ > > WARNING: please, no space before tabs > #681: FILE: include/configs/sksimx6.h:87: > +^I"mmcboot=if run mmcload;then " ^I^I^I^I^I\$ > > WARNING: please, no space before tabs > #683: FILE: include/configs/sksimx6.h:89: > +^I^I^I"bootm;fi\0" ^I^I^I^I^I\$ > > total: 0 errors, 11 warnings, 6 checks, 611 lines checked > WARNING: line over 80 characters > #38: FILE: drivers/misc/mxc_ocotp.c:356: > + printf("mxc_ocotp: The word has been programmed, no more write\n"); > > total: 0 errors, 1 warnings, 0 checks, 23 lines checked > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #34: > new file mode 100644 > > WARNING: line over 80 characters > #549: FILE: arch/arm/dts/imx6sx-sdb.dtsi:367: > + MX6SX_PAD_ENET2_RX_CLK__ENET2_REF_CLK_25M 0x91 > > WARNING: line over 80 characters > #555: FILE: arch/arm/dts/imx6sx-sdb.dtsi:373: > + MX6SX_PAD_ENET2_COL__GPIO2_IO_6 0x80000000 > > WARNING: line over 80 characters > #585: FILE: arch/arm/dts/imx6sx-sdb.dtsi:403: > + MX6SX_PAD_GPIO1_IO01__I2C1_SDA 0x4001b8b1 > > WARNING: line over 80 characters > #586: FILE: arch/arm/dts/imx6sx-sdb.dtsi:404: > + MX6SX_PAD_GPIO1_IO00__I2C1_SCL 0x4001b8b1 > > WARNING: line over 80 characters > #592: FILE: arch/arm/dts/imx6sx-sdb.dtsi:410: > + MX6SX_PAD_KEY_ROW4__I2C3_SDA 0x4001b8b1 > > WARNING: line over 80 characters > #593: FILE: arch/arm/dts/imx6sx-sdb.dtsi:411: > + MX6SX_PAD_KEY_COL4__I2C3_SCL 0x4001b8b1 > > WARNING: line over 80 characters > #599: FILE: arch/arm/dts/imx6sx-sdb.dtsi:417: > + MX6SX_PAD_CSI_DATA07__I2C4_SDA 0x4001b8b1 > > WARNING: line over 80 characters > #600: FILE: arch/arm/dts/imx6sx-sdb.dtsi:418: > + MX6SX_PAD_CSI_DATA06__I2C4_SCL 0x4001b8b1 > > WARNING: line over 80 characters > #640: FILE: arch/arm/dts/imx6sx-sdb.dtsi:458: > + MX6SX_PAD_QSPI1A_DATA0__GPIO4_IO_16 0x80000000 > > WARNING: line over 80 characters > #740: FILE: arch/arm/dts/imx6sx-sdb.dtsi:558: > + MX6SX_PAD_KEY_COL0__GPIO2_IO_10 0x17059 /* CD */ > > WARNING: line over 80 characters > #741: FILE: arch/arm/dts/imx6sx-sdb.dtsi:559: > + MX6SX_PAD_KEY_ROW0__GPIO2_IO_15 0x17059 /* WP */ > > WARNING: line over 80 characters > #783: FILE: arch/arm/dts/imx6sx-sdb.dtsi:601: > + MX6SX_PAD_SD4_DATA7__GPIO6_IO_21 0x17059 /* CD */ > > WARNING: line over 80 characters > #784: FILE: arch/arm/dts/imx6sx-sdb.dtsi:602: > + MX6SX_PAD_SD4_DATA6__GPIO6_IO_20 0x17059 /* WP */ > > total: 0 errors, 14 warnings, 0 checks, 757 lines checked > WARNING: 'framwork' may be misspelled - perhaps 'framework'? > #7: > framwork now and wdog reset will be triggered once set WDOG_B mux > > WARNING: 'framwork' may be misspelled - perhaps 'framework'? > #49: FILE: board/freescale/mx6sxsabresd/mx6sxsabresd.c:306: > + * framwork now and wdog reset will be triggered once set WDOG_B mux > > total: 0 errors, 2 warnings, 0 checks, 33 lines checked > WARNING: line over 80 characters > #95: FILE: arch/arm/mach-imx/mx5/clock.c:918: > +static int do_mx5_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > > total: 0 errors, 1 warnings, 0 checks, 85 lines checked > CHECK: Alignment should match open parenthesis > #60: FILE: board/toradex/apalis_imx6/pf0100.c:214: > +static int do_pf0100_prog(cmd_tbl_t *cmdtp, int flag, int argc, > char * const argv[]) > > CHECK: Alignment should match open parenthesis > #109: FILE: board/toradex/colibri_imx6/pf0100.c:196: > +static int do_pf0100_prog(cmd_tbl_t *cmdtp, int flag, int argc, > char * const argv[]) > > total: 0 errors, 0 warnings, 2 checks, 79 lines checked > WARNING: line over 80 characters > #56: FILE: include/configs/cm_fx6.h:158: > + "if test $board_name = Utilite && test $board_rev = MX6Q ; then " \ > > total: 0 errors, 1 warnings, 0 checks, 26 lines checked > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #45: FILE: arch/arm/include/asm/mach-imx/hab.h:148: > +int authenticate_image(uint32_t ddr_start, uint32_t image_size); > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #57: FILE: arch/arm/mach-imx/hab.c:413: > +int authenticate_image(uint32_t ddr_start, uint32_t image_size) > > total: 0 errors, 0 warnings, 2 checks, 15 lines checked > WARNING: Prefer using '"%s...", __func__' to using 'authenticate_image', this function's name, in a string > #95: FILE: arch/arm/mach-imx/hab.c:465: > + puts("\nCalling authenticate_image in ROM\n"); > > total: 0 errors, 1 warnings, 0 checks, 160 lines checked > WARNING: Prefer using '"%s...", __func__' to using 'authenticate_image', this function's name, in a string > #85: FILE: arch/arm/mach-imx/hab.c:469: > + puts("\nCalling authenticate_image in ROM\n"); > > total: 0 errors, 1 warnings, 0 checks, 135 lines checked > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #67: FILE: arch/arm/include/asm/mach-imx/hab.h:151: > +int authenticate_image(uint32_t ddr_start, uint32_t image_size, > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #159: FILE: arch/arm/mach-imx/hab.c:386: > +int authenticate_image(uint32_t ddr_start, uint32_t image_size, > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #165: FILE: arch/arm/mach-imx/hab.c:391: > + uint32_t ivt_addr = 0; > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #252: FILE: arch/arm/mach-imx/spl.c:192: > + uint32_t offset; > > total: 0 errors, 0 warnings, 4 checks, 188 lines checked > CHECK: Prefer kernel type 'u8' over 'uint8_t' > #49: FILE: arch/arm/include/asm/mach-imx/hab.h:25: > + uint8_t magic; > > CHECK: Prefer kernel type 'u16' over 'uint16_t' > #50: FILE: arch/arm/include/asm/mach-imx/hab.h:26: > + uint16_t length; > > CHECK: Prefer kernel type 'u8' over 'uint8_t' > #51: FILE: arch/arm/include/asm/mach-imx/hab.h:27: > + uint8_t version; > > WARNING: __packed is preferred over __attribute__((packed)) > #52: FILE: arch/arm/include/asm/mach-imx/hab.h:28: > +} __attribute__((packed)); > > WARNING: Adding new packed members is to be done with care > #52: FILE: arch/arm/include/asm/mach-imx/hab.h:28: > +} __attribute__((packed)); > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #56: FILE: arch/arm/include/asm/mach-imx/hab.h:32: > + uint32_t entry; /* Absolute address of first instruction */ > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #57: FILE: arch/arm/include/asm/mach-imx/hab.h:33: > + uint32_t reserved1; /* Reserved should be zero */ > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #58: FILE: arch/arm/include/asm/mach-imx/hab.h:34: > + uint32_t dcd; /* Absolute address of the image DCD */ > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #59: FILE: arch/arm/include/asm/mach-imx/hab.h:35: > + uint32_t boot; /* Absolute address of the boot data */ > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #60: FILE: arch/arm/include/asm/mach-imx/hab.h:36: > + uint32_t self; /* Absolute address of the IVT */ > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #61: FILE: arch/arm/include/asm/mach-imx/hab.h:37: > + uint32_t csf; /* Absolute address of the CSF */ > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #62: FILE: arch/arm/include/asm/mach-imx/hab.h:38: > + uint32_t reserved2; /* Reserved should be zero */ > > total: 0 errors, 2 warnings, 10 checks, 34 lines checked > CHECK: Prefer kernel type 'u8' over 'uint8_t' > #172: FILE: arch/arm/mach-imx/hab.c:212: > +static uint8_t hab_statuses[5] = { > > CHECK: Prefer kernel type 'u8' over 'uint8_t' > #181: FILE: arch/arm/mach-imx/hab.c:220: > +static uint8_t hab_reasons[26] = { > > CHECK: Prefer kernel type 'u8' over 'uint8_t' > #190: FILE: arch/arm/mach-imx/hab.c:249: > +static uint8_t hab_contexts[12] = { > > CHECK: Prefer kernel type 'u8' over 'uint8_t' > #199: FILE: arch/arm/mach-imx/hab.c:264: > +static uint8_t hab_engines[16] = { > > CHECK: Prefer kernel type 'u8' over 'uint8_t' > #208: FILE: arch/arm/mach-imx/hab.c:295: > +static void process_event_record(uint8_t *event_data, size_t bytes) > > CHECK: Prefer kernel type 'u8' over 'uint8_t' > #217: FILE: arch/arm/mach-imx/hab.c:305: > +static void display_event(uint8_t *event_data, size_t bytes) > > total: 0 errors, 0 warnings, 6 checks, 213 lines checked > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #38: FILE: arch/arm/include/asm/mach-imx/hab.h:188: > +int imx_hab_authenticate_image(uint32_t ddr_start, uint32_t image_size, > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > #61: FILE: arch/arm/mach-imx/hab.c:438: > +int imx_hab_authenticate_image(uint32_t ddr_start, uint32_t image_size, > > total: 0 errors, 0 warnings, 2 checks, 38 lines checked >
Hi Tom, please pull from u-boot-imx, thanks ! The following changes since commit 373b9003410b44a1133060c2e63483b278fb476b: Merge git://git.denx.de/u-boot-sunxi (2018-01-11 14:14:19 -0500) are available in the git repository at: git://www.denx.de/git/u-boot-imx.git master for you to fetch changes up to 9587b0d61133c025d48ebf480aa021fc2fdd53a7: arm: imx: hab: Add hab_failsafe console command (2018-01-14 17:26:30 +0100) ---------------------------------------------------------------- Bryan O'Donoghue (25): arm: imx: hab: Make authenticate_image return int arm: imx: hab: Fix authenticate_image result code arm: imx: hab: Optimise flow of authenticate_image on is_enabled fail arm: imx: hab: Optimise flow of authenticate_image on hab_entry fail arm: imx: hab: Move IVT_SIZE to hab.h arm: imx: hab: Move CSF_PAD_SIZE to hab.h arm: imx: hab: Fix authenticate_image input parameters arm: imx: hab: Add IVT header definitions arm: imx: hab: Add IVT header verification arm: imx: hab: Verify IVT self matches calculated address arm: imx: hab: Only call ROM once headers are verified arm: imx: hab: Print CSF based on IVT descriptor arm: imx: hab: Print additional IVT elements during debug arm: imx: hab: Define rvt_check_target() arm: imx: hab: Implement hab_rvt_check_target arm: imx: hab: Add a hab_rvt_check_target to image auth arm: imx: hab: Print HAB event log only after calling ROM arm: imx: hab: Make internal functions and data static arm: imx: hab: Prefix authenticate_image with imx_hab arm: imx: hab: Rename is_hab_enabled imx_hab_is_enabled arm: imx: hab: Make authenticate_image() return zero on open boards arm: imx: hab: Make imx_hab_is_enabled global arm: imx: hab: Define rvt_failsafe() arm: imx: hab: Implement hab_rvt_failsafe arm: imx: hab: Add hab_failsafe console command Christopher Spinrath (2): ARM: imx: cm_fx6: export board and soc info to env ARM: imx: cm_fx6: env: try to determine dtb to use Eran Matityahu (2): imx7: spl: Use SPL boot device MMC1 for all of the SOCs MMC/SD boot devices imx7: spl: Add support for MMC3, SD3 and NAND boot devices Fabio Estevam (4): mx6: ddr: Do not access MMDC_P1_BASE_ADDR on i.MX6ULL mx6memcal: Fix the UART ports for mx6sabresd/auto boards mx6memcal: spl: Also take i.MX6ULL into account mx6memcal: spl: Disambiguate the error message Koen Vandeputte (1): drivers: pci: imx: fix enumeration logic error Peng Fan (10): misc: mxc_ocotp: check fuse word before programming on i.MX7ULP ARM: imx: Introduce dts for i.MX6SX-SDB ARM: imx: Enable dts for i.MX6SX-SDB board: freescale: common: add pfuze dm code imx: mx6sxsabresd: Enable DM driver imx: mx6sxsabresd: config wdog pinmux imx: mx6sxsabresd: enlarge ENV offset pci: imx: request gpio before use spi: fsl_qspi: support i.MX6UL/6ULLL/7D imx: mx6ull-14x14-evk: enable DM QSPI driver Stefano Babic (1): mx6: Support SKS-Kinkel sksimx6 Board Tom Rini (4): arm: imx: Rework i.MX specific commands to be excluded from SPL imx: ventana: Rework CONFIG_CMD_EECONFIG code to not be included in SPL imx: ventana: Rework CONFIG_CMD_GSC code to not be included in SPL toradex: imx6: Rework PF0100 fuse programming commands to not be in SPL arch/arm/dts/Makefile | 1 + arch/arm/dts/imx6sx-sdb.dts | 138 +++++++ arch/arm/dts/imx6sx-sdb.dtsi | 612 ++++++++++++++++++++++++++++ arch/arm/dts/imx6ull-14x14-evk.dts | 5 +- arch/arm/dts/imx6ull.dtsi | 9 +- arch/arm/include/asm/mach-imx/hab.h | 46 ++- arch/arm/mach-imx/Makefile | 2 + arch/arm/mach-imx/hab.c | 461 ++++++++++++--------- arch/arm/mach-imx/imx_bootaux.c | 13 +- arch/arm/mach-imx/mx5/clock.c | 4 +- arch/arm/mach-imx/mx6/Kconfig | 6 + arch/arm/mach-imx/mx6/ddr.c | 4 +- arch/arm/mach-imx/mx7/clock.c | 2 + arch/arm/mach-imx/mx7ulp/clock.c | 2 + arch/arm/mach-imx/spl.c | 45 +- board/compulab/cm_fx6/cm_fx6.c | 21 + board/freescale/common/Makefile | 1 + board/freescale/common/pfuze.c | 79 ++++ board/freescale/common/pfuze.h | 5 + board/freescale/mx6memcal/Kconfig | 12 +- board/freescale/mx6memcal/spl.c | 3 +- board/freescale/mx6sxsabresd/mx6sxsabresd.c | 382 +++++++---------- board/gateworks/gw_ventana/eeprom.c | 4 +- board/gateworks/gw_ventana/gsc.c | 2 +- board/sks-kinkel/sksimx6/Kconfig | 11 + board/sks-kinkel/sksimx6/MAINTAINERS | 6 + board/sks-kinkel/sksimx6/Makefile | 3 + board/sks-kinkel/sksimx6/sksimx6.c | 426 +++++++++++++++++++ board/toradex/apalis_imx6/pf0100.c | 9 +- board/toradex/apalis_imx6/pf0100.h | 3 - board/toradex/colibri_imx6/pf0100.c | 8 +- board/toradex/colibri_imx6/pf0100.h | 3 - configs/cm_fx6_defconfig | 2 +- configs/mx6sxsabresd_defconfig | 15 +- configs/mx6sxsabresd_spl_defconfig | 15 +- configs/mx6ull_14x14_evk_defconfig | 6 + configs/mx6ull_14x14_evk_plugin_defconfig | 6 + configs/sksimx6_defconfig | 47 +++ drivers/misc/mxc_ocotp.c | 17 + drivers/pci/pcie_imx.c | 15 + drivers/spi/fsl_qspi.c | 18 +- include/configs/cm_fx6.h | 7 + include/configs/mx6sxsabresd.h | 9 +- include/configs/mx6ullevk.h | 10 + include/configs/sksimx6.h | 101 +++++ 45 files changed, 2103 insertions(+), 493 deletions(-) create mode 100644 arch/arm/dts/imx6sx-sdb.dts create mode 100644 arch/arm/dts/imx6sx-sdb.dtsi create mode 100644 board/sks-kinkel/sksimx6/Kconfig create mode 100644 board/sks-kinkel/sksimx6/MAINTAINERS create mode 100644 board/sks-kinkel/sksimx6/Makefile create mode 100644 board/sks-kinkel/sksimx6/sksimx6.c create mode 100644 configs/sksimx6_defconfig create mode 100644 include/configs/sksimx6.h