diff mbox series

test: cmd: mbr: Remove unreachable code

Message ID ZUr67-KKyaSDv_vk@alg-gentoo
State Accepted
Commit a40f35f0691f862d527ed75329773a24369a5b7e
Delegated to: Tom Rini
Headers show
Series test: cmd: mbr: Remove unreachable code | expand

Commit Message

Alexander Gendin Nov. 8, 2023, 3:05 a.m. UTC 
Fix Coverity (CID 467404): Control flow issues (DEADCODE).
Fix code indentation.

Reported-by: Coverity (CID 467404)
Signed-off-by: Alexander Gendin <agendin@matrox.com>
---
 test/cmd/mbr.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

Comments

Tom Rini Nov. 10, 2023, 4:21 p.m. UTC | #1 
On Wed, Nov 08, 2023 at 03:05:19AM +0000, Alexander Gendin wrote:

> Fix Coverity (CID 467404): Control flow issues (DEADCODE).
> Fix code indentation.
> 
> Reported-by: Coverity (CID 467404)
> Signed-off-by: Alexander Gendin <agendin@matrox.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/test/cmd/mbr.c b/test/cmd/mbr.c
index 5d7402154d..46b78e706c 100644
--- a/test/cmd/mbr.c
+++ b/test/cmd/mbr.c
@@ -205,16 +205,14 @@  static unsigned build_mbr_parts(char *buf, size_t buf_size, unsigned num_parts)
 					bytes_remaining -= cur_str_size;
 
 				}
-			else if (num_parts == 5) {
-				cur_str_size = sizeof(mbr_parts_p5);
-				if (cur_str_size + 1 > bytes_remaining)
-					return 1;
-				strcat(cur_buf, mbr_parts_p5);
-				bytes_remaining -= cur_str_size;
+				else if (num_parts == 5) {
+					cur_str_size = sizeof(mbr_parts_p5);
+					if (cur_str_size + 1 > bytes_remaining)
+						return 1;
+					strcat(cur_buf, mbr_parts_p5);
+					bytes_remaining -= cur_str_size;
 
-			}
-			else if (num_parts > 5)
-				return 1;
+				}
 			}
 		}
 	}