mbox series

[U-Boot] Please pull u-boot-fsl-qoriq master

Message ID VI1PR04MB2078302023038EA810C14CFC9A7B0@VI1PR04MB2078.eurprd04.prod.outlook.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series [U-Boot] Please pull u-boot-fsl-qoriq master | expand

Pull-request

git://git.denx.de/u-boot-fsl-qoriq.git

Message

York Sun June 8, 2018, 11:49 p.m. UTC 
Tom,

The following changes since commit 71002b508a1bc0986023764f155f0db26f548db2:

  cmd: add missing line breaks for pr_err() (2018-06-07 20:06:29 -0400)

are available in the git repository at:

  git://git.denx.de/u-boot-fsl-qoriq.git

for you to fetch changes up to e4d594b4e0b4f81a65bd84c41fa7519b279d5432:

  LS1012AFRWY: Add Secure Boot support (2018-06-08 16:43:19 -0700)

----------------------------------------------------------------
Bhaskar Upadhaya (2):
      board: Kconfig: Re-Arrangement of PPA firmware and header addresses
      board: ls1012a: FRWY-LS1012A board support

Jagdish Gediya (1):
      arm: ls1021aqds: config: enable CONFIG_ID_EEPROM for mac command

Priyanka Jain (1):
      board/freescale,lsch3: Add entry for 0.9v

Ran Wang (1):
      armv8: ls1088a: Enable USB in
ls1088ardb_sdcard_qspi_SECURE_BOOT_defconfig

Vinitha V Pillai (1):
      LS1012AFRWY: Add Secure Boot support

 arch/arm/Kconfig                                   |  13 ++
 arch/arm/cpu/armv8/Kconfig                         |   1 +
 arch/arm/cpu/armv8/fsl-layerscape/Kconfig          |  34 ------
 arch/arm/dts/Makefile                              |   3 +-
 arch/arm/dts/fsl-ls1012a-frwy.dts                  |  43 +++++++
 board/freescale/common/vid.c                       |   2 +-
 board/freescale/ls1012afrdm/Kconfig                |  47 +++++++-
 board/freescale/ls1012afrdm/MAINTAINERS            |  11 ++
 board/freescale/ls1012afrdm/ls1012afrdm.c          |  73 ++++++++++-
 board/freescale/ls1012aqds/Kconfig                 |   3 +
 board/freescale/ls1012ardb/Kconfig                 |  14 +++
 board/freescale/ls1043aqds/Kconfig                 |  16 +++
 board/freescale/ls1043ardb/Kconfig                 |  14 +++
 board/freescale/ls1046aqds/Kconfig                 |  16 +++
 board/freescale/ls1046ardb/Kconfig                 |  15 +++
 board/freescale/ls1088a/Kconfig                    |  28 +++++
 board/freescale/ls2080aqds/Kconfig                 |  16 +++
 board/freescale/ls2080ardb/Kconfig                 |  31 +++--
 configs/ls1012afrwy_qspi_SECURE_BOOT_defconfig     |  54 +++++++++
 configs/ls1012afrwy_qspi_defconfig                 |  50 ++++++++
 .../ls1088ardb_sdcard_qspi_SECURE_BOOT_defconfig   |   7 ++
 drivers/net/pfe_eth/pfe_firmware.c                 |  29 +++++
 include/configs/ls1012afrwy.h                      | 134
+++++++++++++++++++++
 include/configs/ls1021aqds.h                       |   9 ++
 24 files changed, 603 insertions(+), 60 deletions(-)
 create mode 100644 arch/arm/dts/fsl-ls1012a-frwy.dts
 create mode 100644 configs/ls1012afrwy_qspi_SECURE_BOOT_defconfig
 create mode 100644 configs/ls1012afrwy_qspi_defconfig
 create mode 100644 include/configs/ls1012afrwy.h

Thanks.

York

Comments

Tom Rini June 9, 2018, 4:39 a.m. UTC | #1 
On Fri, Jun 08, 2018 at 11:49:32PM +0000, York Sun wrote:

> Tom,
> 
> The following changes since commit 71002b508a1bc0986023764f155f0db26f548db2:
> 
>   cmd: add missing line breaks for pr_err() (2018-06-07 20:06:29 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-fsl-qoriq.git
> 
> for you to fetch changes up to e4d594b4e0b4f81a65bd84c41fa7519b279d5432:
> 
>   LS1012AFRWY: Add Secure Boot support (2018-06-08 16:43:19 -0700)
> 

NAK.  First, include/configs/ls1012afrwy.h needs a kernel-style SPDX
tag.  Second (and harder) is that:
commit 6f54af8c1a4dfa66cdeb5931ba5f76a22753d139
Author: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com>
Date:   Wed May 23 11:03:30 2018 +0530

    board: ls1012a: FRWY-LS1012A board support

breaks imx6dl_mamoj builds.
York Sun June 9, 2018, 4:46 a.m. UTC | #2 
Thanks for the feedback. I didn't catch the failure. Travis build failed on many targets due to toolchain download. My setup doesn't cover i.mx.

York

Sent from my iPhone

> On Jun 8, 2018, at 21:39, Tom Rini <trini@konsulko.com> wrote:
> 
>> On Fri, Jun 08, 2018 at 11:49:32PM +0000, York Sun wrote:
>> 
>> Tom,
>> 
>> The following changes since commit 71002b508a1bc0986023764f155f0db26f548db2:
>> 
>>  cmd: add missing line breaks for pr_err() (2018-06-07 20:06:29 -0400)
>> 
>> are available in the git repository at:
>> 
>>  git://git.denx.de/u-boot-fsl-qoriq.git
>> 
>> for you to fetch changes up to e4d594b4e0b4f81a65bd84c41fa7519b279d5432:
>> 
>>  LS1012AFRWY: Add Secure Boot support (2018-06-08 16:43:19 -0700)
>> 
> 
> NAK.  First, include/configs/ls1012afrwy.h needs a kernel-style SPDX
> tag.  Second (and harder) is that:
> commit 6f54af8c1a4dfa66cdeb5931ba5f76a22753d139
> Author: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com>
> Date:   Wed May 23 11:03:30 2018 +0530
> 
>    board: ls1012a: FRWY-LS1012A board support
> 
> breaks imx6dl_mamoj builds.
> 
> -- 
> Tom
York Sun June 9, 2018, 4:57 a.m. UTC | #3 
On 06/08/2018 09:39 PM, Tom Rini wrote:
> On Fri, Jun 08, 2018 at 11:49:32PM +0000, York Sun wrote:
> 
>> Tom,
>>
>> The following changes since commit 71002b508a1bc0986023764f155f0db26f548db2:
>>
>>   cmd: add missing line breaks for pr_err() (2018-06-07 20:06:29 -0400)
>>
>> are available in the git repository at:
>>
>>   git://git.denx.de/u-boot-fsl-qoriq.git
>>
>> for you to fetch changes up to e4d594b4e0b4f81a65bd84c41fa7519b279d5432:
>>
>>   LS1012AFRWY: Add Secure Boot support (2018-06-08 16:43:19 -0700)
>>
> 
> NAK.  First, include/configs/ls1012afrwy.h needs a kernel-style SPDX

This is easy to fix to follow the new format.

> tag.  Second (and harder) is that:
> commit 6f54af8c1a4dfa66cdeb5931ba5f76a22753d139
> Author: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com>
> Date:   Wed May 23 11:03:30 2018 +0530
> 
>     board: ls1012a: FRWY-LS1012A board support
> 
> breaks imx6dl_mamoj builds.
> 

Can you share your build log? I am having trouble to connect to my AWS
server today. This commit doesn't touch imx6dl_mamoj.

York
Tom Rini June 11, 2018, 12:25 p.m. UTC | #4 
On Sat, Jun 09, 2018 at 04:46:59AM +0000, York Sun wrote:

> Thanks for the feedback. I didn't catch the failure. Travis build
> failed on many targets due to toolchain download. My setup doesn't
> cover i.mx.

FWIW, when that happens you can just re-run that particular job and it
usually then works.  I have to do that a few times a week.
Tom Rini June 11, 2018, 12:29 p.m. UTC | #5 
On Sat, Jun 09, 2018 at 04:57:44AM +0000, York Sun wrote:
> On 06/08/2018 09:39 PM, Tom Rini wrote:
> > On Fri, Jun 08, 2018 at 11:49:32PM +0000, York Sun wrote:
> > 
> >> Tom,
> >>
> >> The following changes since commit 71002b508a1bc0986023764f155f0db26f548db2:
> >>
> >>   cmd: add missing line breaks for pr_err() (2018-06-07 20:06:29 -0400)
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.denx.de/u-boot-fsl-qoriq.git
> >>
> >> for you to fetch changes up to e4d594b4e0b4f81a65bd84c41fa7519b279d5432:
> >>
> >>   LS1012AFRWY: Add Secure Boot support (2018-06-08 16:43:19 -0700)
> >>
> > 
> > NAK.  First, include/configs/ls1012afrwy.h needs a kernel-style SPDX
> 
> This is easy to fix to follow the new format.
> 
> > tag.  Second (and harder) is that:
> > commit 6f54af8c1a4dfa66cdeb5931ba5f76a22753d139
> > Author: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com>
> > Date:   Wed May 23 11:03:30 2018 +0530
> > 
> >     board: ls1012a: FRWY-LS1012A board support
> > 
> > breaks imx6dl_mamoj builds.
> > 
> 
> Can you share your build log? I am having trouble to connect to my AWS
> server today. This commit doesn't touch imx6dl_mamoj.

+(imx6dl_mamoj) common/spl/built-in.o: In function `board_init_r':
+(imx6dl_mamoj) build/../common/spl/spl.c:492: undefined reference to `spl_board_init'
+(imx6dl_mamoj) make[2]: *** [../scripts/Makefile.spl:347: spl/u-boot-spl] Error 1
+(imx6dl_mamoj) make[1]: *** [Makefile:1507: spl/u-boot-spl] Error 2

Is what I got in my logs.  Both the travis builds and my local builds
are using the toolchains we fetch via buildman, so it shouldn't be too
hard to test just that on any Linux box/VM/etc.
York Sun June 11, 2018, 4:33 p.m. UTC | #6 
On 06/11/2018 05:29 AM, Tom Rini wrote:
> On Sat, Jun 09, 2018 at 04:57:44AM +0000, York Sun wrote:
>> On 06/08/2018 09:39 PM, Tom Rini wrote:
>>> On Fri, Jun 08, 2018 at 11:49:32PM +0000, York Sun wrote:
>>>
>>>> Tom,
>>>>
>>>> The following changes since commit 71002b508a1bc0986023764f155f0db26f548db2:
>>>>
>>>>   cmd: add missing line breaks for pr_err() (2018-06-07 20:06:29 -0400)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>   git://git.denx.de/u-boot-fsl-qoriq.git
>>>>
>>>> for you to fetch changes up to e4d594b4e0b4f81a65bd84c41fa7519b279d5432:
>>>>
>>>>   LS1012AFRWY: Add Secure Boot support (2018-06-08 16:43:19 -0700)
>>>>
>>>
>>> NAK.  First, include/configs/ls1012afrwy.h needs a kernel-style SPDX
>>
>> This is easy to fix to follow the new format.
>>
>>> tag.  Second (and harder) is that:
>>> commit 6f54af8c1a4dfa66cdeb5931ba5f76a22753d139
>>> Author: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com>
>>> Date:   Wed May 23 11:03:30 2018 +0530
>>>
>>>     board: ls1012a: FRWY-LS1012A board support
>>>
>>> breaks imx6dl_mamoj builds.
>>>
>>
>> Can you share your build log? I am having trouble to connect to my AWS
>> server today. This commit doesn't touch imx6dl_mamoj.
> 
> +(imx6dl_mamoj) common/spl/built-in.o: In function `board_init_r':
> +(imx6dl_mamoj) build/../common/spl/spl.c:492: undefined reference to `spl_board_init'
> +(imx6dl_mamoj) make[2]: *** [../scripts/Makefile.spl:347: spl/u-boot-spl] Error 1
> +(imx6dl_mamoj) make[1]: *** [Makefile:1507: spl/u-boot-spl] Error 2
> 
> Is what I got in my logs.  Both the travis builds and my local builds
> are using the toolchains we fetch via buildman, so it shouldn't be too
> hard to test just that on any Linux box/VM/etc.
> 

Thanks. I see what is wrong. Will push a force update and request a pull.

York