From patchwork Mon Apr 8 14:49:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Timur Prokopenko X-Patchwork-Id: 1081575 X-Patchwork-Delegate: panto@antoniou-consulting.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="aUezG3Mi"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 44dQcC1VWLz9sPY for ; Tue, 9 Apr 2019 08:50:16 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 45C06C21E0D; Mon, 8 Apr 2019 22:50:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 7DCFEC21DD4; Mon, 8 Apr 2019 22:50:09 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 5CC98C21D4A; Mon, 8 Apr 2019 14:49:23 +0000 (UTC) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by lists.denx.de (Postfix) with ESMTPS id EC5F0C21DD7 for ; Mon, 8 Apr 2019 14:49:19 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id j9so16769596wrn.6 for ; Mon, 08 Apr 2019 07:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=18AEtkkGUZPHeM97uZAVWcpM+Kl7VHVEwtsXrye2MpY=; b=aUezG3MiKFrqmi7YpVmlZcblfpB7r10Z7vdnhDxN/jkgpT4CBzmqVD7nFedCSj3ILp pjlcSzttj/3+evGZZx/HbbBd/Oyl/ou+2IPfdoXOXErNBHmSA4DXAfvHPIpilg51kMy0 e8cJnshvz2SNGDNOS9XOWl958xr2gRR5qaDk8NaoiTgjy0C5QG7m+mMiq7QBPaeGP9F2 3zk+DIgcqbbJ+J1yjMCP1voOgFF8a57jv1QrMA3XfEsgdk/FRZXbs511TGBv2/BRqtYo ujoxigS6MT/peG4FYfIndb3miLGKrU5bSZtfSmDwkV9eYGAxvPN9WuP/zkxU+D7IrHxd fBpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=18AEtkkGUZPHeM97uZAVWcpM+Kl7VHVEwtsXrye2MpY=; b=F6fNEZ8pHhYHM+ds1uIUHai1GHlEKIpCRoAsAomgvpsCexuVl9Nua/gcbKzDZJiyyc KOOUfThzOzO1L+v9jbXYSTDpCqgbuVllDf6UQNThJTfsFSfkZuBqqqrFfPBiXmIXsiUP P/iE9xfDzs6np4QjXWw4zmJgVf7tIixMdSiDRvyajmBUgT+gMldxspThCzYn0e3LTOJa qoQOTJFB5zS18AG/U9WkLOydfqkiALoXqC5YXr/jsnzUP9Ila9gx3FU+Lj2AMLHW5wy2 OLqSLhp/WFhRj4XpxZ5fyun6tJ1leI/Huc7oQjS44guASsby1qdtoYZpdOneLqDU7KRQ i9JQ== X-Gm-Message-State: APjAAAVq7GowjijkYk42z9jAJtG66gMsec7DFwCY8pBcOMhAka8iLIY2 icEUZVf8lW1Jwaz+AxwsNZZNYKX3eE4tpLY0lMhkMrd7Wic= X-Google-Smtp-Source: APXvYqwBp4dLgy0/4rTJYyyMTDfZIBVz+4+BZZoQYCxzZ1jIeNLnGNLAmDZmDgIG1I2bYkYvC6wokdijamCv8GgCONY= X-Received: by 2002:adf:f101:: with SMTP id r1mr19578841wro.251.1554734959153; Mon, 08 Apr 2019 07:49:19 -0700 (PDT) MIME-Version: 1.0 From: Timur Prokopenko Date: Mon, 8 Apr 2019 17:49:08 +0300 Message-ID: To: u-boot@lists.denx.de X-Mailman-Approved-At: Mon, 08 Apr 2019 22:50:07 +0000 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Subject: [U-Boot] [PATCH] mmc: sdhci: Read capabilities register before updating host caps X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Timur Prokopenko Date: Thu, 4 Apr 2019 11:05:05 +0300 Subject: [U-Boot] [PATCH] mmc: sdhci: Read capabilities register and update host caps U-Boot doesn't analyze SDHCI capabilities register while choosing speed mode and sets HS mode unconditionally which is incorrect. This patch checks the capabilities register and sets the host caps accordingly. Signed-off-by: Timur Prokopenko --- drivers/mmc/sdhci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) if (SDHCI_GET_VERSION(host) >= SDHCI_SPEC_300) { diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index cdeba914f9..66a752add0 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -628,7 +628,9 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhci_host *host, if (host->quirks & SDHCI_QUIRK_BROKEN_VOLTAGE) cfg->voltages |= host->voltages; - cfg->host_caps |= MMC_MODE_HS | MMC_MODE_HS_52MHz | MMC_MODE_4BIT; + if (caps & SDHCI_CAN_DO_HISPD) + cfg->host_caps |= MMC_MODE_HS | MMC_MODE_HS_52MHz | + MMC_MODE_4BIT; /* Since Host Controller Version3.0 */