From patchwork Fri Mar 10 11:03:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas le bayon X-Patchwork-Id: 737351 X-Patchwork-Delegate: l.majewski@samsung.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3vfkrl2DN0z9rxl for ; Fri, 10 Mar 2017 22:03:18 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UveAG7/D"; dkim-atps=neutral Received: by lists.denx.de (Postfix, from userid 105) id B2B8EC21C66; Fri, 10 Mar 2017 11:03:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id AE701C21C39; Fri, 10 Mar 2017 11:03:08 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 3DC8FC21C39; Fri, 10 Mar 2017 11:03:07 +0000 (UTC) Received: from mail-it0-f68.google.com (mail-it0-f68.google.com [209.85.214.68]) by lists.denx.de (Postfix) with ESMTPS id A8D0CC21C30 for ; Fri, 10 Mar 2017 11:03:06 +0000 (UTC) Received: by mail-it0-f68.google.com with SMTP id f203so959078itf.2 for ; Fri, 10 Mar 2017 03:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=+VIQ3ip/zimdNQLnLXeFOGaAyWajxYcXSNbpPrppDCI=; b=UveAG7/DfiTqyVu0oHf4v9yZOc52wLl1wVoU4eozSPQhDxHuFbBZcNnu5YJkAShhuV fjb4SPteOQffUp4LFNOgtGdObCdmceKHDPU6DKOetz7JagGF3Y6Zq3zHmxVFxPjmK8hv UP2RyVcc3gsrtefUyLJb/cJlgo2qdfumNzwcRFAGwxyXGYvQcyj7DAVjBISmakK5S/39 WjK/ugPykCCmsLEYiGKEu+UZoUssBgiG4c4IuqmjJesUtGdodiJt21eOUGPZJ4ykV6Bi 0NQUpd6BBHP9dHJLov9noDZqFes7FI1fad+/BICu55ea1RcgDk5ufAEV3p8VoA4L8/vf rbig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=+VIQ3ip/zimdNQLnLXeFOGaAyWajxYcXSNbpPrppDCI=; b=t8Zs9SyVgYXtnw2gQ0iv1wnHV9LZz17QYX30qLor7NhPuTcrjqcce7sS/IEpCVQ1o8 rkwvJt6TrhQQKDVmGkhR9TfN2sIFmTd7u1pjulcdFt2P9GViP4n5AOFUemS1MsBZ7C0T sonTK56btbQtlK8wRrBEHD8IiXWp3A6e9jeJu4t1qZwvN7ZUPMyx9/R1V0C8FrRtDQQk GXm3pn1J6ofeIynDF+AnKZlZZcwCGx7DVvLNch5r5JDeBMCWWX2rLRDtw/VPXiPzQDeC x+83J1sVOrevbyIL2FASaDoftOQ0JtJAZ/MyfQX9JOYaWZYF4iLPw8+S1kz80GTFJAi7 +M2g== X-Gm-Message-State: AFeK/H1Kf5SN/7GNG5+FXBylvkskhP1Zf6mlLfShHvVr38YNnYdAaw6CDT5xzdVFMq6COboDnBKo3FBCw2yZaQ== X-Received: by 10.36.86.83 with SMTP id o80mr1518030itb.65.1489143785302; Fri, 10 Mar 2017 03:03:05 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.149.129 with HTTP; Fri, 10 Mar 2017 03:03:04 -0800 (PST) From: Nicolas le bayon Date: Fri, 10 Mar 2017 12:03:04 +0100 Message-ID: To: Lukasz Majewski , Marek Vasut , U-Boot@lists.denx.de X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Subject: [U-Boot] [PATCH v2] usb: gadget: dynamic envstr size in cb_getvar X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Hi, here is a second patch proposal with a dynamic size allocation for evstr in cb_getvar. Thanks in advance for your feedback/approval. Best Regards Nicolas --- --- drivers/usb/gadget/f_fastboot.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) strncat(response, s, chars_left); diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c index 2160b1c..8b73277 100644 --- a/drivers/usb/gadget/f_fastboot.c +++ b/drivers/usb/gadget/f_fastboot.c @@ -432,9 +432,11 @@ static void cb_getvar(struct usb_ep *ep, struct usb_request *req) else strcpy(response, "FAILValue not set"); } else { - char envstr[32]; + char *envstr; - snprintf(envstr, sizeof(envstr) - 1, "fastboot.%s", cmd); + envstr = malloc(sizeof("fastboot.%s", cmd) + 1); + + sprintf(envstr, "fastboot.%s", cmd); s = getenv(envstr); if (s) {