From patchwork Wed Jun 24 07:33:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yegor Yefremov X-Patchwork-Id: 487995 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 4BE2E140316 for ; Wed, 24 Jun 2015 17:33:58 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.b=PXpYDMKQ; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D4E824B615; Wed, 24 Jun 2015 09:33:54 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BzKc7E_gcHYA; Wed, 24 Jun 2015 09:33:54 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 843664B61C; Wed, 24 Jun 2015 09:33:54 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7867D4B61C for ; Wed, 24 Jun 2015 09:33:52 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6LnTmNPdJ8Yg for ; Wed, 24 Jun 2015 09:33:52 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-vn0-f46.google.com (mail-vn0-f46.google.com [209.85.216.46]) by theia.denx.de (Postfix) with ESMTPS id 186F44B615 for ; Wed, 24 Jun 2015 09:33:47 +0200 (CEST) Received: by vnav203 with SMTP id v203so5073932vna.8 for ; Wed, 24 Jun 2015 00:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=52ILHOyygnhzmDM+/nZXKoLEjkzCbEQQTwRQqRR84CU=; b=PXpYDMKQMbltm4TH+IQ0qNRnEtuxKv9jrpIRDXzXGUY/OPCyJd1nggD6fnKfHgZxlD 6biEbTvkADS337QwDp+vSmLnF2Fi86mw9LdQGxNQ1kgipVaHrdmE1xRuqZsRB3zGfENS IsSoBG6VNrmxyeYB9r4GCZcKGPzPnR3sQczsWpdxMZlof8Tw1dtxZfCoqOBhlE9+Xz33 t6H9PM0oRFtlo7nt63OH+a77KHDjUsP8I0mULwC35VYxiwn65POnq/oBsgUPJDvqaUf7 2rXjo/LfWtNHp8w7IScDx5V2R0kI5z6pmD88SRQ8BTCpzpT/f00fcFe7+ay/P7m3l4+Y xm/Q== X-Received: by 10.52.248.8 with SMTP id yi8mr35995859vdc.84.1435131226551; Wed, 24 Jun 2015 00:33:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.96.194 with HTTP; Wed, 24 Jun 2015 00:33:26 -0700 (PDT) In-Reply-To: References: <20150612120855.GV1728@bill-the-cat> <1435007730-8451-1-git-send-email-joe.hershberger@ni.com> <1435007730-8451-5-git-send-email-joe.hershberger@ni.com> <20150623142343.GW28577@bill-the-cat> From: Yegor Yefremov Date: Wed, 24 Jun 2015 09:33:26 +0200 Message-ID: To: Joe Hershberger Cc: u-boot , Tom Rini , Joe Hershberger Subject: Re: [U-Boot] [PATCH 4/7] arm: Make new baltos board not break on savedefconfig X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" On Wed, Jun 24, 2015 at 8:55 AM, Yegor Yefremov wrote: > Hi Joe, > > On Wed, Jun 24, 2015 at 5:26 AM, Joe Hershberger > wrote: >> Hi Tom, >> >> On Tue, Jun 23, 2015 at 9:23 AM, Tom Rini wrote: >>> On Mon, Jun 22, 2015 at 04:15:27PM -0500, Joe Hershberger wrote: >>> >>>> This config defined a CONS_INDEX as a config but did not define it in >>>> any Kconfig, so savedefconfig will delete that entry. Use >>>> CONFIG_SYS_EXTRA_OPTIONS for now until that is added to Kconfig. >>>> >>>> Signed-off-by: Joe Hershberger >>>> --- >>>> >>>> configs/am335x_baltos_defconfig | 3 +-- >>>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>> >>>> diff --git a/configs/am335x_baltos_defconfig b/configs/am335x_baltos_defconfig >>>> index 679b04f..030cb51 100644 >>>> --- a/configs/am335x_baltos_defconfig >>>> +++ b/configs/am335x_baltos_defconfig >>>> @@ -1,7 +1,6 @@ >>>> CONFIG_SPL=y >>>> CONFIG_SPL_STACK_R=y >>>> CONFIG_SPL_STACK_R_ADDR=0x82000000 >>>> -CONFIG_SYS_EXTRA_OPTIONS="NAND" >>>> -CONFIG_CONS_INDEX=1 >>>> +CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=1,NAND" >>>> CONFIG_ARM=y >>>> CONFIG_TARGET_AM335X_BALTOS=y >>> >>> No, something else is wrong. board/vscom/baltos/Kconfig has CONS_INDEX >>> (like the other am335x boards and yes this needs moving to a better >>> place). >> >> Any thoughts on what's wrong, then? I'm at FTF this week and won't be >> debugging it until next week. There was an issue with this board, >> caused by savedefconfig, which is why I even noticed this board exists >> now. Maybe whoever added it (Yegor Yefremov) didn't try safedefconfig >> against the board? >> >> If nothing else, at least this makes it consistent with all other >> boards that specify CONS_INDEX. At least they don't break. > > I'll take a look at this. I've pulled the latest master (325849ff3d4adeebb8f8f9bc5db950724df9bc21) and tried: make am35x_baltos_defconfig make savedefconfg make and aside from CONS_INDEX disappearing I see no problems. And "make menuconfig" still shows CONS_INDEX = 1. Should I submit following patch, so that Baltos has the same config as BBB? Yegor diff --git a/configs/am335x_baltos_defconfig b/configs/am335x_baltos_defconfig index 679b04f..1d287a8 100644 --- a/configs/am335x_baltos_defconfig +++ b/configs/am335x_baltos_defconfig @@ -1,7 +1,6 @@ +CONFIG_ARM=y +CONFIG_TARGET_AM335X_BALTOS=y CONFIG_SPL=y CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_ADDR=0x82000000 CONFIG_SYS_EXTRA_OPTIONS="NAND" -CONFIG_CONS_INDEX=1 -CONFIG_ARM=y -CONFIG_TARGET_AM335X_BALTOS=y