diff mbox

[U-Boot,04/10] x86: pci: Do not assign irq 0 to pci device

Message ID BLU437-SMTP18EE21A97275D7BF948A13BF9A0@phx.gbl
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Bin Meng July 15, 2015, 8:23 a.m. UTC 
IRQ 0 is reserved and should not be assigned to pci device.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 arch/x86/cpu/pci.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Simon Glass July 18, 2015, 2:37 p.m. UTC | #1 
On 15 July 2015 at 02:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> IRQ 0 is reserved and should not be assigned to pci device.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  arch/x86/cpu/pci.c | 2 ++
>  1 file changed, 2 insertions(+)

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass July 20, 2015, 2:04 a.m. UTC | #2 
On 18 July 2015 at 08:37, Simon Glass <sjg@chromium.org> wrote:
> On 15 July 2015 at 02:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> IRQ 0 is reserved and should not be assigned to pci device.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>>  arch/x86/cpu/pci.c | 2 ++
>>  1 file changed, 2 insertions(+)
>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-x86, thanks!
diff mbox

Patch

diff --git a/arch/x86/cpu/pci.c b/arch/x86/cpu/pci.c
index fdfd5f7..f8da080 100644
--- a/arch/x86/cpu/pci.c
+++ b/arch/x86/cpu/pci.c
@@ -172,6 +172,8 @@  void pci_assign_irqs(int bus, int device, u8 irq[4])
 			continue;
 
 		line = irq[pin - 1];
+		if (!line)
+			continue;
 
 		debug("Assigning IRQ %d to PCI device %d.%x.%d (INT%c)\n",
 		      line, bus, device, func, 'A' + pin - 1);