diff mbox series

[3/3] Revert "lib: fdt: Split fdtdec_setup_mem_size_base()"

Message ID 9d93536d146fe42b85eaa009c0f539c26536db0c.1594379807.git.michal.simek@xilinx.com
State Accepted
Commit 50c7b723bd47cc8516ea84690f3f07b65a9ee8d6
Delegated to: Simon Glass
Headers show
Series lib: fdt: Remove two functions from fdtdec.c | expand

Commit Message

Michal Simek July 10, 2020, 11:16 a.m. UTC 
This reverts commit 3ebe09d09a407f93022d945a205c5318239eb3f6.

There is no user of this split function that's why remove it.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 include/fdtdec.h | 20 --------------------
 lib/fdtdec.c     | 11 +++--------
 2 files changed, 3 insertions(+), 28 deletions(-)

Comments

Simon Glass July 15, 2020, 1:05 a.m. UTC | #1 
On Fri, 10 Jul 2020 at 05:17, Michal Simek <michal.simek@xilinx.com> wrote:
>
> This reverts commit 3ebe09d09a407f93022d945a205c5318239eb3f6.
>
> There is no user of this split function that's why remove it.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  include/fdtdec.h | 20 --------------------
>  lib/fdtdec.c     | 11 +++--------
>  2 files changed, 3 insertions(+), 28 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/include/fdtdec.h b/include/fdtdec.h
index c9ab822c4428..760b392bdfbc 100644
--- a/include/fdtdec.h
+++ b/include/fdtdec.h
@@ -908,26 +908,6 @@  struct display_timing {
 int fdtdec_decode_display_timing(const void *blob, int node, int index,
 				 struct display_timing *config);
 
-/**
- * fdtdec_setup_mem_size_base_fdt() - decode and setup gd->ram_size and
- * gd->ram_start
- *
- * Decode the /memory 'reg' property to determine the size and start of the
- * first memory bank, populate the global data with the size and start of the
- * first bank of memory.
- *
- * This function should be called from a boards dram_init(). This helper
- * function allows for boards to query the device tree for DRAM size and start
- * address instead of hard coding the value in the case where the memory size
- * and start address cannot be detected automatically.
- *
- * @param blob		FDT blob
- *
- * @return 0 if OK, -EINVAL if the /memory node or reg property is missing or
- * invalid
- */
-int fdtdec_setup_mem_size_base_fdt(const void *blob);
-
 /**
  * fdtdec_setup_mem_size_base() - decode and setup gd->ram_size and
  * gd->ram_start
diff --git a/lib/fdtdec.c b/lib/fdtdec.c
index 0be41ab72774..fa523ce2e908 100644
--- a/lib/fdtdec.c
+++ b/lib/fdtdec.c
@@ -1030,18 +1030,18 @@  int fdtdec_decode_display_timing(const void *blob, int parent, int index,
 	return ret;
 }
 
-int fdtdec_setup_mem_size_base_fdt(const void *blob)
+int fdtdec_setup_mem_size_base(void)
 {
 	int ret, mem;
 	struct fdt_resource res;
 
-	mem = fdt_path_offset(blob, "/memory");
+	mem = fdt_path_offset(gd->fdt_blob, "/memory");
 	if (mem < 0) {
 		debug("%s: Missing /memory node\n", __func__);
 		return -EINVAL;
 	}
 
-	ret = fdt_get_resource(blob, mem, "reg", 0, &res);
+	ret = fdt_get_resource(gd->fdt_blob, mem, "reg", 0, &res);
 	if (ret != 0) {
 		debug("%s: Unable to decode first memory bank\n", __func__);
 		return -EINVAL;
@@ -1055,11 +1055,6 @@  int fdtdec_setup_mem_size_base_fdt(const void *blob)
 	return 0;
 }
 
-int fdtdec_setup_mem_size_base(void)
-{
-	return fdtdec_setup_mem_size_base_fdt(gd->fdt_blob);
-}
-
 #if defined(CONFIG_NR_DRAM_BANKS)
 
 static int get_next_memory_node(const void *blob, int mem)