diff mbox

[U-Boot] zynq: spi: Remove unnecessary error condition

Message ID 89267fe89c1608e20149e7dbf43684a581ee9c2b.1429096406.git.michal.simek@xilinx.com
State Accepted
Delegated to: Jagannadha Sutradharudu Teki
Headers show

Commit Message

Michal Simek April 15, 2015, 11:13 a.m. UTC
From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>

Removed the unnecessary error check from spi_xfer
as the bitlen zero is possible now to deassert the
chip select for which no data is required to be transfered.

Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/spi/zynq_spi.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Jagan Teki April 17, 2015, 11:50 a.m. UTC | #1
On 15 April 2015 at 16:43, Michal Simek <michal.simek@xilinx.com> wrote:
> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>
> Removed the unnecessary error check from spi_xfer
> as the bitlen zero is possible now to deassert the
> chip select for which no data is required to be transfered.
>
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  drivers/spi/zynq_spi.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/spi/zynq_spi.c b/drivers/spi/zynq_spi.c
> index 5da87591ceef..e9129da79d99 100644
> --- a/drivers/spi/zynq_spi.c
> +++ b/drivers/spi/zynq_spi.c
> @@ -227,9 +227,6 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout,
>         debug("spi_xfer: bus:%i cs:%i bitlen:%i len:%i flags:%lx\n",
>               slave->bus, slave->cs, bitlen, len, flags);
>
> -       if (bitlen == 0)
> -               return -1;
> -
>         if (bitlen % 8) {
>                 debug("spi_xfer: Non byte aligned SPI transfer\n");
>                 return -1;
> --
> 2.3.5
>

Applied to  u-boot-spi/master

thanks!
diff mbox

Patch

diff --git a/drivers/spi/zynq_spi.c b/drivers/spi/zynq_spi.c
index 5da87591ceef..e9129da79d99 100644
--- a/drivers/spi/zynq_spi.c
+++ b/drivers/spi/zynq_spi.c
@@ -227,9 +227,6 @@  int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout,
 	debug("spi_xfer: bus:%i cs:%i bitlen:%i len:%i flags:%lx\n",
 	      slave->bus, slave->cs, bitlen, len, flags);
 
-	if (bitlen == 0)
-		return -1;
-
 	if (bitlen % 8) {
 		debug("spi_xfer: Non byte aligned SPI transfer\n");
 		return -1;