From patchwork Mon Apr 10 10:23:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaehoon Chung X-Patchwork-Id: 748918 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3w1mVP6Q1zz9sN8 for ; Mon, 10 Apr 2017 20:23:25 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 3D1FBC21E35; Mon, 10 Apr 2017 10:23:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 785E9C21DBD; Mon, 10 Apr 2017 10:23:16 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id CCA2CC21DBD; Mon, 10 Apr 2017 10:23:14 +0000 (UTC) Received: from epoutp02.samsung.com (mailout2.samsung.com [203.254.224.25]) by lists.denx.de (Postfix) with ESMTPS id 0B988C21C26 for ; Mon, 10 Apr 2017 10:23:14 +0000 (UTC) Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by epoutp02.samsung.com (KnoxPortal) with ESMTP id 20170410102309epoutp028077033395bf0537eb9f34e1f184505c~0AjHHJ_ox2582125821epoutp02M; Mon, 10 Apr 2017 10:23:09 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.40.65]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20170410102309epcas1p3413987aea40163fb6b19b22cd9c34850~0AjG9UyiO0642806428epcas1p3y; Mon, 10 Apr 2017 10:23:09 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id DC.3C.03717.C0D5BE85; Mon, 10 Apr 2017 19:23:08 +0900 (KST) Received: from epcpsbgm1new.samsung.com (u26.gpu120.samsung.co.kr [203.254.230.26]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20170410102308epcas1p2640656b009a042f50f52ab46b60ad9e9~0AjF_1jyG1910719107epcas1p2x; Mon, 10 Apr 2017 10:23:08 +0000 (GMT) X-AuditID: b6c32a39-f790c6d000000e85-58-58eb5d0c6757 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id E2.21.05715.C0D5BE85; Mon, 10 Apr 2017 19:23:08 +0900 (KST) Received: from [10.113.62.216] by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OO600G8GVIJT070@mmp1.samsung.com>; Mon, 10 Apr 2017 19:23:08 +0900 (KST) From: Jaehoon Chung To: U-Boot Mailing List Message-id: <8214704e-45cf-d689-f233-d49097b996ac@samsung.com> Date: Mon, 10 Apr 2017 19:23:08 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCKsWRmVeSWpSXmKPExsWy7bCmgS5P7OsIg5V/hC0+7XzMavF2bye7 A5PH2Ts7GD2un9nOFMAUlWqTkZqYklqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ib aqvk4hOg65aZAzRfSaEsMacUKBSQWFyspG9nU5RfWpKqkJFfXGKrFG1oaKRnaGCuZ2RkpGdi HGtlZApUkpCa8XTPMvaCjWwV5y7cZG1gnMTaxcjJISFgIvF8z20oW0ziwr31bF2MXBxCAjsY Jd4caWaBcNqZJB5s/QuU4QDr+L0jGyK+nFHi3bUpjBDOPUaJv/snMoGMYhPQkdj+7TiYLSKg J/H47FGwFcxA8WWfbrOB2MJA8Q1b9zOCDOUVsJNY9CAEJMwioCoxceJmRhBbVCBMYvP9l+wg Nq+AoMSPyfdYIMZoSrz4MgnKlpfYvOYtM8gNEgLX2SRefznPBHGorMSmA8wQn7lIdH/4CPWl sMSr41vYIWxpiVX/bjFB9LYzStz6sY8NwulglDj4cy9Uh7HE/Qf3mCG28Um8+9rDCrGAV6Kj TQiixEPiYPsdJgjbUeL9j/1gDwgJxEq8P7GCfQKj3CwkP8xC8sMsJD8sYGRexSiWWlCcm55a bFhgqlecmFtcmpeul5yfu4kRnKK0LHcwHjvnc4hRgINRiYf3R8WrCCHWxLLiytxDjBIczEoi vLyhryOEeFMSK6tSi/Lji0pzUosPMZoCw3Uis5Rocj4wfeaVxBuaWBqYmBkBk5eloaGSOK/o +msRQgLpiSWp2ampBalFMH1MHJxSDYyKue4CzB8qM+2FY4yj1XbfKE/ZLRynpHQleG5mX9Pf v+EHM+Te113KkglffObK+pnsUR41jN0bzRblnsxSWuNyyWdi8+KjQWc3yB0/zHJjU8nVCg2J Q6/dnf4fPvHo7gt9J79iDd2qnnMiMgLLJV54ntgX9Xnz/10rLBlir8r4vG7IMC/nfanEUpyR aKjFXFScCACkcQzXZwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsVy+t9jAV2e2NcRBv1zOS0+7XzMavF2bye7 A5PH2Ts7GD2un9nOFMAU5WaTkZqYklqkkJqXnJ+SmZduqxQa4qZroaSQl5ibaqsUoesbEqSk UJaYUwrkGRmgAQfnAPdgJX27BLeMp3uWsRdsZKs4d+EmawPjJNYuRg4OCQETid87srsYOYFM MYkL99azdTFycQgJLGWUmLJyLytIQkjgAZBzVxnEZhPQkdj+7TgTiC0ioCfx+OxRsBpmoPiy T7fZQGxhoPiGrfsZQebzCthJLHoQAhJmEVCVmDhxM1hYVCBM4nmjE0iYV0BQ4sfkeywgYWYB dYkpU3IhBspLbF7zlnkCI98sJFWzEKpmIalawMi8ilEitSC5oDgpPdcwL7Vcrzgxt7g0L10v OT93EyM4tJ9J7WA8uMv9EKMAB6MSD29A9asIIdbEsuLK3EOMEhzMSiK8vKGvI4R4UxIrq1KL 8uOLSnNSiw8xmgJdPpFZSjQ5Hxh3eSXxhibmJubGBhbmlpYmRkrivI2zn4ULCaQnlqRmp6YW pBbB9DFxcEo1MDooGt6pm3bZm31B56rre/NN5gkvXv72cxRXB2PqQtnT6W/sjz2ewdr41Xna LicluWVc5uu3G0/b/Yt78iz/O1K5Gbasr4yuy/UnZ9SvK7maUa48ZddU2ckFZ3MCBT7ndto1 TBKovnrx6ZNfqUm3Lmrwcap+9v5TuMpdTiJ+0bX7W88917s9fYESS3FGoqEWc1FxIgAh+v2Q gwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170410102308epcas1p2640656b009a042f50f52ab46b60ad9e9 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7KCV7J6s7ZuIG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?SmFlaG9vbiBDaHVuZxtUaXplbiBQbGF0Zm9ybSBMYWIuG1Nh?= =?UTF-8?B?bXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170410102308epcas1p2640656b009a042f50f52ab46b60ad9e9 X-RootMTR: 20170410102308epcas1p2640656b009a042f50f52ab46b60ad9e9 References: Cc: Joe Hershberger Subject: [U-Boot] [RFC] Question about nfs_read_reply() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Dear Joe, I have a question about nfs. I don't have a knowledge for NFS..So i don't know this is right or not.. When i have tested the latest u-boot(v2017.03), nfs doesn't work fine with Odroid-xu3. My question is a below thing...In net/nfs.c, nfs_read_reply() function is called the memcpy(). it should be copied the sizeof(rpc_pkt.u.reply))...is it really right? Maybe i'm wrong..so i asked this to you... Best Regards, Jaehoon Chung diff --git a/net/nfs.c b/net/nfs.c index 83ed0a7..09556c7 100644 --- a/net/nfs.c +++ b/net/nfs.c @@ -660,7 +660,8 @@ static int nfs_read_reply(uchar *pkt, unsigned len) debug("%s\n", __func__); memcpy(&rpc_pkt.u.data[0], pkt, sizeof(rpc_pkt.u.reply)); When i changed from "sizeof(rpc_pkt.u.reply)" to "len", it was working fine.