diff mbox

[U-Boot,2/2] net: zynq_gem: Dont flush dummy descriptors

Message ID 758d577677cd07dd913364b920651a3f10d01bb6.1496147318.git.michal.simek@xilinx.com
State Accepted
Commit f0b94c4bcd6f6975c4f8826aaf015038a5555b83
Delegated to: Joe Hershberger
Headers show

Commit Message

Michal Simek May 30, 2017, 12:28 p.m. UTC 
From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>

Dont flush dummy descriptors as they are already
allocated from a region with dcache off. Tested
this on Zynq(zc702) and ZynqMP(zcu102) boards.

Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/net/zynq_gem.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Joe Hershberger May 30, 2017, 4:49 p.m. UTC | #1 
On Tue, May 30, 2017 at 7:28 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>
> Dont flush dummy descriptors as they are already
> allocated from a region with dcache off. Tested
> this on Zynq(zc702) and ZynqMP(zcu102) boards.
>
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Joe Hershberger June 2, 2017, 7:48 p.m. UTC | #2 
Hi Michal,

https://patchwork.ozlabs.org/patch/768580/ was applied to u-boot-net.git.

Thanks!
-Joe
diff mbox

Patch

diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index 9c0f5fba28cd..31bb3f17d835 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -407,10 +407,6 @@  static int zynq_gem_init(struct udevice *dev)
 		dummy_rx_bd->addr = ZYNQ_GEM_RXBUF_WRAP_MASK |
 				ZYNQ_GEM_RXBUF_NEW_MASK;
 		dummy_rx_bd->status = 0;
-		flush_dcache_range((ulong)&dummy_tx_bd, (ulong)&dummy_tx_bd +
-				   sizeof(dummy_tx_bd));
-		flush_dcache_range((ulong)&dummy_rx_bd, (ulong)&dummy_rx_bd +
-				   sizeof(dummy_rx_bd));
 
 		writel((ulong)dummy_tx_bd, &regs->transmit_q1_ptr);
 		writel((ulong)dummy_rx_bd, &regs->receive_q1_ptr);