diff mbox series

tpm: spi: Cleanup source code

Message ID 67e41e5d7262c23e5c0dee9e9aca5ebf369f6fc9.1604933159.git.michal.simek@xilinx.com
State Accepted
Commit d99f163792089f85d57dad5c63db12a5017766c1
Delegated to: Tom Rini
Headers show
Series tpm: spi: Cleanup source code | expand

Commit Message

Michal Simek Nov. 9, 2020, 2:46 p.m. UTC
There is no need for GD to be used and priv variable is unused.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/tpm/tpm2_tis_spi.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Simon Glass Nov. 11, 2020, 2:42 p.m. UTC | #1
On Mon, 9 Nov 2020 at 07:46, Michal Simek <michal.simek@xilinx.com> wrote:
>
> There is no need for GD to be used and priv variable is unused.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  drivers/tpm/tpm2_tis_spi.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Michal Simek Nov. 20, 2020, 9:48 a.m. UTC | #2
po 9. 11. 2020 v 15:46 odesílatel Michal Simek <michal.simek@xilinx.com> napsal:
>
> There is no need for GD to be used and priv variable is unused.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  drivers/tpm/tpm2_tis_spi.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/tpm/tpm2_tis_spi.c b/drivers/tpm/tpm2_tis_spi.c
> index 9a8145e6ba1f..0045bedf0c61 100644
> --- a/drivers/tpm/tpm2_tis_spi.c
> +++ b/drivers/tpm/tpm2_tis_spi.c
> @@ -30,8 +30,6 @@
>  #include "tpm_tis.h"
>  #include "tpm_internal.h"
>
> -DECLARE_GLOBAL_DATA_PTR;
> -
>  #define TPM_ACCESS(l)                  (0x0000 | ((l) << 12))
>  #define TPM_INT_ENABLE(l)               (0x0008 | ((l) << 12))
>  #define TPM_STS(l)                     (0x0018 | ((l) << 12))
> @@ -520,7 +518,6 @@ static int tpm_tis_spi_cleanup(struct udevice *dev)
>  static int tpm_tis_spi_open(struct udevice *dev)
>  {
>         struct tpm_chip *chip = dev_get_priv(dev);
> -       struct tpm_chip_priv *priv = dev_get_uclass_priv(dev);
>
>         if (chip->is_open)
>                 return -EBUSY;
> --
> 2.29.2
>

Not sure who should take it but I am taking it via my tree.
M
diff mbox series

Patch

diff --git a/drivers/tpm/tpm2_tis_spi.c b/drivers/tpm/tpm2_tis_spi.c
index 9a8145e6ba1f..0045bedf0c61 100644
--- a/drivers/tpm/tpm2_tis_spi.c
+++ b/drivers/tpm/tpm2_tis_spi.c
@@ -30,8 +30,6 @@ 
 #include "tpm_tis.h"
 #include "tpm_internal.h"
 
-DECLARE_GLOBAL_DATA_PTR;
-
 #define TPM_ACCESS(l)			(0x0000 | ((l) << 12))
 #define TPM_INT_ENABLE(l)               (0x0008 | ((l) << 12))
 #define TPM_STS(l)			(0x0018 | ((l) << 12))
@@ -520,7 +518,6 @@  static int tpm_tis_spi_cleanup(struct udevice *dev)
 static int tpm_tis_spi_open(struct udevice *dev)
 {
 	struct tpm_chip *chip = dev_get_priv(dev);
-	struct tpm_chip_priv *priv = dev_get_uclass_priv(dev);
 
 	if (chip->is_open)
 		return -EBUSY;