From patchwork Thu Oct 10 09:33:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 1174385 X-Patchwork-Delegate: monstr@monstr.eu Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="aoCuj8+d"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46pm9Q1Fdrz9sCJ for ; Thu, 10 Oct 2019 20:33:30 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id D3BB5C21EF0; Thu, 10 Oct 2019 09:33:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id C42B2C21D8E; Thu, 10 Oct 2019 09:33:17 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 9EA7CC21D8E; Thu, 10 Oct 2019 09:33:16 +0000 (UTC) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by lists.denx.de (Postfix) with ESMTPS id 70536C21C4A for ; Thu, 10 Oct 2019 09:33:15 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id v8so6988575wrt.2 for ; Thu, 10 Oct 2019 02:33:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id; bh=Yt3HcFmQryN9IC1/I+SnMzHHnXj7Y2BWd90OE7lEOoo=; b=aoCuj8+d6Un0QNfuc5yNuv04hHOamN02tchHevPinPRr9g9s8T56F/a9QkplPyyYkc UlQmkGu4OGRnoGEy8musBQn1S98YPXdqeJgA8INr6+scxsmmK1j//Mo+kCVCtAv6Iho8 z4lG0/SagF0nPl5dJBnSqcazLVh9YVZd63nPdM4GQVvH17h4PAZSchtgvlwrgDfcFPNB XcuEMU2FzCw0blOu+GL357jnb6A+59Cr1myD5lT7YfazihKc2bPfopghxJbK6EYIWuEG eiWYMnidCdAIvXBJqD/A3Icvp9kZppI9Bxk80x5ZAc352Bvv5vLJEY17170xu4hbymnW XGhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=Yt3HcFmQryN9IC1/I+SnMzHHnXj7Y2BWd90OE7lEOoo=; b=GlTtdt45ADeKJIQbCsIBhCQTjLTKRN9lLT34c9GZMoyFnv7CiF9oygn8YhfjE25YaX IjJNKjFMmJiFvTC0kRm5xfBrNX976m7TeKuSPcQAWmPjhCbr7KRAKrnu8WKmOySezf5G tUZiwFTFAUqvwpnx9UsjC1+A/kK1hTqc3/yDgmE8aEezCHm2xrBuxTaBRaBhgwEo2LGD g5Xoo0UGqfFlfJIa4lYPHvh0ZTHr6uNvs9mlrlGQFw8BljV2sOzu2xuqYe4xa4PAZw0M MkL5ZWwR0V09Rvk+jczxZ4f4tQ0r/DLFCYazlDsIc/10DMhT1FpQL6lWEYpMRPAmPmgn F5fw== X-Gm-Message-State: APjAAAVIhemAOivR3TIC9SXSn6awTbUZKDFARpgvfkUP3QZsc3GkTjGO JDi+QW9FI/Gu2ZWzwDOruFPPbKOsRoJjqQ== X-Google-Smtp-Source: APXvYqzgsobPqfjrW8tnDJUOmPeZkmajF7d1Sxo5DQyp+452h1gBf+cbY8Di5mn3xJ0jrQRWs5Thrw== X-Received: by 2002:a5d:630b:: with SMTP id i11mr7324676wru.44.1570699994746; Thu, 10 Oct 2019 02:33:14 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id z142sm7432096wmc.24.2019.10.10.02.33.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Oct 2019 02:33:13 -0700 (PDT) From: Michal Simek To: u-boot@lists.denx.de, git@xilinx.com Date: Thu, 10 Oct 2019 11:33:12 +0200 Message-Id: <5ca0ded44e4fe958c537d300a158045d81bbb076.1570699990.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.17.1 Cc: Ibai Erkiaga , Luca Ceresoli , Rajan Vaja Subject: [U-Boot] [PATCH] firmware: zynqmp: Clean up zynqmp_power_probe X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Fix error debug messages to be more accurate and aligned with debug message style in the whole file. And do not initialize ret variable because it is initialized later on and it is just additional step. Fixes: 1327d1678bd2 ("firmware: zynqmp: Add zynqmp-power support") Reported-by: Luca Ceresoli Signed-off-by: Michal Simek Reviewed-by: Luca Ceresoli --- drivers/firmware/firmware-zynqmp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c index 4911734f6c63..dea58b558102 100644 --- a/drivers/firmware/firmware-zynqmp.c +++ b/drivers/firmware/firmware-zynqmp.c @@ -110,19 +110,19 @@ void zynqmp_pmufw_load_config_object(const void *cfg_obj, size_t size) static int zynqmp_power_probe(struct udevice *dev) { - int ret = 0; + int ret; debug("%s, (dev=%p)\n", __func__, dev); ret = mbox_get_by_name(dev, "tx", &zynqmp_power.tx_chan); if (ret) { - debug("%s, cannot tx mailbox\n", __func__); + debug("%s: Cannot find tx mailbox\n", __func__); return ret; } ret = mbox_get_by_name(dev, "rx", &zynqmp_power.rx_chan); if (ret) { - debug("%s, cannot rx mailbox\n", __func__); + debug("%s: Cannot find rx mailbox\n", __func__); return ret; }