From patchwork Wed Nov 16 08:24:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 695462 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3tJckm1MZzz9t26 for ; Wed, 16 Nov 2016 19:25:04 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="RhP8a08m"; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 31200B3832; Wed, 16 Nov 2016 09:25:02 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q19TXJt4aAZ2; Wed, 16 Nov 2016 09:25:01 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 907B0A754E; Wed, 16 Nov 2016 09:25:01 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7FFE2A754E for ; Wed, 16 Nov 2016 09:24:58 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Exho58dts3sH for ; Wed, 16 Nov 2016 09:24:58 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by theia.denx.de (Postfix) with ESMTPS id 13F1DA754C for ; Wed, 16 Nov 2016 09:24:54 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id a20so8519447wme.2 for ; Wed, 16 Nov 2016 00:24:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id; bh=V7robqG93rETG94h1HEHqb9n66FWyGPRk/6kX7wW+Yc=; b=RhP8a08mYUWPgYJjStYTWvANUVHsddnHEuqVhtTAOS1l0AhnzxHHS8zYgfk5iJp8co aTzN9l1U3mBwqdwYUNfvXYzkVLZXJUsfzGckiozvQgbS+J6f8lFyT7w6O8SBrLg07yR/ WmkqdjiBFkqozARicooX4MNgXZp+1x8s4UcxUi4pRX4L3ivgEyREwynSlGv61b3rSeCp CVE9sAn7BxiIb1ArgnlxYaqxJxkHHGY3gG9GWU06ULj0k164tfFWQCfzJIfRoc4BKpdJ GTCs0AAUX0lYTz58xlC+FXi+TXcI57ZvRSCKWHOEeKfeP2Yxpz3Lpz8LvwJMrltStz+A +hdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=V7robqG93rETG94h1HEHqb9n66FWyGPRk/6kX7wW+Yc=; b=aCqBK2EABtAVI4CZo9bHH930QlXjyKnKJsYHP+7PcBGzYFvL+W4D6bmSsizpaO9AIS E//w48cFHMwncJcBT+HpcBd40MqPVkEQqSUfDlHIBrPu+TYwXFveN2WpFHYt6ywP4dm6 kmgdUeeZG+lfX722a7X7JFVssQ3LxRymSkb3+6ZYcTVuZ/mAAHDi3PsApydJX7z9Ajdm bjDdpJUK85rUlxOvQOWZmoT3/rVUTYHWuakP2kyEmLKNbXuWFD1lLj8INjQeEFzEI5Hv ZkR+6+XmSVYc01+POVal9Q5MhXX/wQzY0gmqJAfMkxgYk6YuYW2D8BCF5uLoOH2GGqlV DwtA== X-Gm-Message-State: ABUngvezB6oVWICnKWIA1PW94x8KHzZQpGJVqtISeOt5Kjl/gvIx+591CwqXbqg7JZQBEA== X-Received: by 10.194.0.43 with SMTP id 11mr993069wjb.218.1479284694215; Wed, 16 Nov 2016 00:24:54 -0800 (PST) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id w18sm8728927wme.9.2016.11.16.00.24.53 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 16 Nov 2016 00:24:53 -0800 (PST) From: Michal Simek To: u-boot@lists.denx.de Date: Wed, 16 Nov 2016 09:24:49 +0100 Message-Id: <52d0c195a77f77b0e35501f022f9d65fce83bc76.1479284686.git.michal.simek@xilinx.com> X-Mailer: git-send-email 1.9.1 Cc: Dongpo Li , Joe Hershberger , Stefan Roese Subject: [U-Boot] [RFC PATCH] common: miiphyutil: Work and report phy address in hex in mdio cmd X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" It is confusing that mdio commands work and report phy id as decimal value when mii is working with hex values. For example: ZynqMP> mdio list gem: 21 - TI DP83867 <--> ethernet@ff0e0000 ZynqMP> mdio read ethernet@ff0e0000 0 Reading from bus gem PHY at address 21: 0 - 0x1140 ZynqMP> mii dump 21 0 Incorrect PHY address. Range should be 0-31 ... ZynqMP> mii dump 15 0. (1140) -- PHY control register -- (8000:0000) 0.15 = 0 reset U-Boot normally takes hex values that's why this patch is changing mdio command to handle hex instead of changing mii command to handle decimal values. Signed-off-by: Michal Simek Reviewed-by: Simon Glass Acked-by: Joe Hershberger --- cmd/mdio.c | 6 +++--- common/miiphyutil.c | 2 +- drivers/net/zynq_gem.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cmd/mdio.c b/cmd/mdio.c index fb13d050752a..21dc103736e7 100644 --- a/cmd/mdio.c +++ b/cmd/mdio.c @@ -27,12 +27,12 @@ static uint last_reg_hi; static int extract_range(char *input, int *plo, int *phi) { char *end; - *plo = simple_strtol(input, &end, 0); + *plo = simple_strtol(input, &end, 16); if (end == input) return -1; if ((*end == '-') && *(++end)) - *phi = simple_strtol(end, NULL, 0); + *phi = simple_strtol(end, NULL, 16); else if (*end == '\0') *phi = *plo; else @@ -79,7 +79,7 @@ static int mdio_read_ranges(struct phy_device *phydev, struct mii_dev *bus, printf("Reading from bus %s\n", bus->name); for (addr = addrlo; addr <= addrhi; addr++) { - printf("PHY at address %d:\n", addr); + printf("PHY at address %x:\n", addr); for (devad = devadlo; devad <= devadhi; devad++) { for (reg = reglo; reg <= reghi; reg++) { diff --git a/common/miiphyutil.c b/common/miiphyutil.c index d8ebb384dbfa..aca18db52a00 100644 --- a/common/miiphyutil.c +++ b/common/miiphyutil.c @@ -135,7 +135,7 @@ void mdio_list_devices(void) struct phy_device *phydev = bus->phymap[i]; if (phydev) { - printf("%d - %s", i, phydev->drv->name); + printf("%x - %s", i, phydev->drv->name); if (phydev->dev) printf(" <--> %s\n", phydev->dev->name); diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c index 3319e10467d0..526eac658ac5 100644 --- a/drivers/net/zynq_gem.c +++ b/drivers/net/zynq_gem.c @@ -706,7 +706,7 @@ static int zynq_gem_ofdata_to_platdata(struct udevice *dev) priv->emio = fdtdec_get_bool(gd->fdt_blob, dev->of_offset, "xlnx,emio"); - printf("ZYNQ GEM: %lx, phyaddr %d, interface %s\n", (ulong)priv->iobase, + printf("ZYNQ GEM: %lx, phyaddr %x, interface %s\n", (ulong)priv->iobase, priv->phyaddr, phy_string_for_interface(priv->interface)); return 0;