| Message ID | 4F9888E3.3020502@samsung.com |
|---|---|
| State | Accepted |
| Delegated to: | Minkyu Kang |
| Headers | show |
Hi, On Thu, 26 Apr 2012 08:29:39 +0900 Donghwa Lee <dh09.lee@samsung.com> wrote: > panel_info data structure is gloable variable, so, I have initialized it > in board file. If it is initialized in init_panel_info() like existing, > it can't be used in drv_lcd_init() in common/lcd.c because > init_panel_info() is called after drv_lcd_init(). > > change of v1: > - I had made a mistake that must do not included variables of vidinfo_t > data structure was included in the file. So, I removed it. > > Signed-off-by: Donghwa Lee <dh09.lee@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > board/samsung/trats/trats.c | 71 ++++++++++++++++++++++--------------------- > drivers/video/exynos_fb.c | 3 -- > 2 files changed, 36 insertions(+), 38 deletions(-) Acked-by: Anatolij Gustschin <agust@denx.de> This patch should also go through u-boot-samsung tree. Thanks, Anatolij
On 26 April 2012 16:59, Anatolij Gustschin <agust@denx.de> wrote: > Hi, > > On Thu, 26 Apr 2012 08:29:39 +0900 > Donghwa Lee <dh09.lee@samsung.com> wrote: > >> panel_info data structure is gloable variable, so, I have initialized it >> in board file. If it is initialized in init_panel_info() like existing, >> it can't be used in drv_lcd_init() in common/lcd.c because >> init_panel_info() is called after drv_lcd_init(). >> >> change of v1: >> - I had made a mistake that must do not included variables of vidinfo_t >> data structure was included in the file. So, I removed it. >> >> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> board/samsung/trats/trats.c | 71 ++++++++++++++++++++++--------------------- >> drivers/video/exynos_fb.c | 3 -- >> 2 files changed, 36 insertions(+), 38 deletions(-) > > Acked-by: Anatolij Gustschin <agust@denx.de> > applied to u-boot-samsung. Thanks. Minkyu Kang.
diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c index 3085de1..084b67a 100644 --- a/board/samsung/trats/trats.c +++ b/board/samsung/trats/trats.c @@ -455,43 +455,44 @@ static int mipi_power(void) return 0; } +vidinfo_t panel_info = { + .vl_freq = 60, + .vl_col = 720, + .vl_row = 1280, + .vl_width = 720, + .vl_height = 1280, + .vl_clkp = CONFIG_SYS_HIGH, + .vl_hsp = CONFIG_SYS_LOW, + .vl_vsp = CONFIG_SYS_LOW, + .vl_dp = CONFIG_SYS_LOW, + .vl_bpix = 5, /* Bits per pixel, 2^5 = 32 */ + + /* s6e8ax0 Panel infomation */ + .vl_hspw = 5, + .vl_hbpd = 10, + .vl_hfpd = 10, + + .vl_vspw = 2, + .vl_vbpd = 1, + .vl_vfpd = 13, + .vl_cmd_allow_len = 0xf, + + .win_id = 3, + .cfg_gpio = NULL, + .backlight_on = NULL, + .lcd_power_on = NULL, /* lcd_power_on in mipi dsi driver */ + .reset_lcd = lcd_reset, + .dual_lcd_enabled = 0, + + .init_delay = 0, + .power_on_delay = 0, + .reset_delay = 0, + .interface_mode = FIMD_RGB_INTERFACE, + .mipi_enabled = 1, +}; + void init_panel_info(vidinfo_t *vid) { - vid->vl_freq = 60; - vid->vl_col = 720; - vid->vl_row = 1280; - vid->vl_width = 720; - vid->vl_height = 1280; - vid->vl_clkp = CONFIG_SYS_HIGH; - vid->vl_hsp = CONFIG_SYS_LOW; - vid->vl_vsp = CONFIG_SYS_LOW; - vid->vl_dp = CONFIG_SYS_LOW; - - vid->vl_bpix = 5; - vid->dual_lcd_enabled = 0; - - /* s6e8ax0 Panel */ - vid->vl_hspw = 5; - vid->vl_hbpd = 10; - vid->vl_hfpd = 10; - - vid->vl_vspw = 2; - vid->vl_vbpd = 1; - vid->vl_vfpd = 13; - vid->vl_cmd_allow_len = 0xf; - - vid->win_id = 3; - vid->cfg_gpio = NULL; - vid->backlight_on = NULL; - vid->lcd_power_on = NULL; /* lcd_power_on in mipi dsi driver */ - vid->reset_lcd = lcd_reset; - - vid->init_delay = 0; - vid->power_on_delay = 0; - vid->reset_delay = 0; - vid->interface_mode = FIMD_RGB_INTERFACE; - vid->mipi_enabled = 1; - strcpy(s6e8ax0_platform_data.lcd_panel_name, mipi_lcd_device.name); s6e8ax0_platform_data.lcd_power = lcd_power; s6e8ax0_platform_data.mipi_power = mipi_power; diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c index a1cf449..96a8ec1 100644 --- a/drivers/video/exynos_fb.c +++ b/drivers/video/exynos_fb.c @@ -44,9 +44,6 @@ short console_row; static unsigned int panel_width, panel_height; -/* LCD Panel data */ -vidinfo_t panel_info; - static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid) { unsigned long palette_size;