From patchwork Thu Feb 24 23:16:44 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bob Feretich X-Patchwork-Id: 84497 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 2951AB7080 for ; Fri, 25 Feb 2011 10:22:23 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id EB579282EE; Fri, 25 Feb 2011 00:22:18 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s1sk+VJs7hTE; Fri, 25 Feb 2011 00:22:18 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 8B941282E6; Fri, 25 Feb 2011 00:22:16 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id EEE4E282E6 for ; Fri, 25 Feb 2011 00:22:13 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KNvZKD5ENeIE for ; Fri, 25 Feb 2011 00:22:12 +0100 (CET) X-Greylist: delayed 321 seconds by postgrey-1.27 at theia; Fri, 25 Feb 2011 00:22:11 CET X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from nm17-vm0.bullet.mail.ne1.yahoo.com (nm17-vm0.bullet.mail.ne1.yahoo.com [98.138.91.58]) by theia.denx.de (Postfix) with SMTP id EE70F282B2 for ; Fri, 25 Feb 2011 00:22:10 +0100 (CET) Received: from [98.138.90.56] by nm17.bullet.mail.ne1.yahoo.com with NNFMP; 24 Feb 2011 23:16:48 -0000 Received: from [98.138.87.5] by tm9.bullet.mail.ne1.yahoo.com with NNFMP; 24 Feb 2011 23:16:48 -0000 Received: from [127.0.0.1] by omp1005.mail.ne1.yahoo.com with NNFMP; 24 Feb 2011 23:16:48 -0000 X-Yahoo-Newman-Id: 757661.93211.bm@omp1005.mail.ne1.yahoo.com Received: (qmail 86420 invoked from network); 24 Feb 2011 23:16:48 -0000 Received: from [192.168.1.101] (bob.feretich@71.131.9.193 with plain) by smtp105.sbc.mail.ne1.yahoo.com with SMTP; 24 Feb 2011 15:16:45 -0800 PST X-Yahoo-SMTP: jHZ71LyswBA8vPppSFebFmPnYvk1gIPKrFjcBqA_GiVlfXPeew-- X-YMail-OSG: iuuXIFIVM1mtkovvp27BvvopFhgRSMaf_xjTbAxiDt73gqK TeaOdX_AkK6XtsZymkTXjmKxT2Bvi7HmUOCOxtureL1KxpddfeTbbYXUMK1. hGLkexj6CW.lztfShnujNxF__fNI5xWmClqMp4GUyzxRKNc_BRpNvGCabDds C8B5yj1IeRO.1d0Xjz9Ade2w4N2QP8aVihoNvbn8brmmShdBeQeLShUVBaxk KzAwhW2KrNdTmtbiSVrkxxhHjNhVf2Ge5QJ6sRNKW_6I.a_sVJn281R.g37Z rO0HYreShNA-- X-Yahoo-Newman-Property: ymail-3 Message-ID: <4D66E6DC.8070604@rafresearch.com> Date: Thu, 24 Feb 2011 15:16:44 -0800 From: Bob Feretich User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: "u-boot@lists.denx.de" Subject: [U-Boot] [PATCH] OMAP3 Beagle Pin Mux initialization glitch fix X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de The below patch reverses the order of two segments in the board file. Output pins need to have their values initialized, before they are exposed to the logic outside the chip. Signed-off-by: Bob Feretich Cc: Wolfgang Denk --- -- diff --git a/board/ti/beagle/beagle.c b/board/ti/beagle/beagle.c --- a/board/ti/beagle/beagle.c 2011-02-23 17:26:27.000000000 -0800 +++ b/board/ti/beagle/beagle.c 2011-02-23 17:47:44.000000000 -0800 @@ -239,17 +239,17 @@ int misc_init_r(void) twl4030_power_init(); twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON); - /* Configure GPIOs to output */ - writel(~(GPIO23 | GPIO10 | GPIO8 | GPIO2 | GPIO1), &gpio6_base->oe); - writel(~(GPIO31 | GPIO30 | GPIO29 | GPIO28 | GPIO22 | GPIO21 | - GPIO15 | GPIO14 | GPIO13 | GPIO12), &gpio5_base->oe); - - /* Set GPIOs */ + /* Set GPIO states before they are made outputs */ writel(GPIO23 | GPIO10 | GPIO8 | GPIO2 | GPIO1, &gpio6_base->setdataout); writel(GPIO31 | GPIO30 | GPIO29 | GPIO28 | GPIO22 | GPIO21 | GPIO15 | GPIO14 | GPIO13 | GPIO12, &gpio5_base->setdataout); + /* Configure GPIOs to output */ + writel(~(GPIO23 | GPIO10 | GPIO8 | GPIO2 | GPIO1), &gpio6_base->oe); + writel(~(GPIO31 | GPIO30 | GPIO29 | GPIO28 | GPIO22 | GPIO21 | + GPIO15 | GPIO14 | GPIO13 | GPIO12), &gpio5_base->oe); + dieid_num_r(); return 0;