| Message ID | 4D33C078.3090503@renesas.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Mon, Jan 17, 2011 at 01:07:20PM +0900, Yoshihiro Shimoda wrote: > Fix the problem which cannot build the U-boot, if we only set > the CONFIG_ENV_IS_IN_SPI_FLASH. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Acked-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> > --- > include/environment.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/environment.h b/include/environment.h > index 082b3e1..8a4f393 100644 > --- a/include/environment.h > +++ b/include/environment.h > @@ -106,6 +106,7 @@ extern unsigned long nand_env_oob_offset; > /* Embedded env is only supported for some flash types */ > #ifdef CONFIG_ENV_IS_EMBEDDED > # if !defined(CONFIG_ENV_IS_IN_FLASH) && \ > + !defined(CONFIG_ENV_IS_IN_SPI_FLASH) && \ > !defined(CONFIG_ENV_IS_IN_NAND) && \ > !defined(CONFIG_ENV_IS_IN_ONENAND) > # error "CONFIG_ENV_IS_EMBEDDED not supported for your flash type" > -- > 1.7.1 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
Dear Yoshihiro Shimoda, In message <4D33C078.3090503@renesas.com> you wrote: > Fix the problem which cannot build the U-boot, if we only set > the CONFIG_ENV_IS_IN_SPI_FLASH. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > include/environment.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/environment.h b/include/environment.h > index 082b3e1..8a4f393 100644 > --- a/include/environment.h > +++ b/include/environment.h > @@ -106,6 +106,7 @@ extern unsigned long nand_env_oob_offset; > /* Embedded env is only supported for some flash types */ > #ifdef CONFIG_ENV_IS_EMBEDDED > # if !defined(CONFIG_ENV_IS_IN_FLASH) && \ > + !defined(CONFIG_ENV_IS_IN_SPI_FLASH) && \ > !defined(CONFIG_ENV_IS_IN_NAND) && \ > !defined(CONFIG_ENV_IS_IN_ONENAND) Please keep list sorted. Best regards, Wolfgang Denk
Dear Wolfgang Denk, 2011/01/18 18:29, Wolfgang Denk wrote: > Dear Yoshihiro Shimoda, > >> /* Embedded env is only supported for some flash types */ >> #ifdef CONFIG_ENV_IS_EMBEDDED >> # if !defined(CONFIG_ENV_IS_IN_FLASH) && \ >> + !defined(CONFIG_ENV_IS_IN_SPI_FLASH) && \ >> !defined(CONFIG_ENV_IS_IN_NAND) && \ >> !defined(CONFIG_ENV_IS_IN_ONENAND) > > Please keep list sorted. Oh, I didn't realize that is sorted by alphabet. I will fix it. Best regards, Yoshihiro Shimoda
diff --git a/include/environment.h b/include/environment.h index 082b3e1..8a4f393 100644 --- a/include/environment.h +++ b/include/environment.h @@ -106,6 +106,7 @@ extern unsigned long nand_env_oob_offset; /* Embedded env is only supported for some flash types */ #ifdef CONFIG_ENV_IS_EMBEDDED # if !defined(CONFIG_ENV_IS_IN_FLASH) && \ + !defined(CONFIG_ENV_IS_IN_SPI_FLASH) && \ !defined(CONFIG_ENV_IS_IN_NAND) && \ !defined(CONFIG_ENV_IS_IN_ONENAND) # error "CONFIG_ENV_IS_EMBEDDED not supported for your flash type"
Fix the problem which cannot build the U-boot, if we only set the CONFIG_ENV_IS_IN_SPI_FLASH. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- include/environment.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)