[U-Boot,v5,1/1] tegra: usb: Fix device enumeration problem of USB1

A known hardware issue of USB1 port where bit 1 (connect status
change) of PORTSC register will be set after issuing Port Reset
(like "usb reset" in u-boot command line).
This will be treated as an error and stops later device enumeration.

Therefore we clear that bit after Port Reset in order to proceed
later device enumeration.

Signed-off-by: Jim Lin <jilin@nvidia.com>
---
To reproduce this issue, you can modify board .dts file to set
as the following to build u-boot binary.
"
 usb0 = "/usb@c5000000";
 usb1 = "/usb@c5008000";
"
Install device on USB1 port (address at 0xc5000000).
And run "usb reset" in u-boot console to enumerate device.

Before adding this patch, we could see problem every time.
After adding, tried 10 times of "usb reset", "usb tree", "usb stop"
, without seeing issue.

Changes in v5:
- Define USB address mask value in header file

Changes in v4:
- Add comment to describe replacing weak function ehci_powerup_fixup of ehci-hcd.c
- Remove using variable my_reg

Changes in v3:
- Move patch for USB1 controller into ehci_powerup_fixup of ehci-tegra.c
- Update copyright year to 2012

Changes in v2:
- Change config name
- Add a callback function at the end of ehci_submit_root() function

 arch/arm/include/asm/arch-tegra2/tegra2.h |    1 +
 drivers/usb/host/ehci-tegra.c             |   18 +++++++++++++++++-
 2 files changed, 18 insertions(+), 1 deletions(-)

On 06/25/2012 12:40 AM, Jim Lin wrote:
> A known hardware issue of USB1 port where bit 1 (connect status
> change) of PORTSC register will be set after issuing Port Reset
> (like "usb reset" in u-boot command line).
> This will be treated as an error and stops later device enumeration.
> 
> Therefore we clear that bit after Port Reset in order to proceed
> later device enumeration.
> 
> Signed-off-by: Jim Lin <jilin@nvidia.com>

Acked-by: Stephen Warren <swarren@wwwdotorg.org>

Dear Stephen Warren,

> On 06/25/2012 12:40 AM, Jim Lin wrote:
> > A known hardware issue of USB1 port where bit 1 (connect status
> > change) of PORTSC register will be set after issuing Port Reset
> > (like "usb reset" in u-boot command line).
> > This will be treated as an error and stops later device enumeration.
> > 
> > Therefore we clear that bit after Port Reset in order to proceed
> > later device enumeration.
> > 
> > Signed-off-by: Jim Lin <jilin@nvidia.com>
> 
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>

Ok, it's icky nvidia stuff :-)

Will you apply it? I'm good with the current shape.

Best regards,
Marek Vasut

Dear Tom Warren,

> Marek,
> 
> > -----Original Message-----
> > From: Marek Vasut [mailto:marek.vasut@gmail.com]
> > Sent: Monday, June 25, 2012 4:48 PM
> > To: Stephen Warren
> > Cc: Jim Lin; 'u-boot@lists.denx.de'; Tom Warren
> > Subject: Re: [PATCH v5 1/1] tegra: usb: Fix device enumeration problem of
> > USB1
> > 
> > Dear Stephen Warren,
> > 
> > > On 06/25/2012 12:40 AM, Jim Lin wrote:
> > > > A known hardware issue of USB1 port where bit 1 (connect status
> > > > change) of PORTSC register will be set after issuing Port Reset
> > > > (like "usb reset" in u-boot command line).
> > > > This will be treated as an error and stops later device enumeration.
> > > > 
> > > > Therefore we clear that bit after Port Reset in order to proceed
> > > > later device enumeration.
> > > > 
> > > > Signed-off-by: Jim Lin <jilin@nvidia.com>
> > > 
> > > Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> > 
> > Ok, it's icky nvidia stuff :-)
> > 
> > Will you apply it? I'm good with the current shape.
> 
> This will be applied to u-boot-tegra/next as soon as I'm done validating
> Allen's SPL changes.

Good, I'm sure I'm leaving it in good hands :)

Thanks Tom!

> Tom
> 
> > Best regards,
> > Marek Vasut

Best regards,
Marek Vasut