| Message ID | 42ed58b2695efc29f5a63a6c57d0d1095e429207.1542886932.git.baruch@tkos.co.il |
|---|---|
| State | Accepted |
| Commit | 4825380539b72fd6f20e2d3f1ed2bda389b4ef91 |
| Delegated to: | Stefan Roese |
| Headers | show |
| Series | [U-Boot] configs: mcbin: enable network driver | expand |
On 22.11.18 12:42, Baruch Siach wrote: > Enable the mvpp2 Ethernet driver and the Marvell Ethernet PHY driver. > This makes the Macchiatobin 1Gb Ethernet interface usable. > > Cc: Konstantin Porotchkin <kostap@marvell.com> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > configs/mvebu_mcbin-88f8040_defconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/configs/mvebu_mcbin-88f8040_defconfig b/configs/mvebu_mcbin-88f8040_defconfig > index 44436bc2a941..9df4c51c6f18 100644 > --- a/configs/mvebu_mcbin-88f8040_defconfig > +++ b/configs/mvebu_mcbin-88f8040_defconfig > @@ -5,7 +5,6 @@ CONFIG_SYS_MALLOC_F_LEN=0x2000 > CONFIG_TARGET_MVEBU_ARMADA_8K=y > CONFIG_DEBUG_UART_BASE=0xf0512000 > CONFIG_DEBUG_UART_CLOCK=200000000 > -CONFIG_SMBIOS_PRODUCT_NAME="" > CONFIG_DEBUG_UART=y > CONFIG_AHCI=y > CONFIG_DISTRO_DEFAULTS=y > @@ -35,6 +34,7 @@ CONFIG_CMD_EXT4_WRITE=y > CONFIG_MAC_PARTITION=y > CONFIG_DEFAULT_DEVICE_TREE="armada-8040-mcbin" > CONFIG_ENV_IS_IN_SPI_FLASH=y > +CONFIG_NET_RANDOM_ETHADDR=y > CONFIG_AHCI_MVEBU=y > CONFIG_DM_GPIO=y > CONFIG_DM_I2C=y > @@ -48,8 +48,9 @@ CONFIG_SPI_FLASH_MACRONIX=y > CONFIG_SPI_FLASH_SPANSION=y > CONFIG_SPI_FLASH_STMICRO=y > CONFIG_SPI_FLASH_WINBOND=y > -CONFIG_PHYLIB=y > +CONFIG_PHY_MARVELL=y > CONFIG_PHY_GIGE=y > +CONFIG_MVPP2=y > CONFIG_PCI=y > CONFIG_DM_PCI=y > CONFIG_PCIE_DW_MVEBU=y > @@ -72,4 +73,3 @@ CONFIG_USB_ETHER_ASIX=y > CONFIG_USB_ETHER_MCS7830=y > CONFIG_USB_ETHER_RTL8152=y > CONFIG_USB_ETHER_SMSC95XX=y > -CONFIG_SMBIOS_MANUFACTURER="" > Viele Grüße, Stefan
On 29.11.18 14:12, Stefan Roese wrote: > On 22.11.18 12:42, Baruch Siach wrote: >> Enable the mvpp2 Ethernet driver and the Marvell Ethernet PHY driver. >> This makes the Macchiatobin 1Gb Ethernet interface usable. >> >> Cc: Konstantin Porotchkin <kostap@marvell.com> >> Signed-off-by: Baruch Siach <baruch@tkos.co.il> > > Reviewed-by: Stefan Roese <sr@denx.de> BTW: Could you please change your patch subject for all those patches to reflect the architecture. Something like this: configs: mcbin: enable network driver -> arm: mvebu: configs: mcbin: enable network driver Thanks, Stefan > Thanks, > Stefan > >> --- >> configs/mvebu_mcbin-88f8040_defconfig | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/configs/mvebu_mcbin-88f8040_defconfig b/configs/mvebu_mcbin-88f8040_defconfig >> index 44436bc2a941..9df4c51c6f18 100644 >> --- a/configs/mvebu_mcbin-88f8040_defconfig >> +++ b/configs/mvebu_mcbin-88f8040_defconfig >> @@ -5,7 +5,6 @@ CONFIG_SYS_MALLOC_F_LEN=0x2000 >> CONFIG_TARGET_MVEBU_ARMADA_8K=y >> CONFIG_DEBUG_UART_BASE=0xf0512000 >> CONFIG_DEBUG_UART_CLOCK=200000000 >> -CONFIG_SMBIOS_PRODUCT_NAME="" >> CONFIG_DEBUG_UART=y >> CONFIG_AHCI=y >> CONFIG_DISTRO_DEFAULTS=y >> @@ -35,6 +34,7 @@ CONFIG_CMD_EXT4_WRITE=y >> CONFIG_MAC_PARTITION=y >> CONFIG_DEFAULT_DEVICE_TREE="armada-8040-mcbin" >> CONFIG_ENV_IS_IN_SPI_FLASH=y >> +CONFIG_NET_RANDOM_ETHADDR=y >> CONFIG_AHCI_MVEBU=y >> CONFIG_DM_GPIO=y >> CONFIG_DM_I2C=y >> @@ -48,8 +48,9 @@ CONFIG_SPI_FLASH_MACRONIX=y >> CONFIG_SPI_FLASH_SPANSION=y >> CONFIG_SPI_FLASH_STMICRO=y >> CONFIG_SPI_FLASH_WINBOND=y >> -CONFIG_PHYLIB=y >> +CONFIG_PHY_MARVELL=y >> CONFIG_PHY_GIGE=y >> +CONFIG_MVPP2=y >> CONFIG_PCI=y >> CONFIG_DM_PCI=y >> CONFIG_PCIE_DW_MVEBU=y >> @@ -72,4 +73,3 @@ CONFIG_USB_ETHER_ASIX=y >> CONFIG_USB_ETHER_MCS7830=y >> CONFIG_USB_ETHER_RTL8152=y >> CONFIG_USB_ETHER_SMSC95XX=y >> -CONFIG_SMBIOS_MANUFACTURER="" >> > > Viele Grüße, > Stefan > Viele Grüße, Stefan
Hi Stefan, Stefan Roese writes: > On 29.11.18 14:12, Stefan Roese wrote: >> On 22.11.18 12:42, Baruch Siach wrote: >>> Enable the mvpp2 Ethernet driver and the Marvell Ethernet PHY driver. >>> This makes the Macchiatobin 1Gb Ethernet interface usable. >>> >>> Cc: Konstantin Porotchkin <kostap@marvell.com> >>> Signed-off-by: Baruch Siach <baruch@tkos.co.il> >> >> Reviewed-by: Stefan Roese <sr@denx.de> > > BTW: Could you please change your patch subject for all those patches > to reflect the architecture. Something like this: > > configs: mcbin: enable network driver > -> > arm: mvebu: configs: mcbin: enable network driver No problem. Should I resend this patch with that change? baruch
Hi Baruch, On 29.11.18 18:11, Baruch Siach wrote: > Hi Stefan, > > Stefan Roese writes: >> On 29.11.18 14:12, Stefan Roese wrote: >>> On 22.11.18 12:42, Baruch Siach wrote: >>>> Enable the mvpp2 Ethernet driver and the Marvell Ethernet PHY driver. >>>> This makes the Macchiatobin 1Gb Ethernet interface usable. >>>> >>>> Cc: Konstantin Porotchkin <kostap@marvell.com> >>>> Signed-off-by: Baruch Siach <baruch@tkos.co.il> >>> >>> Reviewed-by: Stefan Roese <sr@denx.de> >> >> BTW: Could you please change your patch subject for all those patches >> to reflect the architecture. Something like this: >> >> configs: mcbin: enable network driver >> -> >> arm: mvebu: configs: mcbin: enable network driver > > No problem. Should I resend this patch with that change? No, that's not necessary. But please do so for future patches. Thanks, Stefan
On 22.11.18 12:42, Baruch Siach wrote: > Enable the mvpp2 Ethernet driver and the Marvell Ethernet PHY driver. > This makes the Macchiatobin 1Gb Ethernet interface usable. > > Cc: Konstantin Porotchkin <kostap@marvell.com> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> Applied to u-boot-marvell/master. Thanks, Stefan
diff --git a/configs/mvebu_mcbin-88f8040_defconfig b/configs/mvebu_mcbin-88f8040_defconfig index 44436bc2a941..9df4c51c6f18 100644 --- a/configs/mvebu_mcbin-88f8040_defconfig +++ b/configs/mvebu_mcbin-88f8040_defconfig @@ -5,7 +5,6 @@ CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_TARGET_MVEBU_ARMADA_8K=y CONFIG_DEBUG_UART_BASE=0xf0512000 CONFIG_DEBUG_UART_CLOCK=200000000 -CONFIG_SMBIOS_PRODUCT_NAME="" CONFIG_DEBUG_UART=y CONFIG_AHCI=y CONFIG_DISTRO_DEFAULTS=y @@ -35,6 +34,7 @@ CONFIG_CMD_EXT4_WRITE=y CONFIG_MAC_PARTITION=y CONFIG_DEFAULT_DEVICE_TREE="armada-8040-mcbin" CONFIG_ENV_IS_IN_SPI_FLASH=y +CONFIG_NET_RANDOM_ETHADDR=y CONFIG_AHCI_MVEBU=y CONFIG_DM_GPIO=y CONFIG_DM_I2C=y @@ -48,8 +48,9 @@ CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_WINBOND=y -CONFIG_PHYLIB=y +CONFIG_PHY_MARVELL=y CONFIG_PHY_GIGE=y +CONFIG_MVPP2=y CONFIG_PCI=y CONFIG_DM_PCI=y CONFIG_PCIE_DW_MVEBU=y @@ -72,4 +73,3 @@ CONFIG_USB_ETHER_ASIX=y CONFIG_USB_ETHER_MCS7830=y CONFIG_USB_ETHER_RTL8152=y CONFIG_USB_ETHER_SMSC95XX=y -CONFIG_SMBIOS_MANUFACTURER=""
Enable the mvpp2 Ethernet driver and the Marvell Ethernet PHY driver. This makes the Macchiatobin 1Gb Ethernet interface usable. Cc: Konstantin Porotchkin <kostap@marvell.com> Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- configs/mvebu_mcbin-88f8040_defconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)