From patchwork Wed Nov 16 16:37:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 695686 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3tJqgQ4pkZz9t0m for ; Thu, 17 Nov 2016 03:37:54 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="Yytj5bs7"; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 885084BA81; Wed, 16 Nov 2016 17:37:52 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PJThg5HZTy9P; Wed, 16 Nov 2016 17:37:52 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E1C474B9F9; Wed, 16 Nov 2016 17:37:51 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 5A81A4B9F9 for ; Wed, 16 Nov 2016 17:37:48 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s9VyiV7cOJqz for ; Wed, 16 Nov 2016 17:37:48 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by theia.denx.de (Postfix) with ESMTPS id 1802B4B99D for ; Wed, 16 Nov 2016 17:37:44 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id g23so12920947wme.1 for ; Wed, 16 Nov 2016 08:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id; bh=ms41DQKqiBROLy9C4YY9Voro0rfzOw4Lo1W154i+7hA=; b=Yytj5bs7p0MDVU4GdaZbAb02qJ7dSL3rk18XPda5HTc6AmRiQidGABenAcS518SGZx esWRY25EWgOMDspNxjmI7rv6bxPVVmrAi9sTe9LaARnTC3FDy8WSGebsDEFmrJbQiRFk c7oAshl6uFqrQzr6M3KTFdkJ3vB+c6TTPLdqfyLxkXRbFjrAgJqvcdAS2QknUeocsQRc IK7VZKlQqBtEoc6dLXYujXY5IaMRgdAm1licnAEzPWFRpZXY0EzKp4khvmSI9Jt02DKc 5C/6wl053HJZVrzs6rImh54yMJDVd0QvA48evqqoT0T6rBfQTH9A1ywdVBP8HXvspIPw BJqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=ms41DQKqiBROLy9C4YY9Voro0rfzOw4Lo1W154i+7hA=; b=ZsgktCkbHWES4rA7tbR3FYThz30fljfZxMNLi/SUOuP39+5V6mzBkEiMm+HbfDtsSo KmOaSpZFj6HtM+2Ni5gXkkL1nry9witsPVQt0ybl8V0/C7nB3vzzo9wdmZef9IJDjk8i AL3yDOaMN+T1jqRsWUUuGLlxJlO1/lZOEeGXxK7fYokiMFyBdzH7uGGmFPbcXyihEJof Xecwt53tlqWL9N+LH0/nrAAp6+bLyngiHAyOYZMMNky1nXWpii1evXqj9fweTeUGXNl5 NWdmUs+0ycaSz03y85IMypVOvN3nv0tMf+7ZrdQh01Fs5o5fSnmLUGN7h6+fxGg3BHXw ztww== X-Gm-Message-State: ABUngvd9/mRjUhD0TUbv1BNAafjVvbIZDCKSlVCmncZfv802UF6jjV9dWT2Eh5V+e/W2ew== X-Received: by 10.28.17.213 with SMTP id 204mr10950279wmr.17.1479314264512; Wed, 16 Nov 2016 08:37:44 -0800 (PST) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id w18sm11010957wme.9.2016.11.16.08.37.43 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 16 Nov 2016 08:37:43 -0800 (PST) From: Michal Simek To: Simon Glass Date: Wed, 16 Nov 2016 17:37:42 +0100 Message-Id: <3d9a8f74adcbe97551f405902bfde551522f3ba3.1479314260.git.michal.simek@xilinx.com> X-Mailer: git-send-email 1.9.1 Cc: u-boot@lists.denx.de Subject: [U-Boot] [PATCH] dm: blk: Fix get_desc to return block device descriptor X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Current get_desc() implementation is not able to succesfully finish and return pointer to block device descriptor. Also function always return non zero value even device is found. The patch fills block device descriptor and return 0 if device is found. Signed-off-by: Michal Simek Reviewed-by: Simon Glass --- I have tested it with blk scsi which I am reworking after first RFC. With this patch I can run scsi part, scsi info, scsi read (I didn't test write not to break my HDD). --- drivers/block/blk-uclass.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c index 6ba1026f5818..2e041c2b3dc7 100644 --- a/drivers/block/blk-uclass.c +++ b/drivers/block/blk-uclass.c @@ -156,6 +156,8 @@ static int get_desc(enum if_type if_type, int devnum, struct blk_desc **descp) if (ret) return ret; + *descp = desc; + return 0; } else if (desc->devnum > devnum) { found_more = true; }