From patchwork Fri Sep 27 13:34:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 1168513 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="kbrZ+xxp"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46ftBF56Jkz9sDB for ; Fri, 27 Sep 2019 23:36:53 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 4A791C21FBE; Fri, 27 Sep 2019 13:35:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id EB243C21FBA; Fri, 27 Sep 2019 13:35:25 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id A247FC21F0F; Fri, 27 Sep 2019 13:35:15 +0000 (UTC) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by lists.denx.de (Postfix) with ESMTPS id EEED5C21F19 for ; Fri, 27 Sep 2019 13:35:12 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id n14so2755472wrw.9 for ; Fri, 27 Sep 2019 06:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=eVmBgRVkbPVeFU+RMQb7Fq89NSklUnrWR8PwPKZFOV8=; b=kbrZ+xxp1m04aI5atQof99ojBqBHyS4EXiUGuW0Pmk/4U8RRESqK3695h4S7Eb1Ku0 BYWgake+wLMNjwhyXMrD3a6Jk2iMFfv5pIBKUfBU70x58yLDFR2z1mgsMW2XjBwnbkoN cuRPWALg/tO4v0HjESZgZ8zSqRZdpyW+nOb3/wqg1SbIItDAy47hE8Jk+iYb5h9SWsb4 tpJGm1B4mFl2lj76KItnZhrl54dI1jHsi7h2GvVicePKXKlIy9areO35i6x3h6aXLl+j DpdN7pjBHIp5zWJelH7x06BMHFCOADZQD+NZ20MvM0H95dBoni+qqDDU9g321l1V3MEg xzOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=eVmBgRVkbPVeFU+RMQb7Fq89NSklUnrWR8PwPKZFOV8=; b=RQZ2o7cgSZbVESxXdtCvYfe2wxpUeOOOJ907F1AjUZp5QvUB1QMbNDDN5xTeqf451F aoB/mv5zHm2RXnzV1eaYPYw1ZXLlNObTp6p2wFE1rNh+UtLprgUFnweyRu/NZQ12NmMI qGABHHfiYjegwpkLc3UImjET8kJwh6SI8yrRNerIbbgtu/6UenRAgs0km6b5M5t7T4Vr cVIl1xVGNUJyZt5lkzF0q9tPjxuiATB3FKWiI27FRh5zXpiZoXwmptkGL1GcTBJPYadb s+CcdpCfERL98BT86SGkUP41IYnKH2CP+a9k+kIfkmI7uGYAxMbaq1OMLy9MA1ia8kR/ v5MQ== X-Gm-Message-State: APjAAAVYesry3yeIwKvR3YDVYsqCWRjj1MSXgYrJtke0EkDxS+Pd//Dc khdP6ulDZCff/cMwfUsoG67suSdiPpzeNg== X-Google-Smtp-Source: APXvYqxxKlmW78hUx/BnsLXz9mhZDGduBo8waRl44zXbjEuWLL4NCV+YvCbie1F+ud3Zgfk/J2l4Mw== X-Received: by 2002:adf:f1d1:: with SMTP id z17mr2945899wro.330.1569591312303; Fri, 27 Sep 2019 06:35:12 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id x6sm7829533wmf.35.2019.09.27.06.35.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Sep 2019 06:35:11 -0700 (PDT) From: Michal Simek To: u-boot@lists.denx.de, git@xilinx.com Date: Fri, 27 Sep 2019 15:34:52 +0200 Message-Id: <300f8ca074d22481ec299ddfa29c23887148633e.1569591296.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Cc: ibai.erkiaga-elorza@xilinx.com, luca@lucaceresoli.net Subject: [U-Boot] [PATCH 01/13] mailbox: check ops prior calling X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Ibai Erkiaga Check if request and free operations are present prior calling to the functions. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- drivers/mailbox/mailbox-uclass.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/mailbox-uclass.c b/drivers/mailbox/mailbox-uclass.c index 1b4a5863c9e5..809f26b20258 100644 --- a/drivers/mailbox/mailbox-uclass.c +++ b/drivers/mailbox/mailbox-uclass.c @@ -63,7 +63,8 @@ int mbox_get_by_index(struct udevice *dev, int index, struct mbox_chan *chan) return ret; } - ret = ops->request(chan); + if (ops->request) + ret = ops->request(chan); if (ret) { debug("ops->request() failed: %d\n", ret); return ret; @@ -94,7 +95,10 @@ int mbox_free(struct mbox_chan *chan) debug("%s(chan=%p)\n", __func__, chan); - return ops->free(chan); + if (ops->free) + return ops->free(chan); + + return 0; } int mbox_send(struct mbox_chan *chan, const void *data)