From patchwork Fri Aug 26 05:01:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lokesh Vutla X-Patchwork-Id: 662991 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3sL86X6J87z9sBR for ; Fri, 26 Aug 2016 15:02:12 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id AED574B979; Fri, 26 Aug 2016 07:02:10 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zeq-GcvqSwdD; Fri, 26 Aug 2016 07:02:10 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1F1634B77D; Fri, 26 Aug 2016 07:02:10 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A6F264B77D for ; Fri, 26 Aug 2016 07:02:06 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rmb8PB9hKjh3 for ; Fri, 26 Aug 2016 07:02:06 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by theia.denx.de (Postfix) with ESMTPS id 33B2C4B71E for ; Fri, 26 Aug 2016 07:02:02 +0200 (CEST) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id u7Q51mhe032593; Fri, 26 Aug 2016 00:01:49 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id u7Q51iAI009332; Fri, 26 Aug 2016 00:01:47 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.294.0; Fri, 26 Aug 2016 00:01:45 -0500 Received: from [172.24.190.53] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id u7Q51cOs001880; Fri, 26 Aug 2016 00:01:39 -0500 To: "Andrew F. Davis" , Heiko Schocher , Gilles Gameiro , Daniel Allred , Madan Srinivas , Simon Glass , Enric Balletbo i Serra , Hannes Schmelzer , Tom Rini , Tero Kristo References: <20160825214541.22896-1-afd@ti.com> <20160825214541.22896-9-afd@ti.com> From: Lokesh Vutla Message-ID: <26739b1f-3e5e-adf7-c4eb-0e59241be376@ti.com> Date: Fri, 26 Aug 2016 10:31:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160825214541.22896-9-afd@ti.com> Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH v3 08/11] am335x: configs: Use ISW_ENTRY_ADDR to set SPL_TEXT_BASE X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" On Friday 26 August 2016 03:15 AM, Andrew F. Davis wrote: > The SPL load address changes based on boot time in HS devices, > ISW_ENTRY_ADDR is used to set this address for AM43xx based SoCs > for similar reasons. Add this same logic for AM33xx devices. > > Signed-off-by: Andrew F. Davis > --- > include/configs/ti_am335x_common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/configs/ti_am335x_common.h b/include/configs/ti_am335x_common.h > index a0a60d4..52f4ed6 100644 > --- a/include/configs/ti_am335x_common.h > +++ b/include/configs/ti_am335x_common.h > @@ -57,7 +57,7 @@ > * supports X-MODEM loading via UART, and we leverage this and then use > * Y-MODEM to load u-boot.img, when booted over UART. > */ > -#define CONFIG_SPL_TEXT_BASE 0x402F0400 > +#define CONFIG_SPL_TEXT_BASE CONFIG_ISW_ENTRY_ADDR Please include the below change as well or else am33xx gp boot might break as fefault address is different. Thanks and regards, Lokesh > #define CONFIG_SPL_MAX_SIZE (0x4030B800 - CONFIG_SPL_TEXT_BASE) > #define CONFIG_SYS_SPL_ARGS_ADDR (CONFIG_SYS_SDRAM_BASE + \ > (128 << 20)) > diff --git a/arch/arm/cpu/armv7/am33xx/Kconfig b/arch/arm/cpu/armv7/am33xx/Kconfig index dc51e9b..3a48664 100644 --- a/arch/arm/cpu/armv7/am33xx/Kconfig +++ b/arch/arm/cpu/armv7/am33xx/Kconfig @@ -22,7 +22,8 @@ config ISW_ENTRY_ADDR point address depending on the device type (secure/non-secure), boot media (xip/non-xip) and image headers. - default 0x402F4000 + default 0x402F4000 if AM43XX + default 0x402F0400 if AM33XX config PUB_ROM_DATA_SIZE hex "Size in bytes of the L3 SRAM reserved by ROM to store data"