From patchwork Mon Nov 29 12:18:27 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Debashish Rath X-Patchwork-Id: 73418 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id DBC041007D1 for ; Mon, 29 Nov 2010 23:18:47 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 58A7F2821F; Mon, 29 Nov 2010 13:18:44 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cn8u7Sxrxdq1; Mon, 29 Nov 2010 13:18:44 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 246ED28205; Mon, 29 Nov 2010 13:18:43 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1CD5E28205 for ; Mon, 29 Nov 2010 13:18:41 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p4s+isaeZCNJ for ; Mon, 29 Nov 2010 13:18:39 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail3.tridentmicro.com (mail3.tridentmicro.com [212.250.142.51]) by theia.denx.de (Postfix) with ESMTPS id 0510728200 for ; Mon, 29 Nov 2010 13:18:37 +0100 (CET) Received: from eu-exh-02.EU.TRID.COM ([92.120.117.20]) by eu-exh-02.EU.TRID.COM ([92.120.117.20]) with mapi; Mon, 29 Nov 2010 12:18:36 +0000 From: Debashish Rath To: Wolfgang Denk Date: Mon, 29 Nov 2010 12:18:27 +0000 Thread-Topic: [U-Boot] "usb reset" issue with some pen drives which work well in Linux/Windows Thread-Index: AcuPuQ+r/LZMBDqwSQC2NtgTAixx5gABfSPA Message-ID: <24A35C16137FE049838D189639DD567F0846F945@eu-exh-02.EU.TRID.COM> References: <24A35C16137FE049838D189639DD567F083D4BBC@eu-exh-02.EU.TRID.COM> <20101124162605.8F222B7172@gemini.denx.de> <24A35C16137FE049838D189639DD567F0846F87C@eu-exh-02.EU.TRID.COM> <20101129113205.2EC6111D94F7@gemini.denx.de> In-Reply-To: <20101129113205.2EC6111D94F7@gemini.denx.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-cr-puzzleid: {CDFEE709-9BF6-4585-A8E8-5A8DA3946ECC} x-cr-hashedpuzzle: AFRA CLbq D+6s Gtb4 IEyF JXjD LwNZ L7L/ Nb2u OaxK PKuq QsT4 Scv/ S5cd UOBq VZSJ; 2; dQAtAGIAbwBvAHQAQABsAGkAcwB0AHMALgBkAGUAbgB4AC4AZABlADsAdwBkAEAAZABlAG4AeAAuAGQAZQA=; Sosha1_v1; 7; {CDFEE709-9BF6-4585-A8E8-5A8DA3946ECC}; ZABlAGIAYQBzAGgAaQBzAGgALgByAGEAdABoAEAAdAByAGkAZABlAG4AdABtAGkAYwByAG8ALgBjAG8AbQA=; Mon, 29 Nov 2010 12:18:27 GMT; UgBFADoAIABbAFUALQBCAG8AbwB0AF0AIAAiAHUAcwBiACAAcgBlAHMAZQB0ACIAIABpAHMAcwB1AGUAIAB3AGkAdABoACAAcwBvAG0AZQAgAHAAZQBuACAAZAByAGkAdgBlAHMAIAB3AGgAaQBjAGgAIAB3AG8AcgBrACAAdwBlAGwAbAAgAGkAbgAgAEwAaQBuAHUAeAAvAFcAaQBuAGQAbwB3AHMA acceptlanguage: en-US MIME-Version: 1.0 Cc: "u-boot@lists.denx.de" Subject: Re: [U-Boot] "usb reset" issue with some pen drives which work well in Linux/Windows X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Dear Mr. Wolfgang, Please find the patch for the same. This is ok or I have to prepare a different mail and send the patch as an attachment. Regards Debashish Rath --------------------------PATCH START-------------- ------------------------PATCH END----------------------------- -----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Monday, November 29, 2010 5:02 PM To: Debashish Rath Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] "usb reset" issue with some pen drives which work well in Linux/Windows Dear Debashish Rath, In message <24A35C16137FE049838D189639DD567F0846F87C@eu-exh-02.EU.TRID.COM> you wrote: > > I found the issue. > In usb_stor_get_info function of common/usb_storage.c I add the following: > (dev->descriptor.idVendor =3D=3D 0x0204 && > dev->descriptor.idProduct =3D=3D 0x6025) > > to skip the ss->transport_reset(ss);. This I took out from the linux kernel= > code. > > Now its working for me. Congratulations. Can you now please submit this change as a proper patch so others can benefit from it, too? Please see here for help: http://www.denx.de/wiki/U-Boot/Patches Best regards, Wolfgang Denk --- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Microsoft Multitasking: several applications can crash at the same time. diff -Naur u-boot-2010.09/common/usb_storage.c u-boot-2010.09_usb_ms_reset/common/usb_storage.c --- u-boot-2010.09/common/usb_storage.c 2010-09-29 02:50:55.000000000 +0530 +++ u-boot-2010.09_usb_ms_reset/common/usb_storage.c 2010-11-29 17:16:01.825110000 +0530 @@ -1335,6 +1335,13 @@ */ (dev->descriptor.idVendor == 0x0781 && dev->descriptor.idProduct == 0x5406) + || + /* + * Standard Disk Drives + * USB Flash Memory + */ + (dev->descriptor.idVendor == 0x0204 && + dev->descriptor.idProduct == 0x6025) ) USB_STOR_PRINTF("usb_stor_get_info: skipping RESET..\n"); else