| Message ID | 217399a976d24a3129ac6f0854baec75ed5a25ff.1601552942.git.baruch@tkos.co.il |
|---|---|
| State | Accepted |
| Commit | 5a13c0d1348284b7f2a2c9b463ceedac67166d07 |
| Delegated to: | Heiko Schocher |
| Headers | show |
| Series | i2c: mvtwsi: disable i2c slave also on Armada 8k | expand |
Hello Baruch, Am 01.10.20 um 13:49 schrieb Baruch Siach: > The hidden I2C slave is also present on the Armada 8k AP806. Testing > shows that this I2C slave causes the same issues as Armada 38x. > Disabling that I2C slave fixes all these issues. > > I2C blocks on the Armada 8k CP110 are not affected. > > Extend the I2C slave disable to Armada 8k as well. > > Cc: Stefan Roese <sr@denx.de> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > drivers/i2c/mvtwsi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied to u-boot-i2c.git thanks! bye, Heiko
diff --git a/drivers/i2c/mvtwsi.c b/drivers/i2c/mvtwsi.c index fdb8fd42e5c0..14c594d648ba 100644 --- a/drivers/i2c/mvtwsi.c +++ b/drivers/i2c/mvtwsi.c @@ -823,7 +823,8 @@ static int mvtwsi_i2c_bind(struct udevice *bus) struct mvtwsi_registers *twsi = dev_read_addr_ptr(bus); /* Disable the hidden slave in i2c0 of these platforms */ - if ((IS_ENABLED(CONFIG_ARMADA_38X) || IS_ENABLED(CONFIG_ARCH_KIRKWOOD)) + if ((IS_ENABLED(CONFIG_ARMADA_38X) || IS_ENABLED(CONFIG_ARCH_KIRKWOOD) + || IS_ENABLED(CONFIG_ARMADA_8K)) && bus->req_seq == 0) twsi_disable_i2c_slave(twsi);
The hidden I2C slave is also present on the Armada 8k AP806. Testing shows that this I2C slave causes the same issues as Armada 38x. Disabling that I2C slave fixes all these issues. I2C blocks on the Armada 8k CP110 are not affected. Extend the I2C slave disable to Armada 8k as well. Cc: Stefan Roese <sr@denx.de> Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- drivers/i2c/mvtwsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)