diff mbox series

[1/3] configs: rockchip: enable RK806 SPI PMIC for Radxa ROCK 5A

Message ID 20241031032245.32749-1-naoki@radxa.com
State New
Delegated to: Kever Yang
Headers show
Series [1/3] configs: rockchip: enable RK806 SPI PMIC for Radxa ROCK 5A | expand

Commit Message

FUKAUMI Naoki Oct. 31, 2024, 3:22 a.m. UTC
enable RK806 SPI PMIC driver and related cmd/configs for Radxa ROCK 5A.

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 configs/rock5a-rk3588s_defconfig | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Quentin Schulz Oct. 31, 2024, 11:13 a.m. UTC | #1
Hi Naoki,

On 10/31/24 4:22 AM, FUKAUMI Naoki wrote:
> enable RK806 SPI PMIC driver and related cmd/configs for Radxa ROCK 5A.
> 
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>   configs/rock5a-rk3588s_defconfig | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/configs/rock5a-rk3588s_defconfig b/configs/rock5a-rk3588s_defconfig
> index 9618d590009..d2770198ef2 100644
> --- a/configs/rock5a-rk3588s_defconfig
> +++ b/configs/rock5a-rk3588s_defconfig
> @@ -28,6 +28,7 @@ CONFIG_CMD_I2C=y
>   CONFIG_CMD_MMC=y
>   CONFIG_CMD_USB=y
>   # CONFIG_CMD_SETEXPR is not set
> +CONFIG_CMD_PMIC=y
>   CONFIG_CMD_REGULATOR=y
>   # CONFIG_SPL_DOS_PARTITION is not set
>   CONFIG_SPL_OF_CONTROL=y
> @@ -55,11 +56,16 @@ CONFIG_PHY_ROCKCHIP_INNO_USB2=y
>   CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
>   CONFIG_PHY_ROCKCHIP_USBDP=y
>   CONFIG_SPL_PINCTRL=y
> +CONFIG_DM_PMIC=y
> +CONFIG_PMIC_RK8XX=y
> +CONFIG_SPL_PMIC_RK8XX=y

This won't be useful as neither the SPI controller, SPI pinmux nor PMIC 
nodes are marked as to keep for SPL in the DT as far as I could tell.

Same remark for patch 3 in this series.

Cheers,
Quentin
diff mbox series

Patch

diff --git a/configs/rock5a-rk3588s_defconfig b/configs/rock5a-rk3588s_defconfig
index 9618d590009..d2770198ef2 100644
--- a/configs/rock5a-rk3588s_defconfig
+++ b/configs/rock5a-rk3588s_defconfig
@@ -28,6 +28,7 @@  CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_PMIC=y
 CONFIG_CMD_REGULATOR=y
 # CONFIG_SPL_DOS_PARTITION is not set
 CONFIG_SPL_OF_CONTROL=y
@@ -55,11 +56,16 @@  CONFIG_PHY_ROCKCHIP_INNO_USB2=y
 CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
 CONFIG_PHY_ROCKCHIP_USBDP=y
 CONFIG_SPL_PINCTRL=y
+CONFIG_DM_PMIC=y
+CONFIG_PMIC_RK8XX=y
+CONFIG_SPL_PMIC_RK8XX=y
+CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_SPL_RAM=y
 CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550_MEM32=y
+CONFIG_ROCKCHIP_SPI=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y