diff mbox series

[v2,3/6] arch: arm: dts: k3-am68-sk-r5: Sync with J721s2 R5 file

Message ID 20240509-b4-upstream-j721s2-of-upstream-v2-3-149563cd4901@ti.com
State Superseded
Delegated to: Tom Rini
Headers show
Series Enable OF_UPSTREAM for J721s2 and AM68 | expand

Commit Message

Manorit Chawdhry May 9, 2024, 9:53 a.m. UTC
Currently AM68 SK boots with J721s2 R5 DTS and then later changes to
AM68 SK DT during runtime.

To split the support of J721s2 and AM68, sync AM68 R5 DT with J721s2 R5
DT as that contains some essential node changes for booting up AM68
using AM68 R5 DT.

secure_proxy_mcu and secure_proxy_sa3 node changes are required for
establishing contact with TIFS running on M4 core, and the addition of
new power domain helps in holding A72 in reset for configuration of
firewalls.

Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
---
 arch/arm/dts/k3-am68-sk-r5-base-board.dts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Neha Malcom Francis May 9, 2024, 10:17 a.m. UTC | #1
Hi Manorit

On 09/05/24 15:23, Manorit Chawdhry wrote:
> Currently AM68 SK boots with J721s2 R5 DTS and then later changes to
> AM68 SK DT during runtime.
> 
> To split the support of J721s2 and AM68, sync AM68 R5 DT with J721s2 R5
> DT as that contains some essential node changes for booting up AM68
> using AM68 R5 DT.
> 
> secure_proxy_mcu and secure_proxy_sa3 node changes are required for
> establishing contact with TIFS running on M4 core, and the addition of
> new power domain helps in holding A72 in reset for configuration of
> firewalls.
> 
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> ---
>   arch/arm/dts/k3-am68-sk-r5-base-board.dts | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/k3-am68-sk-r5-base-board.dts b/arch/arm/dts/k3-am68-sk-r5-base-board.dts
> index 695aadc287bd..038b08dc3e01 100644
> --- a/arch/arm/dts/k3-am68-sk-r5-base-board.dts
> +++ b/arch/arm/dts/k3-am68-sk-r5-base-board.dts
> @@ -24,7 +24,8 @@
>   		compatible = "ti,am654-rproc";
>   		reg = <0x0 0x00a90000 0x0 0x10>;
>   		power-domains = <&k3_pds 61 TI_SCI_PD_EXCLUSIVE>,
> -				<&k3_pds 202 TI_SCI_PD_EXCLUSIVE>;
> +				<&k3_pds 202 TI_SCI_PD_EXCLUSIVE>,
> +				<&k3_pds 4 TI_SCI_PD_EXCLUSIVE>;
>   		resets = <&k3_reset 202 0>;
>   		clocks = <&k3_clks 61 1>;
>   		assigned-clocks = <&k3_clks 61 1>, <&k3_clks 202 0>;
> @@ -54,10 +55,12 @@
>   
>   &secure_proxy_mcu {
>   	bootph-pre-ram;
> +	status = "okay";
>   };
>   
>   &secure_proxy_sa3 {
>   	bootph-pre-ram;
> +	status = "okay";
>   };
>   
>   &cbass_mcu_wakeup {
> 

Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
Nishanth Menon May 9, 2024, 12:29 p.m. UTC | #2
On 15:23-20240509, Manorit Chawdhry wrote:
> Currently AM68 SK boots with J721s2 R5 DTS and then later changes to
> AM68 SK DT during runtime.
> 
> To split the support of J721s2 and AM68, sync AM68 R5 DT with J721s2 R5
> DT as that contains some essential node changes for booting up AM68
> using AM68 R5 DT.
> 
> secure_proxy_mcu and secure_proxy_sa3 node changes are required for
> establishing contact with TIFS running on M4 core, and the addition of

s/TIFS/ROM and TIFS - you need sa2 sproxy for ROM and mcu sproxy for
TIFS.

M4 Core is generic - SMS M4 core will clarify.

> new power domain helps in holding A72 in reset for configuration of
> firewalls.

s/A72/A72 Cluster/


[...]
Manorit Chawdhry May 10, 2024, 5:04 a.m. UTC | #3
Hi Nishanth,

On 07:29-20240509, Nishanth Menon wrote:
> On 15:23-20240509, Manorit Chawdhry wrote:
> > Currently AM68 SK boots with J721s2 R5 DTS and then later changes to
> > AM68 SK DT during runtime.
> > 
> > To split the support of J721s2 and AM68, sync AM68 R5 DT with J721s2 R5
> > DT as that contains some essential node changes for booting up AM68
> > using AM68 R5 DT.
> > 
> > secure_proxy_mcu and secure_proxy_sa3 node changes are required for
> > establishing contact with TIFS running on M4 core, and the addition of
> 
> s/TIFS/ROM and TIFS - you need sa2 sproxy for ROM and mcu sproxy for
> TIFS.
> 

Thanks for the clarification! Was a bit confused in both of them
actually. Updated the message v3.

Regards,
Manorit

> M4 Core is generic - SMS M4 core will clarify.
> 
> > new power domain helps in holding A72 in reset for configuration of
> > firewalls.
> 
> s/A72/A72 Cluster/
> 

> 
> [...]
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
diff mbox series

Patch

diff --git a/arch/arm/dts/k3-am68-sk-r5-base-board.dts b/arch/arm/dts/k3-am68-sk-r5-base-board.dts
index 695aadc287bd..038b08dc3e01 100644
--- a/arch/arm/dts/k3-am68-sk-r5-base-board.dts
+++ b/arch/arm/dts/k3-am68-sk-r5-base-board.dts
@@ -24,7 +24,8 @@ 
 		compatible = "ti,am654-rproc";
 		reg = <0x0 0x00a90000 0x0 0x10>;
 		power-domains = <&k3_pds 61 TI_SCI_PD_EXCLUSIVE>,
-				<&k3_pds 202 TI_SCI_PD_EXCLUSIVE>;
+				<&k3_pds 202 TI_SCI_PD_EXCLUSIVE>,
+				<&k3_pds 4 TI_SCI_PD_EXCLUSIVE>;
 		resets = <&k3_reset 202 0>;
 		clocks = <&k3_clks 61 1>;
 		assigned-clocks = <&k3_clks 61 1>, <&k3_clks 202 0>;
@@ -54,10 +55,12 @@ 
 
 &secure_proxy_mcu {
 	bootph-pre-ram;
+	status = "okay";
 };
 
 &secure_proxy_sa3 {
 	bootph-pre-ram;
+	status = "okay";
 };
 
 &cbass_mcu_wakeup {