| Message ID | 20240408210619.3749231-2-jonas@kwiboo.se |
|---|---|
| State | Accepted |
| Delegated to: | Jaehoon Chung |
| Headers | show |
| Series | [1/2] mmc: Imply HS200 cap with mmc-hs400 prop to match linux | expand |
On 2024-04-08 23:06, Jonas Karlman wrote: > The linux commit f722e650d965 ("mmc: core: add support for disabling > HS400 mode via DT") added support for a no-mmc-hs400 prop. > > Add support for the no-mmc-hs400 prop to disable HS400 host caps. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> The description above should use "Linux" instead od "linux", but that's perhaps not worth sending the v2. Otherwise, looking good to me. Great job catching this! Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > drivers/mmc/mmc-uclass.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c > index 1349da72b102..1b454e8ec758 100644 > --- a/drivers/mmc/mmc-uclass.c > +++ b/drivers/mmc/mmc-uclass.c > @@ -256,6 +256,9 @@ int mmc_of_parse(struct udevice *dev, struct > mmc_config *cfg) > cfg->host_caps |= MMC_CAP(MMC_HS_400) | MMC_CAP(MMC_HS_200); > if (dev_read_bool(dev, "mmc-hs400-enhanced-strobe")) > cfg->host_caps |= MMC_CAP(MMC_HS_400_ES); > + if (dev_read_bool(dev, "no-mmc-hs400")) > + cfg->host_caps &= ~(MMC_CAP(MMC_HS_400) | > + MMC_CAP(MMC_HS_400_ES)); > > if (dev_read_bool(dev, "non-removable")) { > cfg->host_caps |= MMC_CAP_NONREMOVABLE;
Hi > -----Original Message----- > From: Jonas Karlman <jonas@kwiboo.se> > Sent: Tuesday, April 9, 2024 6:06 AM > To: Peng Fan <peng.fan@nxp.com>; Jaehoon Chung <jh80.chung@samsung.com>; Tom Rini <trini@konsulko.com> > Cc: Jonas Karlman <jonas@kwiboo.se>; u-boot@lists.denx.de > Subject: [PATCH 2/2] mmc: Add support for the no-mmc-hs400 prop > > The linux commit f722e650d965 ("mmc: core: add support for disabling > HS400 mode via DT") added support for a no-mmc-hs400 prop. > > Add support for the no-mmc-hs400 prop to disable HS400 host caps. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > drivers/mmc/mmc-uclass.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c > index 1349da72b102..1b454e8ec758 100644 > --- a/drivers/mmc/mmc-uclass.c > +++ b/drivers/mmc/mmc-uclass.c > @@ -256,6 +256,9 @@ int mmc_of_parse(struct udevice *dev, struct mmc_config *cfg) > cfg->host_caps |= MMC_CAP(MMC_HS_400) | MMC_CAP(MMC_HS_200); > if (dev_read_bool(dev, "mmc-hs400-enhanced-strobe")) > cfg->host_caps |= MMC_CAP(MMC_HS_400_ES); > + if (dev_read_bool(dev, "no-mmc-hs400")) > + cfg->host_caps &= ~(MMC_CAP(MMC_HS_400) | > + MMC_CAP(MMC_HS_400_ES)); > > if (dev_read_bool(dev, "non-removable")) { > cfg->host_caps |= MMC_CAP_NONREMOVABLE; > -- > 2.43.2
diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c index 1349da72b102..1b454e8ec758 100644 --- a/drivers/mmc/mmc-uclass.c +++ b/drivers/mmc/mmc-uclass.c @@ -256,6 +256,9 @@ int mmc_of_parse(struct udevice *dev, struct mmc_config *cfg) cfg->host_caps |= MMC_CAP(MMC_HS_400) | MMC_CAP(MMC_HS_200); if (dev_read_bool(dev, "mmc-hs400-enhanced-strobe")) cfg->host_caps |= MMC_CAP(MMC_HS_400_ES); + if (dev_read_bool(dev, "no-mmc-hs400")) + cfg->host_caps &= ~(MMC_CAP(MMC_HS_400) | + MMC_CAP(MMC_HS_400_ES)); if (dev_read_bool(dev, "non-removable")) { cfg->host_caps |= MMC_CAP_NONREMOVABLE;
The linux commit f722e650d965 ("mmc: core: add support for disabling HS400 mode via DT") added support for a no-mmc-hs400 prop. Add support for the no-mmc-hs400 prop to disable HS400 host caps. Signed-off-by: Jonas Karlman <jonas@kwiboo.se> --- drivers/mmc/mmc-uclass.c | 3 +++ 1 file changed, 3 insertions(+)