| Message ID | 20240315-b4-qcom-livetree-v2-9-ab635774b2dc@linaro.org |
|---|---|
| State | Superseded |
| Delegated to: | Caleb Connolly |
| Headers | show |
| Series | Qualcomm platform USB support | expand |
On 15/03/2024 16:10, Caleb Connolly wrote: > When using OF_LIVE, the debug UART driver won't be probed if it's a > subnode of the geni-se-qup controller. Add a NOP driver for the > controller to correctly discover its child nodes. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > drivers/serial/serial_msm_geni.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/serial/serial_msm_geni.c b/drivers/serial/serial_msm_geni.c > index 4aa0bc8c72bc..5260474fb9a4 100644 > --- a/drivers/serial/serial_msm_geni.c > +++ b/drivers/serial/serial_msm_geni.c > @@ -605,8 +605,21 @@ U_BOOT_DRIVER(serial_msm_geni) = { > .ops = &msm_serial_ops, > .flags = DM_FLAG_PRE_RELOC | DM_FLAG_DEFAULT_PD_CTRL_OFF, > }; > > +static const struct udevice_id geniqup_ids[] = { > + { .compatible = "qcom,geni-se-qup" }, > + { } > +}; > + > +U_BOOT_DRIVER(geni_se_qup) = { > + .name = "geni-se-qup", > + .id = UCLASS_NOP, > + .of_match = geniqup_ids, > + .bind = dm_scan_fdt_dev, > + .flags = DM_FLAG_PRE_RELOC | DM_FLAG_DEFAULT_PD_CTRL_OFF, > +}; > + > #ifdef CONFIG_DEBUG_UART_MSM_GENI > > static struct msm_serial_data init_serial_data = { > .base = CONFIG_VAL(DEBUG_UART_BASE) > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/serial/serial_msm_geni.c b/drivers/serial/serial_msm_geni.c index 4aa0bc8c72bc..5260474fb9a4 100644 --- a/drivers/serial/serial_msm_geni.c +++ b/drivers/serial/serial_msm_geni.c @@ -605,8 +605,21 @@ U_BOOT_DRIVER(serial_msm_geni) = { .ops = &msm_serial_ops, .flags = DM_FLAG_PRE_RELOC | DM_FLAG_DEFAULT_PD_CTRL_OFF, }; +static const struct udevice_id geniqup_ids[] = { + { .compatible = "qcom,geni-se-qup" }, + { } +}; + +U_BOOT_DRIVER(geni_se_qup) = { + .name = "geni-se-qup", + .id = UCLASS_NOP, + .of_match = geniqup_ids, + .bind = dm_scan_fdt_dev, + .flags = DM_FLAG_PRE_RELOC | DM_FLAG_DEFAULT_PD_CTRL_OFF, +}; + #ifdef CONFIG_DEBUG_UART_MSM_GENI static struct msm_serial_data init_serial_data = { .base = CONFIG_VAL(DEBUG_UART_BASE)
When using OF_LIVE, the debug UART driver won't be probed if it's a subnode of the geni-se-qup controller. Add a NOP driver for the controller to correctly discover its child nodes. Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> --- drivers/serial/serial_msm_geni.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)