| Message ID | 20240108-b4-upstream-fix-semicolon-v1-2-9437b3dc90ea@ti.com |
|---|---|
| State | Accepted |
| Commit | 27cc5951c862355da310e0bd2c42487979b9fa00 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Boot fixup | expand |
Hi Manorit, Thank you for the patch. On lun., janv. 08, 2024 at 13:48, Manorit Chawdhry <m-chawdhry@ti.com> wrote: > By default this variable is unset and this causes the test condition to > fail on devices that don't have this defined. Set a default value for > this. > > => boot > ## Error: "main_cpsw0_qsgmii_phyinit" not defined > [...] > > Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally") > > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > include/env/ti/ti_common.env | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/env/ti/ti_common.env b/include/env/ti/ti_common.env > index 5473f633aa7d..02b410c3adc4 100644 > --- a/include/env/ti/ti_common.env > +++ b/include/env/ti/ti_common.env > @@ -22,6 +22,7 @@ get_fit_overlaystring= > done; > get_fit_config=setexpr name_fit_config gsub / _ conf-${fdtfile} > run_fit=run get_fit_config; bootm ${addr_fit}#${name_fit_config}${overlaystring} > +do_main_cpsw0_qsgmii_phyinit=0 > bootcmd_ti_mmc= > run findfdt; run init_${boot}; > #if CONFIG_CMD_REMOTEPROC > > -- > 2.43.0
On Mon, Jan 08, 2024 at 01:48:49PM +0530, Manorit Chawdhry wrote: > By default this variable is unset and this causes the test condition to > fail on devices that don't have this defined. Set a default value for > this. > > => boot > ## Error: "main_cpsw0_qsgmii_phyinit" not defined > [...] > > Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally") > > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com> > Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Applied to u-boot/master, thanks!
diff --git a/include/env/ti/ti_common.env b/include/env/ti/ti_common.env index 5473f633aa7d..02b410c3adc4 100644 --- a/include/env/ti/ti_common.env +++ b/include/env/ti/ti_common.env @@ -22,6 +22,7 @@ get_fit_overlaystring= done; get_fit_config=setexpr name_fit_config gsub / _ conf-${fdtfile} run_fit=run get_fit_config; bootm ${addr_fit}#${name_fit_config}${overlaystring} +do_main_cpsw0_qsgmii_phyinit=0 bootcmd_ti_mmc= run findfdt; run init_${boot}; #if CONFIG_CMD_REMOTEPROC
By default this variable is unset and this causes the test condition to fail on devices that don't have this defined. Set a default value for this. => boot ## Error: "main_cpsw0_qsgmii_phyinit" not defined [...] Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally") Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com> --- include/env/ti/ti_common.env | 1 + 1 file changed, 1 insertion(+)