| Message ID | 20240108-b4-upstream-fix-semicolon-v1-1-9437b3dc90ea@ti.com |
|---|---|
| State | Accepted |
| Commit | a99d652ff1e8fa98228ebec9009cd06ba17139bd |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Boot fixup | expand |
Hi Manorit, Thank you for the patch. On lun., janv. 08, 2024 at 13:48, Manorit Chawdhry <m-chawdhry@ti.com> wrote: > Fix a missing semicolon that leads to syntax error while booting j721s2. > > Importing environment from mmc1 ... > syntax error at 'run'HUSH died! > > Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally") > > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > include/env/ti/ti_common.env | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/env/ti/ti_common.env b/include/env/ti/ti_common.env > index f0f89a228767..5473f633aa7d 100644 > --- a/include/env/ti/ti_common.env > +++ b/include/env/ti/ti_common.env > @@ -27,7 +27,7 @@ bootcmd_ti_mmc= > #if CONFIG_CMD_REMOTEPROC > if test ${do_main_cpsw0_qsgmii_phyinit} -eq 1; > then run main_cpsw0_qsgmii_phyinit; > - fi > + fi; > run boot_rprocs; > #endif > if test ${boot_fit} -eq 1; > > -- > 2.43.0
On Mon, Jan 08, 2024 at 01:48:48PM +0530, Manorit Chawdhry wrote: > Fix a missing semicolon that leads to syntax error while booting j721s2. > > Importing environment from mmc1 ... > syntax error at 'run'HUSH died! > > Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally") > > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com> > Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Applied to u-boot/master, thanks!
diff --git a/include/env/ti/ti_common.env b/include/env/ti/ti_common.env index f0f89a228767..5473f633aa7d 100644 --- a/include/env/ti/ti_common.env +++ b/include/env/ti/ti_common.env @@ -27,7 +27,7 @@ bootcmd_ti_mmc= #if CONFIG_CMD_REMOTEPROC if test ${do_main_cpsw0_qsgmii_phyinit} -eq 1; then run main_cpsw0_qsgmii_phyinit; - fi + fi; run boot_rprocs; #endif if test ${boot_fit} -eq 1;
Fix a missing semicolon that leads to syntax error while booting j721s2. Importing environment from mmc1 ... syntax error at 'run'HUSH died! Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally") Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com> --- include/env/ti/ti_common.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)