diff mbox series

CI: update pylint to recent version

Message ID 20231209200300.12272-1-heinrich.schuchardt@canonical.com
State New
Delegated to: Tom Rini
Headers show
Series CI: update pylint to recent version | expand

Commit Message

Heinrich Schuchardt Dec. 9, 2023, 8:03 p.m. UTC 
We are missing some Python problems like

   "Using variable 'varname' before assignment"

Switch to a more recent version. Adjust the documentation accordingly.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 .azure-pipelines.yml      | 2 +-
 .gitlab-ci.yml            | 2 +-
 doc/develop/python_cq.rst | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

Comments

Simon Glass Dec. 11, 2023, 5:52 p.m. UTC | #1 
Hi Heinrich,

On Sat, 9 Dec 2023 at 13:03, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> We are missing some Python problems like
>
>    "Using variable 'varname' before assignment"
>
> Switch to a more recent version. Adjust the documentation accordingly.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  .azure-pipelines.yml      | 2 +-
>  .gitlab-ci.yml            | 2 +-
>  doc/develop/python_cq.rst | 4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

Is there an associated patch to actually fix these problems?

Regards,
Simon
diff mbox series

Patch

diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
index b9d6aa98a0..93e9df78d1 100644
--- a/.azure-pipelines.yml
+++ b/.azure-pipelines.yml
@@ -151,7 +151,7 @@  stages:
           export USER=azure
           pip install -r test/py/requirements.txt
           pip install -r tools/buildman/requirements.txt
-          pip install asteval pylint==2.12.2 pyopenssl
+          pip install asteval pylint==2.17.7 pyopenssl
           export PATH=${PATH}:~/.local/bin
           echo "[MASTER]" >> .pylintrc
           echo "load-plugins=pylint.extensions.docparams" >> .pylintrc
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index fbf99f0322..0acac16d82 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -218,7 +218,7 @@  Run pylint:
     - git config --global --add safe.directory "${CI_PROJECT_DIR}"
     - pip install -r test/py/requirements.txt
     - pip install -r tools/buildman/requirements.txt
-    - pip install asteval pylint==2.12.2 pyopenssl
+    - pip install asteval pylint==2.17.7 pyopenssl
     - export PATH=${PATH}:~/.local/bin
     - echo "[MASTER]" >> .pylintrc
     - echo "load-plugins=pylint.extensions.docparams" >> .pylintrc
diff --git a/doc/develop/python_cq.rst b/doc/develop/python_cq.rst
index 1e209ff197..48fe055593 100644
--- a/doc/develop/python_cq.rst
+++ b/doc/develop/python_cq.rst
@@ -23,7 +23,7 @@  regressions in any module.
 To run this locally you should use this version of pylint::
 
     # pylint --version
-    pylint 2.11.1
+    pylint 2.17.7
     astroid 2.8.6
     Python 3.8.10 (default, Sep 28 2021, 16:10:42)
     [GCC 9.3.0]
@@ -31,7 +31,7 @@  To run this locally you should use this version of pylint::
 
 You should be able to select and this install other required tools with::
 
-    pip install pylint==2.11.1
+    pip install pylint==2.17.7
     pip install -r test/py/requirements.txt
     pip install asteval pyopenssl