| Message ID | 20231117113811.149329-6-rasmus.villemoes@prevas.dk |
|---|---|
| State | Accepted |
| Commit | d45e712f880d930bf14be022730d1268d6de0158 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | some LED patches | expand |
> > Use the helper led_bind_generic() to reduce code duplication. > > Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> > --- > drivers/led/led_pwm.c | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/led/led_pwm.c b/drivers/led/led_pwm.c > index 7c8eae9337b..ae6de3087ab 100644 > --- a/drivers/led/led_pwm.c > +++ b/drivers/led/led_pwm.c > @@ -9,7 +9,6 @@ > #include <errno.h> > #include <led.h> > #include <malloc.h> > -#include <dm/lists.h> > #include <pwm.h> > > #define LEDS_PWM_DRIVER_NAME "led_pwm" > @@ -136,18 +135,7 @@ static int led_pwm_of_to_plat(struct udevice *dev) > > static int led_pwm_bind(struct udevice *parent) > { > - struct udevice *dev; > - ofnode node; > - int ret; > - > - dev_for_each_subnode(node, parent) { > - ret = device_bind_driver_to_node(parent, LEDS_PWM_DRIVER_NAME, > - ofnode_get_name(node), > - node, &dev); > - if (ret) > - return ret; > - } > - return 0; > + return led_bind_generic(parent, LEDS_PWM_DRIVER_NAME); > } > > static const struct led_ops led_pwm_ops = { > -- > 2.40.1.1.g1c60b9335d >
diff --git a/drivers/led/led_pwm.c b/drivers/led/led_pwm.c index 7c8eae9337b..ae6de3087ab 100644 --- a/drivers/led/led_pwm.c +++ b/drivers/led/led_pwm.c @@ -9,7 +9,6 @@ #include <errno.h> #include <led.h> #include <malloc.h> -#include <dm/lists.h> #include <pwm.h> #define LEDS_PWM_DRIVER_NAME "led_pwm" @@ -136,18 +135,7 @@ static int led_pwm_of_to_plat(struct udevice *dev) static int led_pwm_bind(struct udevice *parent) { - struct udevice *dev; - ofnode node; - int ret; - - dev_for_each_subnode(node, parent) { - ret = device_bind_driver_to_node(parent, LEDS_PWM_DRIVER_NAME, - ofnode_get_name(node), - node, &dev); - if (ret) - return ret; - } - return 0; + return led_bind_generic(parent, LEDS_PWM_DRIVER_NAME); } static const struct led_ops led_pwm_ops = {
Use the helper led_bind_generic() to reduce code duplication. Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> --- drivers/led/led_pwm.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-)