| Message ID | 20231107173417.8254-1-semen.protsenko@linaro.org |
|---|---|
| State | Accepted |
| Commit | 2227f4c0afed9fef940ace67d1482417eb876316 |
| Delegated to: | Minkyu Kang |
| Headers | show |
| Series | serial: s5p: Fix clk_get_by_index() error code check | expand |
Hi 2023년 11월 8일 (수) 03:39, Sam Protsenko <semen.protsenko@linaro.org>님이 작성: > clk_get_by_index() returns negative number on error. Assigning it to > unsigned int makes the subsequent "ret < 0" check always false, leading > in turn to possible unhandled errors. Change 'ret' variable type to > signed int so the code checks and handles clk_get_by_index() return code > properly. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > Fixes: cf75cdf96ef2 ("serial: s5p: use clock api to get clock rate") > --- > drivers/serial/serial_s5p.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/serial/serial_s5p.c b/drivers/serial/serial_s5p.c > index 7aeb8c0f8cb7..fe52580d64de 100644 > --- a/drivers/serial/serial_s5p.c > +++ b/drivers/serial/serial_s5p.c > @@ -118,7 +118,7 @@ int s5p_serial_setbrg(struct udevice *dev, int > baudrate) > > #if IS_ENABLED(CONFIG_CLK_EXYNOS) || IS_ENABLED(CONFIG_ARCH_APPLE) > struct clk clk; > - u32 ret; > + int ret; > > ret = clk_get_by_index(dev, 1, &clk); > if (ret < 0) > -- > 2.39.2 > applied to u-boot-samsung. Thanks. Minkyu Kang.
diff --git a/drivers/serial/serial_s5p.c b/drivers/serial/serial_s5p.c index 7aeb8c0f8cb7..fe52580d64de 100644 --- a/drivers/serial/serial_s5p.c +++ b/drivers/serial/serial_s5p.c @@ -118,7 +118,7 @@ int s5p_serial_setbrg(struct udevice *dev, int baudrate) #if IS_ENABLED(CONFIG_CLK_EXYNOS) || IS_ENABLED(CONFIG_ARCH_APPLE) struct clk clk; - u32 ret; + int ret; ret = clk_get_by_index(dev, 1, &clk); if (ret < 0)
clk_get_by_index() returns negative number on error. Assigning it to unsigned int makes the subsequent "ret < 0" check always false, leading in turn to possible unhandled errors. Change 'ret' variable type to signed int so the code checks and handles clk_get_by_index() return code properly. Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> Fixes: cf75cdf96ef2 ("serial: s5p: use clock api to get clock rate") --- drivers/serial/serial_s5p.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)