diff mbox series

[v2,2/2] mx8mp_evk: Remove unneeded header files

Message ID 20231019192155.1735199-2-festevam@gmail.com
State Accepted
Delegated to: Stefano Babic
Headers show
Series [v2,1/2] imx8mp_evk: Simplify Ethernet initialization | expand

Commit Message

Fabio Estevam Oct. 19, 2023, 7:21 p.m. UTC
From: Fabio Estevam <festevam@denx.de>

Cleanup the file by removing unneeded header files.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Newly introduced. (Hugo)

 board/freescale/imx8mp_evk/imx8mp_evk.c | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Hugo Villeneuve Oct. 19, 2023, 8:30 p.m. UTC | #1
On Thu, 19 Oct 2023 16:21:55 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> From: Fabio Estevam <festevam@denx.de>
> 
> Cleanup the file by removing unneeded header files.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v1:
> - Newly introduced. (Hugo)
> 
>  board/freescale/imx8mp_evk/imx8mp_evk.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/board/freescale/imx8mp_evk/imx8mp_evk.c b/board/freescale/imx8mp_evk/imx8mp_evk.c
> index 42291c958e39..e62e27db48d9 100644
> --- a/board/freescale/imx8mp_evk/imx8mp_evk.c
> +++ b/board/freescale/imx8mp_evk/imx8mp_evk.c
> @@ -3,18 +3,8 @@
>   * Copyright 2019 NXP
>   */
>  
> -#include <common.h>
>  #include <env.h>
> -#include <errno.h>
> -#include <init.h>
> -#include <linux/delay.h>
>  #include <asm/global_data.h>
> -#include <asm/mach-imx/iomux-v3.h>
> -#include <asm-generic/gpio.h>
> -#include <asm/arch/imx8mp_pins.h>
> -#include <asm/arch/clock.h>
> -#include <asm/arch/sys_proto.h>
> -#include <asm/mach-imx/gpio.h>
>  
>  DECLARE_GLOBAL_DATA_PTR;

Hi Fabio,
after that, do you even need DECLARE_GLOBAL_DATA_PTR and its associated
header file?

Hugo.
diff mbox series

Patch

diff --git a/board/freescale/imx8mp_evk/imx8mp_evk.c b/board/freescale/imx8mp_evk/imx8mp_evk.c
index 42291c958e39..e62e27db48d9 100644
--- a/board/freescale/imx8mp_evk/imx8mp_evk.c
+++ b/board/freescale/imx8mp_evk/imx8mp_evk.c
@@ -3,18 +3,8 @@ 
  * Copyright 2019 NXP
  */
 
-#include <common.h>
 #include <env.h>
-#include <errno.h>
-#include <init.h>
-#include <linux/delay.h>
 #include <asm/global_data.h>
-#include <asm/mach-imx/iomux-v3.h>
-#include <asm-generic/gpio.h>
-#include <asm/arch/imx8mp_pins.h>
-#include <asm/arch/clock.h>
-#include <asm/arch/sys_proto.h>
-#include <asm/mach-imx/gpio.h>
 
 DECLARE_GLOBAL_DATA_PTR;