diff mbox series

[v3] imx8mp-dhcom-pdk3-overlay-rev100: Pass #address-cells/size-cells

Message ID 20231018185225.1269962-1-festevam@gmail.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series [v3] imx8mp-dhcom-pdk3-overlay-rev100: Pass #address-cells/size-cells | expand

Commit Message

Fabio Estevam Oct. 18, 2023, 6:52 p.m. UTC
From: Fabio Estevam <festevam@denx.de>

Pass #address-cells/size-cells in the mdio node to avoid the following
DTC warning:

  DTCO    arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dtbo
Warning (reg_format): /fragment@0/__overlay__:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default #address-cells value
Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default #size-cells value

Also change the Ethernet PHY address to 5, as per Marek's feedback.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v2:
- Change the Ethernet PHY address to 5. (Marek)

 arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Comments

Marek Vasut Oct. 18, 2023, 6:53 p.m. UTC | #1
On 10/18/23 20:52, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Pass #address-cells/size-cells in the mdio node to avoid the following
> DTC warning:
> 
>    DTCO    arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dtbo
> Warning (reg_format): /fragment@0/__overlay__:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default #address-cells value
> Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default #size-cells value
> 
> Also change the Ethernet PHY address to 5, as per Marek's feedback.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v2:
> - Change the Ethernet PHY address to 5. (Marek)
> 
>   arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts
> index f27e6429abe4..bad015536166 100644
> --- a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts
> +++ b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts
> @@ -5,6 +5,13 @@
>   /dts-v1/;
>   /plugin/;
>   
> -&ethphy0g {
> -	reg = <7>;
> +&eqos {
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethernet-phy@7 {

Did you miss git commit --amend or git rebase --autosquash ? :)

This is still @7 here .
diff mbox series

Patch

diff --git a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts
index f27e6429abe4..bad015536166 100644
--- a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts
+++ b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts
@@ -5,6 +5,13 @@ 
 /dts-v1/;
 /plugin/;
 
-&ethphy0g {
-	reg = <7>;
+&eqos {
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethernet-phy@7 {
+			reg = <7>;
+		};
+	};
 };