diff mbox series

[v4,12/16] board: ti: j784s4: Update env to use am69-sk dtb

Message ID 20231001165545.494212-13-a-nandan@ti.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series Introduce initial TI's J784S4 and AM69 support | expand

Commit Message

Apurva Nandan Oct. 1, 2023, 4:55 p.m. UTC
From: Dasnavis Sabiya <sabiya.d@ti.com>

Add condition to select right dtb for AM69 SK vs J784S4 EVM board.

Signed-off-by: Dasnavis Sabiya <sabiya.d@ti.com>
Signed-off-by: Apurva Nandan <a-nandan@ti.com>
---
 board/ti/j784s4/j784s4.env | 2 ++
 1 file changed, 2 insertions(+)

Comments

Nishanth Menon Oct. 2, 2023, 3:39 p.m. UTC | #1
On 22:25-20231001, Apurva Nandan wrote:
> From: Dasnavis Sabiya <sabiya.d@ti.com>
> 
> Add condition to select right dtb for AM69 SK vs J784S4 EVM board.
> 
> Signed-off-by: Dasnavis Sabiya <sabiya.d@ti.com>
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> ---
>  board/ti/j784s4/j784s4.env | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/board/ti/j784s4/j784s4.env b/board/ti/j784s4/j784s4.env
> index 74f822440e..7c57952bfb 100644
> --- a/board/ti/j784s4/j784s4.env
> +++ b/board/ti/j784s4/j784s4.env
> @@ -10,6 +10,8 @@
>  default_device_tree=ti/k3-j784s4-evm.dtb
>  findfdt=
>  	setenv name_fdt ${default_device_tree};
> +	if test CONFIG_DEFAULT_DEVICE_TREE = "k3-am69-sk"; then
> +		setenv name_fdt ti/k3-am69-sk.dtb; fi;
>  	if test CONFIG_DEFAULT_DEVICE_TREE = "k3-j784s4-evm"; then
>  		setenv name_fdt ti/k3-j784s4-evm.dtb; fi;

What function is this doing? Why not leave it for defaults?

Just use include/env/ti/default_findfdt.env and be done with it?

>  	setenv fdtfile ${name_fdt}
> -- 
> 2.34.1
>
diff mbox series

Patch

diff --git a/board/ti/j784s4/j784s4.env b/board/ti/j784s4/j784s4.env
index 74f822440e..7c57952bfb 100644
--- a/board/ti/j784s4/j784s4.env
+++ b/board/ti/j784s4/j784s4.env
@@ -10,6 +10,8 @@ 
 default_device_tree=ti/k3-j784s4-evm.dtb
 findfdt=
 	setenv name_fdt ${default_device_tree};
+	if test CONFIG_DEFAULT_DEVICE_TREE = "k3-am69-sk"; then
+		setenv name_fdt ti/k3-am69-sk.dtb; fi;
 	if test CONFIG_DEFAULT_DEVICE_TREE = "k3-j784s4-evm"; then
 		setenv name_fdt ti/k3-j784s4-evm.dtb; fi;
 	setenv fdtfile ${name_fdt}