diff mbox series

[v4,42/44] serial: Drop ns16550 serial_getinfo() in SPL

Message ID 20230926141514.2101787-43-sjg@chromium.org
State Accepted
Commit 7f5ff034c32acd4481f4d6ce8118542f71c91b75
Delegated to: Tom Rini
Headers show
Series spl: Preparation for Universal Payload | expand

Commit Message

Simon Glass Sept. 26, 2023, 2:14 p.m. UTC 
This is typically not needed in SPL/TPL and increases the code size.
Drop it.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v4:
- Add new patch to drop ns16550 serial_getinfo() in SPL

 drivers/serial/ns16550.c | 5 +++++
 1 file changed, 5 insertions(+)
diff mbox series

Patch

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index eab9537fbae5..5ca2828ae853 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -13,6 +13,7 @@ 
 #include <ns16550.h>
 #include <reset.h>
 #include <serial.h>
+#include <spl.h>
 #include <watchdog.h>
 #include <asm/global_data.h>
 #include <linux/err.h>
@@ -472,6 +473,10 @@  static int ns16550_serial_getinfo(struct udevice *dev,
 	struct ns16550 *const com_port = dev_get_priv(dev);
 	struct ns16550_plat *plat = com_port->plat;
 
+	/* save code size */
+	if (!spl_in_proper())
+		return -ENOSYS;
+
 	info->type = SERIAL_CHIP_16550_COMPATIBLE;
 #ifdef CONFIG_SYS_NS16550_PORT_MAPPED
 	info->addr_space = SERIAL_ADDRESS_SPACE_IO;