From patchwork Wed Jul 19 06:53:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Kiselev X-Patchwork-Id: 1809670 X-Patchwork-Delegate: andre.przywara@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=h/RoS+Kw; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R5RPc2yKrz20Cs for ; Wed, 19 Jul 2023 16:54:12 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 38C2F86720; Wed, 19 Jul 2023 08:54:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="h/RoS+Kw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C9D8E86728; Wed, 19 Jul 2023 08:54:06 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8752D86717 for ; Wed, 19 Jul 2023 08:54:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bigunclemax@gmail.com Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4fb8574a3a1so10656273e87.1 for ; Tue, 18 Jul 2023 23:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689749643; x=1692341643; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3WEJ7KnBasLx9sj1/II72uVEhSj1hvTE31ggVcI26jU=; b=h/RoS+KwhN4/BjHLAENlafeu+pQIANqE3dVwI3fIa1uTwTrz2ByKgicqEnSFWQxsmP 8a8NM34bmnzcmyJpuaETYi3u2ZZhgPR8WWfp0AHZsLM8l2IdzHcSD4TMf2Tz858SVQdy kCfsmMyIjHf3kU6+d8dfuzQpcOI2w6Qrziqt5cKtNtiVQpW0ZWuCBkoQCTgkKVbnNRFI xXY2B9mdSNdUBuYodF7+spQwaPTQvyrcwjtegJEoFALb7bXrD1Ci0+Ulu5yjbsVpyxwg X78A/hi7YXdsPLRzF4hNVlfeqtXDRgNjSg8Mpjc3jT6UazhZIeTB1xyP3074wY+cpCzB 6YpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689749643; x=1692341643; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3WEJ7KnBasLx9sj1/II72uVEhSj1hvTE31ggVcI26jU=; b=SOq0c3Ri/DNRdVM3b9z3oqxYjA4D08GiP2R+JXaHAse5dW8VEXngrGH9kAn3DmmFO+ 049BDsGlcALqL/qQPQWn331gGmauLUmZZ2+1dyg0YVn+X3LP6nI04wAR0JKSUajDmC6S MJeIp1XG1KvVGAPcOXFygxFTwHBlqA+e4m7c3SAHN1d+KnTNvFK90MIn08PevG8fbgHK zKR8sJvLdEclXBLogscknFe9xYvVIW8YGCo9nk2l1pJPSGF4/UQWBKgxj1nS8RcNo0PR 1Ern6Cy1Wzc2y1K39BP2l1owy/PuxVNJ4gBt9xnNAB/1plxMEJ++lgmChEl7e8zub7Ea Stlg== X-Gm-Message-State: ABy/qLbhEemeD7jNX0+mu3rYW29GR9ZMspZNvFxZs1FoAa7R7613tCGM FL+IRVGmGlEvG9fn9ukb/iPTYC0NF+E= X-Google-Smtp-Source: APBJJlFSGrK1AiNQXaIkX6rfkRz/+bITeWRncQfu5ffTyMhjuF0aYlwWBt/Mwdr6zqz5JjH0bZaQ7A== X-Received: by 2002:a05:6512:3b25:b0:4fb:2c1e:4e03 with SMTP id f37-20020a0565123b2500b004fb2c1e4e03mr13949831lfv.32.1689749643136; Tue, 18 Jul 2023 23:54:03 -0700 (PDT) Received: from user-PC.. ([178.134.198.138]) by smtp.gmail.com with ESMTPSA id j28-20020ac253bc000000b004fba101946dsm810234lfh.187.2023.07.18.23.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 23:54:01 -0700 (PDT) From: Maksim Kiselev To: u-boot@lists.denx.de Cc: Maksim Kiselev , Joe Hershberger , Ramon Fried , Michal Simek Subject: [PATCH] net: axi_emac: Change return value to -EAGAIN if RX is not ready Date: Wed, 19 Jul 2023 09:53:37 +0300 Message-Id: <20230719065337.69280-1-bigunclemax@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean If there is no incoming package than axiemac_recv will return -1 which in turn leads to printing `eth_rx: recv() returned error -1` error message in eth_rx function. But missing a package is not an fatal error, so return -EAGAIN in that case would be more suitable. Signed-off-by: Maksim Kiselev --- drivers/net/xilinx_axi_emac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xilinx_axi_emac.c b/drivers/net/xilinx_axi_emac.c index 3e9919993d..39cb3cc260 100644 --- a/drivers/net/xilinx_axi_emac.c +++ b/drivers/net/xilinx_axi_emac.c @@ -748,7 +748,7 @@ static int axiemac_recv(struct udevice *dev, int flags, uchar **packetp) /* Wait for an incoming packet */ if (!isrxready(priv)) - return -1; + return -EAGAIN; debug("axiemac: RX data ready\n");