diff mbox series

[v2,42/60] buildman: Correct invalid use of out_dir variable

Message ID 20230705121951.1629361-43-sjg@chromium.org
State Superseded
Delegated to: Simon Glass
Headers show
Series buildman: Refactor code and correct some pylint warnings | expand

Commit Message

Simon Glass July 5, 2023, 12:19 p.m. UTC
This variable has a different meaning in the outer scrop. Use a different
name to avoid confusion, or bugs.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v1)

 tools/buildman/builderthread.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index 45ae6edf9f48..f110137e8f6e 100644
--- a/tools/buildman/builderthread.py
+++ b/tools/buildman/builderthread.py
@@ -246,8 +246,8 @@  class BuilderThread(threading.Thread):
                         #
                         # Symlinks can confuse U-Boot's Makefile since
                         # we may use '..' in our path, so remove them.
-                        out_dir = os.path.realpath(out_dir)
-                        args.append(f'O={out_dir}')
+                        real_dir = os.path.realpath(out_dir)
+                        args.append(f'O={real_dir}')
                         cwd = None
                         src_dir = os.getcwd()
                     else: