From patchwork Sun Jul 2 14:25:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1802346 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=Y9VhhB0A; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QvBLc42V1z20ZF for ; Mon, 3 Jul 2023 00:31:04 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A50D086772; Sun, 2 Jul 2023 16:28:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Y9VhhB0A"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 615D0865DE; Sun, 2 Jul 2023 16:27:34 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 30153865F2 for ; Sun, 2 Jul 2023 16:27:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-il1-x12d.google.com with SMTP id e9e14a558f8ab-3457157a164so15111005ab.1 for ; Sun, 02 Jul 2023 07:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1688308050; x=1690900050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4vEF+pnNDAfMa/8rCFJ95YvWfmhUialp1lIv0Gbu4Wk=; b=Y9VhhB0A3lRzuGzpiL9JEhK5xXrbrcOHDFmfpe6mUjneoxYWysIs2PtAHwIxUBNlN4 ikw8zvtqVXYORhYcsgYgKAa/+CrKPec2y73zg0JBUBPYMDGg04INcLCLEk/2cr4IDajp +yQ+K2Uot3w5pGZn5vdwDA3t5W70BiE4rwpBk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688308050; x=1690900050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4vEF+pnNDAfMa/8rCFJ95YvWfmhUialp1lIv0Gbu4Wk=; b=H1jBoH8cILl2vltKh9kWpeFCZJg+EFVg94uXXD91k9wDMNTeff+vS4sWiBjpiI1u8l V6D0QKKA98mmnrgwWAOOlZQEy689Ep3of6J755rKabDre5FiVURWwCH1/ewqjKnpCq/l sv9iThrcrRlIOHIgoq9A42V9wgVKP0W/q6FddN7AH0QRKLGXeUR0Ak5LLb1cdaGVdYj1 6GO9bkxOdEKo264njZZCl612adf9C644aQ+yw9yU4Llc7rtGlSWCsZEJD14tfsbKeiTc YXu4SXeFdZaIDNrnt5xzwYwZO/uHsA4rBBZ9rYEIRHE8oJC0bY3vV1UNe705MYdY9wm/ lA4w== X-Gm-Message-State: ABy/qLa+sLFrZx0ZMLGJ4utl7qP7Wb+1nTfA+HGIGHjUGgq7ay/rfckh KVlEfwCrLcBQyT+1FNPYyN+8VbX41WnRsuSz4nc= X-Google-Smtp-Source: APBJJlFzZHUAKGBE5iW/i5788qogVcpHZqDJ0WhPNKJIDieGurYG2ks07Jnn2Hi4LW/Ky+3xQZqPyw== X-Received: by 2002:a92:d2c8:0:b0:345:70b9:5171 with SMTP id w8-20020a92d2c8000000b0034570b95171mr7557947ilg.20.1688308049837; Sun, 02 Jul 2023 07:27:29 -0700 (PDT) Received: from sjg1.lan (c-73-14-173-85.hsd1.co.comcast.net. [73.14.173.85]) by smtp.gmail.com with ESMTPSA id c13-20020a02c9cd000000b0042af5268e4asm2934713jap.58.2023.07.02.07.27.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jul 2023 07:27:29 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Simon Glass Subject: [PATCH 24/58] buildman: Tweak commits and show_bloat Date: Sun, 2 Jul 2023 15:25:49 +0100 Message-ID: <20230702142639.1249681-25-sjg@chromium.org> X-Mailer: git-send-email 2.41.0.255.g8b1d071c50-goog In-Reply-To: <20230702142639.1249681-1-sjg@chromium.org> References: <20230702142639.1249681-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Move setting of show_bloat to adjust_options() and adjust how the commits variable is set. Together these remove the pylint warning about too many statements. Signed-off-by: Simon Glass --- tools/buildman/control.py | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py index c0274f5463dc..a0b5033bc878 100644 --- a/tools/buildman/control.py +++ b/tools/buildman/control.py @@ -433,6 +433,10 @@ def adjust_options(options, series, selected): if not options.step: options.step = len(series.commits) - 1 + # We can't show function sizes without board details at present + if options.show_bloat: + options.show_detail = True + def setup_output_dir(output_dir, work_in_output, branch, no_subdirs, col, clean_dir): @@ -572,18 +576,11 @@ def do_buildman(options, args, toolchains=None, make_func=None, brds=None, # Work out which boards to build board_selected = brds.get_selected_dict() - if series: - commits = series.commits - else: - commits = None - + commits = series.commits if series else None if not options.ide: tprint(get_action_summary(options.summary, commits, board_selected, options.step, options.threads, options.jobs)) - # We can't show function sizes without board details at present - if options.show_bloat: - options.show_detail = True builder.SetDisplayOptions( options.show_errors, options.show_sizes, options.show_detail, options.show_bloat, options.list_error_boards, options.show_config,