diff mbox series

imx8m: soc.c: demote some printfs to debug

Message ID 20230522092728.22025-1-rasmus.villemoes@prevas.dk
State Accepted
Commit cb4e79b7ba9aef961e7a6549ec35467e3c1f8e85
Delegated to: Stefano Babic
Headers show
Series imx8m: soc.c: demote some printfs to debug | expand

Commit Message

Rasmus Villemoes May 22, 2023, 9:27 a.m. UTC
Getting

  Found /vpu_g1@38300000 node
  Modify /vpu_g1@38300000:status disabled
  Found /vpu_g2@38310000 node
  Modify /vpu_g2@38310000:status disabled

etc. on the console on every boot is needlessly verbose. Demote the
"Found ..." lines to debug(), which is consistent with other instances
in soc.c.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
 arch/arm/mach-imx/imx8m/soc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Frieder Schrempf May 22, 2023, 10:05 a.m. UTC | #1
On 22.05.23 11:27, Rasmus Villemoes wrote:
> Getting
> 
>   Found /vpu_g1@38300000 node
>   Modify /vpu_g1@38300000:status disabled
>   Found /vpu_g2@38310000 node
>   Modify /vpu_g2@38310000:status disabled
> 
> etc. on the console on every boot is needlessly verbose. Demote the
> "Found ..." lines to debug(), which is consistent with other instances
> in soc.c.
> 
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Peng Fan (OSS) May 23, 2023, 6:05 a.m. UTC | #2
On 5/22/2023 5:27 PM, Rasmus Villemoes wrote:
> Getting
> 
>    Found /vpu_g1@38300000 node
>    Modify /vpu_g1@38300000:status disabled
>    Found /vpu_g2@38310000 node
>    Modify /vpu_g2@38310000:status disabled
> 
> etc. on the console on every boot is needlessly verbose. Demote the
> "Found ..." lines to debug(), which is consistent with other instances
> in soc.c.
> 
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>   arch/arm/mach-imx/imx8m/soc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c
> index 5a4f8358c9..f5c82dff35 100644
> --- a/arch/arm/mach-imx/imx8m/soc.c
> +++ b/arch/arm/mach-imx/imx8m/soc.c
> @@ -736,7 +736,7 @@ static int disable_fdt_nodes(void *blob, const char *const nodes_path[], int siz
>   		if (nodeoff < 0)
>   			continue; /* Not found, skip it */
>   
> -		printf("Found %s node\n", nodes_path[i]);
> +		debug("Found %s node\n", nodes_path[i]);
>   
>   add_status:
>   		rc = fdt_setprop(blob, nodeoff, "status", status, strlen(status) + 1);
> @@ -1265,7 +1265,7 @@ int ft_system_setup(void *blob, struct bd_info *bd)
>   		if (nodeoff >= 0) {
>   			const char *speed = "high-speed";
>   
> -			printf("Found %s node\n", usb_dwc3_path[v]);
> +			debug("Found %s node\n", usb_dwc3_path[v]);
>   
>   usb_modify_speed:
>
Stefano Babic July 11, 2023, 7:41 p.m. UTC | #3
> Getting
>   Found /vpu_g1@38300000 node
>   Modify /vpu_g1@38300000:status disabled
>   Found /vpu_g2@38310000 node
>   Modify /vpu_g2@38310000:status disabled
> etc. on the console on every boot is needlessly verbose. Demote the
> "Found ..." lines to debug(), which is consistent with other instances
> in soc.c.
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c
index 5a4f8358c9..f5c82dff35 100644
--- a/arch/arm/mach-imx/imx8m/soc.c
+++ b/arch/arm/mach-imx/imx8m/soc.c
@@ -736,7 +736,7 @@  static int disable_fdt_nodes(void *blob, const char *const nodes_path[], int siz
 		if (nodeoff < 0)
 			continue; /* Not found, skip it */
 
-		printf("Found %s node\n", nodes_path[i]);
+		debug("Found %s node\n", nodes_path[i]);
 
 add_status:
 		rc = fdt_setprop(blob, nodeoff, "status", status, strlen(status) + 1);
@@ -1265,7 +1265,7 @@  int ft_system_setup(void *blob, struct bd_info *bd)
 		if (nodeoff >= 0) {
 			const char *speed = "high-speed";
 
-			printf("Found %s node\n", usb_dwc3_path[v]);
+			debug("Found %s node\n", usb_dwc3_path[v]);
 
 usb_modify_speed: